| Message ID | 1587468238-24032-3-git-send-email-yangtiezhu@loongson.cn (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | MIPS: Fix some issues about arch_mem_init() | expand |
On Tue, Apr 21, 2020 at 07:23:57PM +0800, Tiezhu Yang wrote: > In the current code, plat_mem_setup() is called by arch_mem_init() instead > of setup_arch() and has been declared in asm/bootinfo.h, so modify the code > comment to reflect the reality and remove the useless duplicate declartion > in arch/mips/kernel/setup.c. > > Fixes: 2925aba4223f ("[MIPS] Cleanup memory management initialization.") this isn't a fix, so please no fixes tag. Thomas.
On 04/21/2020 07:46 PM, Thomas Bogendoerfer wrote: > On Tue, Apr 21, 2020 at 07:23:57PM +0800, Tiezhu Yang wrote: >> In the current code, plat_mem_setup() is called by arch_mem_init() instead >> of setup_arch() and has been declared in asm/bootinfo.h, so modify the code >> comment to reflect the reality and remove the useless duplicate declartion >> in arch/mips/kernel/setup.c. >> >> Fixes: 2925aba4223f ("[MIPS] Cleanup memory management initialization.") > this isn't a fix, so please no fixes tag. OK, I will remove the tag and send v3. > > Thomas. >
diff --git a/arch/mips/include/asm/bootinfo.h b/arch/mips/include/asm/bootinfo.h index 6172778..dcd6a75 100644 --- a/arch/mips/include/asm/bootinfo.h +++ b/arch/mips/include/asm/bootinfo.h @@ -121,7 +121,7 @@ extern unsigned long fw_passed_dtb; #endif /* - * Platform memory detection hook called by setup_arch + * Platform memory detection hook called by arch_mem_init() */ extern void plat_mem_setup(void); diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c index b1e2d43..5481a0c 100644 --- a/arch/mips/kernel/setup.c +++ b/arch/mips/kernel/setup.c @@ -654,8 +654,6 @@ static void __init bootcmdline_init(char **cmdline_p) */ static void __init arch_mem_init(char **cmdline_p) { - extern void plat_mem_setup(void); - /* call board setup routine */ plat_mem_setup(); memblock_set_bottom_up(true);
In the current code, plat_mem_setup() is called by arch_mem_init() instead of setup_arch() and has been declared in asm/bootinfo.h, so modify the code comment to reflect the reality and remove the useless duplicate declartion in arch/mips/kernel/setup.c. Fixes: 2925aba4223f ("[MIPS] Cleanup memory management initialization.") Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> --- v2: - no changes arch/mips/include/asm/bootinfo.h | 2 +- arch/mips/kernel/setup.c | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-)