| Message ID | 20200422125808.38278-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | [v1] hwrng: Use UUID API for exporting the UUID | expand |
On Wed, 22 Apr 2020 at 18:28, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > There is export_uuid() function which exports uuid_t to the u8 array. > Use it instead of open coding variant. > > This allows to hide the uuid_t internals. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/char/hw_random/optee-rng.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Sumit Garg <sumit.garg@linaro.org> > diff --git a/drivers/char/hw_random/optee-rng.c b/drivers/char/hw_random/optee-rng.c > index ddfbabaa5f8f6..49b2e02537ddb 100644 > --- a/drivers/char/hw_random/optee-rng.c > +++ b/drivers/char/hw_random/optee-rng.c > @@ -226,7 +226,7 @@ static int optee_rng_probe(struct device *dev) > return -ENODEV; > > /* Open session with hwrng Trusted App */ > - memcpy(sess_arg.uuid, rng_device->id.uuid.b, TEE_IOCTL_UUID_LEN); > + export_uuid(sess_arg.uuid, &rng_device->id.uuid); > sess_arg.clnt_login = TEE_IOCTL_LOGIN_PUBLIC; > sess_arg.num_params = 0; > > -- > 2.26.1 >
On Wed, Apr 22, 2020 at 03:58:08PM +0300, Andy Shevchenko wrote: > There is export_uuid() function which exports uuid_t to the u8 array. > Use it instead of open coding variant. > > This allows to hide the uuid_t internals. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/char/hw_random/optee-rng.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks.
diff --git a/drivers/char/hw_random/optee-rng.c b/drivers/char/hw_random/optee-rng.c index ddfbabaa5f8f6..49b2e02537ddb 100644 --- a/drivers/char/hw_random/optee-rng.c +++ b/drivers/char/hw_random/optee-rng.c @@ -226,7 +226,7 @@ static int optee_rng_probe(struct device *dev) return -ENODEV; /* Open session with hwrng Trusted App */ - memcpy(sess_arg.uuid, rng_device->id.uuid.b, TEE_IOCTL_UUID_LEN); + export_uuid(sess_arg.uuid, &rng_device->id.uuid); sess_arg.clnt_login = TEE_IOCTL_LOGIN_PUBLIC; sess_arg.num_params = 0;
There is export_uuid() function which exports uuid_t to the u8 array. Use it instead of open coding variant. This allows to hide the uuid_t internals. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/char/hw_random/optee-rng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)