| Message ID | 20200422120532.31492-1-mateusz.gorski@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add support for different DMIC configurations | expand |
On 2020-04-22 14:05, Mateusz Gorski wrote: > Set of patches to enable DMIC capture on different hardware > configurations. > Information about supported DMIC configuration is read from NHLT and > correct pipeline configuration is selected automatically. > Also, adding additional option for topology binary name which is > based on used machine driver. *seems like this thread is missing few maintainers in CC* > > Mateusz Gorski (3): > ASoC: Intel: Skylake: Add alternative topology binary name > ASoC: Intel: Multiple I/O PCM format support for pipe > ASoC: Intel: Skylake: Automatic DMIC format configuration according to > information from NHLT > > Changes in v2: > - removed patch 1/4 swapping machine device and platform device > registration order > - alt_tplg_name creation now uses different field to read machine driver > name > - including of <sound/soc-acpi.h> moved to different patch Ain't change-block supposed to be just below message body? > > include/uapi/sound/skl-tplg-interface.h | 2 + > sound/soc/intel/skylake/skl-topology.c | 189 +++++++++++++++++++++++- > sound/soc/intel/skylake/skl-topology.h | 1 + > 3 files changed, 187 insertions(+), 5 deletions(-) > You have forgotten to add my Reviewed-by tag as both, v1 and v2 were reviewed by me internally before upstreaming. Thanks for addressing Pierre's review - indeed i2s_dev field usage could have been avoided. Good review, Pierre. Don't believe series need to be resend just to fix cosmetics: Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>
On Thu, Apr 23, 2020 at 11:11:05AM +0200, Cezary Rojewski wrote: > On 2020-04-22 14:05, Mateusz Gorski wrote: > > Changes in v2: > > - removed patch 1/4 swapping machine device and platform device > > registration order > > - alt_tplg_name creation now uses different field to read machine driver > > name > > - including of <sound/soc-acpi.h> moved to different patch > Ain't change-block supposed to be just below message body? Only in patches to stop them getting included in the git changelog. > Don't believe series need to be resend just to fix cosmetics: > Acked-by: Cezary Rojewski <cezary.rojewski@intel.com> Well, I don't seem to have a copy of it so it'll need a resend for that unless it's just held up somewhere and arrives shortly.
On 2020-04-23 12:21, Mark Brown wrote: > On Thu, Apr 23, 2020 at 11:11:05AM +0200, Cezary Rojewski wrote: >> On 2020-04-22 14:05, Mateusz Gorski wrote: > >>> Changes in v2: >>> - removed patch 1/4 swapping machine device and platform device >>> registration order >>> - alt_tplg_name creation now uses different field to read machine driver >>> name >>> - including of <sound/soc-acpi.h> moved to different patch > >> Ain't change-block supposed to be just below message body? > > Only in patches to stop them getting included in the git changelog. > Thanks for info, Mark. >> Don't believe series need to be resend just to fix cosmetics: >> Acked-by: Cezary Rojewski <cezary.rojewski@intel.com> > > Well, I don't seem to have a copy of it so it'll need a resend for that > unless it's just held up somewhere and arrives shortly. > Doubt it will as Mateusz forgot to include you & Pierre in v2. Resend it is then!
Set of patches to enable DMIC capture on different hardware configurations. Information about supported DMIC configuration is read from NHLT and correct pipeline configuration is selected automatically. Also, adding additional option for topology binary name which is based on used machine driver. Mateusz Gorski (3): ASoC: Intel: Skylake: Add alternative topology binary name ASoC: Intel: Multiple I/O PCM format support for pipe ASoC: Intel: Skylake: Automatic DMIC format configuration according to information from NHLT Changes in v2: - removed patch 1/4 swapping machine device and platform device registration order - alt_tplg_name creation now uses different field to read machine driver name - including of <sound/soc-acpi.h> moved to different patch include/uapi/sound/skl-tplg-interface.h | 2 + sound/soc/intel/skylake/skl-topology.c | 189 +++++++++++++++++++++++- sound/soc/intel/skylake/skl-topology.h | 1 + 3 files changed, 187 insertions(+), 5 deletions(-)