| Message ID | 20200423153211.17223-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1] zonefs: Replace uuid_copy() with import_uuid() | expand |
On 04/23/2020 08:32 AM, Andy Shevchenko wrote: > There is a specific API to treat raw data as UUID, i.e. import_uuid(). > Use it instead of uuid_copy() with explicit casting. > > Signed-off-by: Andy Shevchenko<andriy.shevchenko@linux.intel.com> At the end it does the same thing, I think we can avoid cast though. Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
On Thu, Apr 23, 2020 at 03:43:32PM +0000, Chaitanya Kulkarni wrote: > On 04/23/2020 08:32 AM, Andy Shevchenko wrote: > > There is a specific API to treat raw data as UUID, i.e. import_uuid(). > > Use it instead of uuid_copy() with explicit casting. > > > > Signed-off-by: Andy Shevchenko<andriy.shevchenko@linux.intel.com> > > At the end it does the same thing, For now yes, who knows how uuid_t will look like in the future... > I think we can avoid cast though. This and possibility to change uuid_t if needed. > Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> Thanks!
On Thu, Apr 23, 2020 at 5:32 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > There is a specific API to treat raw data as UUID, i.e. import_uuid(). > Use it instead of uuid_copy() with explicit casting. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Looks good, Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
On Thu, 2020-04-23 at 18:32 +0300, Andy Shevchenko wrote: > There is a specific API to treat raw data as UUID, i.e. import_uuid(). > Use it instead of uuid_copy() with explicit casting. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > fs/zonefs/super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c > index dba874a61fc5c3..82af1f2bd8c85b 100644 > --- a/fs/zonefs/super.c > +++ b/fs/zonefs/super.c > @@ -1266,7 +1266,7 @@ static int zonefs_read_super(struct super_block *sb) > goto unmap; > } > > - uuid_copy(&sbi->s_uuid, (uuid_t *)super->s_uuid); > + import_uuid(&sbi->s_uuid, super->s_uuid); > ret = 0; > > unmap: Queued in for-5.8. Thanks !
diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c index dba874a61fc5c3..82af1f2bd8c85b 100644 --- a/fs/zonefs/super.c +++ b/fs/zonefs/super.c @@ -1266,7 +1266,7 @@ static int zonefs_read_super(struct super_block *sb) goto unmap; } - uuid_copy(&sbi->s_uuid, (uuid_t *)super->s_uuid); + import_uuid(&sbi->s_uuid, super->s_uuid); ret = 0; unmap:
There is a specific API to treat raw data as UUID, i.e. import_uuid(). Use it instead of uuid_copy() with explicit casting. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- fs/zonefs/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)