| Message ID | 20200424122407.GA5523@syed (mailing list archive) |
|---|---|
| Headers | show |
| Series | Introduce the for_each_set_clump macro | expand |
On Fri, Apr 24, 2020 at 05:54:07PM +0530, Syed Nayyar Waris wrote: > This patchset introduces a new generic version of for_each_set_clump. > The previous version of for_each_set_clump8 used a fixed size 8-bit > clump, but the new generic version can work with clump of any size but > less than or equal to BITS_PER_LONG. The patchset utilizes the new macro > in several GPIO drivers. Regarding the nomenclature, I created the term "clump" to represent an 8-bit value that was not necessarily a byte yet was a contiguous grouping of bits. With this patchset, we now have a more generic for_each_set_clump macro that can handle values larger and smaller than 8-bits. Would it make sense to retire the term "clump" and instead use "nbits" where applicable, in order to match the existing convention used by the bitmap functions; for instance, would it be better to name this macro for_each_set_nbits? William Breathitt Gray
On Fri, Apr 24, 2020 at 05:54:07PM +0530, Syed Nayyar Waris wrote: > This patchset introduces a new generic version of for_each_set_clump. > The previous version of for_each_set_clump8 used a fixed size 8-bit > clump, but the new generic version can work with clump of any size but > less than or equal to BITS_PER_LONG. The patchset utilizes the new macro > in several GPIO drivers. You have broken thread. Please, use --thread when run `git format-patch ...`.
This patchset introduces a new generic version of for_each_set_clump. The previous version of for_each_set_clump8 used a fixed size 8-bit clump, but the new generic version can work with clump of any size but less than or equal to BITS_PER_LONG. The patchset utilizes the new macro in several GPIO drivers. The earlier 8-bit for_each_set_clump8 facilitated a for-loop syntax that iterates over a memory region entire groups of set bits at a time. For example, suppose you would like to iterate over a 32-bit integer 8 bits at a time, skipping over 8-bit groups with no set bit, where XXXXXXXX represents the current 8-bit group: Example: 10111110 00000000 11111111 00110011 First loop: 10111110 00000000 11111111 XXXXXXXX Second loop: 10111110 00000000 XXXXXXXX 00110011 Third loop: XXXXXXXX 00000000 11111111 00110011 Each iteration of the loop returns the next 8-bit group that has at least one set bit. But with the new for_each_set_clump the clump size can be different from 8 bits. Moreover, the clump can be split at word boundary in situations where word size is not multiple of clump size. Following are examples showing the working of new macro for clump sizes of 24 bits and 6 bits. Example 1: clump size: 24 bits, Number of clumps (or ports): 10 bitmap stores the bit information from where successive clumps are retrieved. /* bitmap memory region */ 0x00aa0000ff000000; /* Most significant bits */ 0xaaaaaa0000ff0000; 0x000000aa000000aa; 0xbbbbabcdeffedcba; /* Least significant bits */ Different iterations of for_each_set_clump:- 'offset' is the bit position and 'clump' is the 24 bit clump from the above bitmap. Iteration first: offset: 0 clump: 0xfedcba Iteration second: offset: 24 clump: 0xabcdef Iteration third: offset: 48 clump: 0xaabbbb Iteration fourth: offset: 96 clump: 0xaa Iteration fifth: offset: 144 clump: 0xff Iteration sixth: offset: 168 clump: 0xaaaaaa Iteration seventh: offset: 216 clump: 0xff Loop breaks because in the end the remaining bits (0x00aa) size was less than clump size of 24 bits. In above example it can be seen that in iteration third, the 24 bit clump that was retrieved was split between bitmap[0] and bitmap[1]. This example also shows that 24 bit zeroes if present in between, were skipped (preserving the previous for_each_set_macro8 behaviour). Example 2: clump size = 6 bits, Number of clumps (or ports) = 3. /* bitmap memory region */ 0x00aa0000ff000000; /* Most significant bits */ 0xaaaaaa0000ff0000; 0x0f00000000000000; 0x0000000000000ac0; /* Least significant bits */ Different iterations of for_each_set_clump: 'offset' is the bit position and 'clump' is the 6 bit clump from the above bitmap. Iteration first: offset: 6 clump: 0x2b Loop breaks because 6 * 3 = 18 bits traversed in bitmap. Here 6 * 3 is clump size * no. of clumps. Syed Nayyar Waris (6): bitops: Introduce the the for_each_set_clump macro lib/test_bitmap.c: Add for_each_set_clump test cases gpio: thermal: Utilize for_each_set_clump macro bitops: Remove code related to for_each_set_clump8 gpio: thunderx: Utilize for_each_set_clump macro gpio: xilinx: Utilize for_each_set_clump macro drivers/gpio/gpio-104-dio-48e.c | 8 +- drivers/gpio/gpio-104-idi-48.c | 4 +- drivers/gpio/gpio-74x164.c | 4 +- drivers/gpio/gpio-gpio-mm.c | 8 +- drivers/gpio/gpio-max3191x.c | 4 +- drivers/gpio/gpio-pca953x.c | 4 +- drivers/gpio/gpio-pci-idio-16.c | 8 +- drivers/gpio/gpio-pcie-idio-24.c | 8 +- drivers/gpio/gpio-pisosr.c | 4 +- drivers/gpio/gpio-thunderx.c | 12 ++- drivers/gpio/gpio-uniphier.c | 4 +- drivers/gpio/gpio-ws16c48.c | 8 +- drivers/gpio/gpio-xilinx.c | 64 +++++++------- drivers/thermal/intel/intel_soc_dts_iosf.c | 6 +- include/asm-generic/bitops/find.h | 12 +-- include/linux/bitmap.h | 60 +++++++++---- include/linux/bitops.h | 9 +- lib/find_bit.c | 12 +-- lib/test_bitmap.c | 136 ++++++++++++++++++++++++----- 19 files changed, 253 insertions(+), 122 deletions(-)