| Message ID | c8c666eb5c82dcb73621930b3fedf5814792bf1a.1587742492.git-series.maxime@cerno.tech (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/vc4: Support BCM2711 Display Pipeline | expand |
> config I2C_BRCMSTB > tristate "BRCM Settop/DSL I2C controller" > - depends on ARCH_BRCMSTB || BMIPS_GENERIC || ARCH_BCM_63XX || \ > - COMPILE_TEST > + depends on ARCH_BCM2835 || ARCH_BRCMSTB || BMIPS_GENERIC || \ > + ARCH_BCM_63XX || COMPILE_TEST Isn't there something like ARCH_BROADCOM which we could use here instead of adding each and every SoC?
On 4/24/2020 9:13 AM, Wolfram Sang wrote: > >> config I2C_BRCMSTB >> tristate "BRCM Settop/DSL I2C controller" >> - depends on ARCH_BRCMSTB || BMIPS_GENERIC || ARCH_BCM_63XX || \ >> - COMPILE_TEST >> + depends on ARCH_BCM2835 || ARCH_BRCMSTB || BMIPS_GENERIC || \ >> + ARCH_BCM_63XX || COMPILE_TEST > > Isn't there something like ARCH_BROADCOM which we could use here instead > of adding each and every SoC? If you are worried about this list growing bigger, I do not think this is going to happen beyond this changeset (famous last words). There is no ARCH_BROADCOM because there is typically very little commonality between SoC architectures within various Broadcom business units (left hand is not supposed to talk to the right hand) with the exception of a few peripherals that have been historically shared (NAND, SPI, XHCI, Ethernet PHYs/switches, etc. etc. This I2C controller historically came from the STB business unit, which given the market space has also engineered its own HDMI core and naturally incorporated the I2C core it already had into the HDMI core. Up until 2711, that HDMI core was not used by the 283x family at all.
On Fri, Apr 24, 2020 at 10:07:25AM -0700, Florian Fainelli wrote: > > > On 4/24/2020 9:13 AM, Wolfram Sang wrote: > > > >> config I2C_BRCMSTB > >> tristate "BRCM Settop/DSL I2C controller" > >> - depends on ARCH_BRCMSTB || BMIPS_GENERIC || ARCH_BCM_63XX || \ > >> - COMPILE_TEST > >> + depends on ARCH_BCM2835 || ARCH_BRCMSTB || BMIPS_GENERIC || \ > >> + ARCH_BCM_63XX || COMPILE_TEST > > > > Isn't there something like ARCH_BROADCOM which we could use here instead > > of adding each and every SoC? > > If you are worried about this list growing bigger, I do not think this > is going to happen beyond this changeset (famous last words). Okay, thanks for the heads up. I wonder, then, if the description after 'tristate' is still accurate? But that withstanding, I am fine with this patch: Acked-by: Wolfram Sang <wsa@the-dreams.de> Let me know if I shall take this via I2C.
On Fri, Apr 24, 2020 at 05:33:42PM +0200, Maxime Ripard wrote: > The BCM2711, supported by ARCH_BCM2835, also has a controller by the > brcmstb driver so let's allow it to be compiled on that platform. > > Cc: Kamal Dasu <kdasu.kdev@gmail.com> > Cc: Wolfram Sang <wsa@the-dreams.de> > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: linux-i2c@vger.kernel.org > Acked-by: Florian Fainelli <f.fainelli@gmail.com> > Signed-off-by: Maxime Ripard <maxime@cerno.tech> I reconsidered, and took it right away (as simple as it is). Applied to for-next, thanks!
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index 2ddca08f8a76..6644e0faa3df 100644 --- a/drivers/i2c/busses/Kconfig +++ b/drivers/i2c/busses/Kconfig @@ -475,8 +475,8 @@ config I2C_BCM_KONA config I2C_BRCMSTB tristate "BRCM Settop/DSL I2C controller" - depends on ARCH_BRCMSTB || BMIPS_GENERIC || ARCH_BCM_63XX || \ - COMPILE_TEST + depends on ARCH_BCM2835 || ARCH_BRCMSTB || BMIPS_GENERIC || \ + ARCH_BCM_63XX || COMPILE_TEST default y help If you say yes to this option, support will be included for the