| Message ID | 20200328185916.98423-3-rajatja@google.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v4,1/5] input/serio/i8042: Attach fwnode to serio i8042 kbd device | expand |
On Sat, Mar 28, 2020 at 11:59:14AM -0700, Rajat Jain wrote: > Create the documentation for the new introduced property, that > describes the function-row keys physical positions. > > Signed-off-by: Rajat Jain <rajatja@google.com> > --- > v4: Same as v3 > v3: same as v2 > v2: Remove the Change-Id from the commit log > > .../devicetree/bindings/input/atkbd.txt | 34 +++++++++++++++++++ > 1 file changed, 34 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/atkbd.txt > > diff --git a/Documentation/devicetree/bindings/input/atkbd.txt b/Documentation/devicetree/bindings/input/atkbd.txt > new file mode 100644 > index 0000000000000..816653eb8e98d > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/atkbd.txt > @@ -0,0 +1,34 @@ > +Device tree bindings for AT / PS2 keyboard device > + > +Optional properties: > + > + function-row-physmap: > + An ordered array of the physical codes for the function > + row keys. Arranged in order from left to right. A single optional property doesn't constitute a DT binding. > + > +Example: > + > + This is a sample ACPI _DSD node describing the property: Neither does this ACPI stuff. Rob
Hi, On Fri, Apr 10, 2020 at 10:38 AM Rob Herring <robh@kernel.org> wrote: > > On Sat, Mar 28, 2020 at 11:59:14AM -0700, Rajat Jain wrote: > > Create the documentation for the new introduced property, that > > describes the function-row keys physical positions. > > > > Signed-off-by: Rajat Jain <rajatja@google.com> > > --- > > v4: Same as v3 > > v3: same as v2 > > v2: Remove the Change-Id from the commit log > > > > .../devicetree/bindings/input/atkbd.txt | 34 +++++++++++++++++++ > > 1 file changed, 34 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/input/atkbd.txt > > > > diff --git a/Documentation/devicetree/bindings/input/atkbd.txt b/Documentation/devicetree/bindings/input/atkbd.txt > > new file mode 100644 > > index 0000000000000..816653eb8e98d > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/input/atkbd.txt > > @@ -0,0 +1,34 @@ > > +Device tree bindings for AT / PS2 keyboard device > > + > > +Optional properties: > > + > > + function-row-physmap: > > + An ordered array of the physical codes for the function > > + row keys. Arranged in order from left to right. > > A single optional property doesn't constitute a DT binding. > > > + > > +Example: > > + > > + This is a sample ACPI _DSD node describing the property: > > Neither does this ACPI stuff. I assume this means a nack to the documentation patches. Dmitry, can you apply the other patches in the series? Thanks, Rajat > > Rob
diff --git a/Documentation/devicetree/bindings/input/atkbd.txt b/Documentation/devicetree/bindings/input/atkbd.txt new file mode 100644 index 0000000000000..816653eb8e98d --- /dev/null +++ b/Documentation/devicetree/bindings/input/atkbd.txt @@ -0,0 +1,34 @@ +Device tree bindings for AT / PS2 keyboard device + +Optional properties: + + function-row-physmap: + An ordered array of the physical codes for the function + row keys. Arranged in order from left to right. + +Example: + + This is a sample ACPI _DSD node describing the property: + + Name (_DSD, Package () { + ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), + Package () { + Package () { "function-row-physmap", + Package () { + 0xEA, /* T1 BACK */ + 0xE7, /* T2 REFRESH */ + 0x91, /* T3 FULLSCREEN */ + 0x92, /* T4 SCALE */ + 0x93, /* T5 SNIP */ + 0x94, /* T6 BRIGHTNESS_DOWN */ + 0x95, /* T7 BRIGHTNESS_UP */ + 0x96, /* T8 PRIVACY_SCRN_TOGGLE */ + 0x97, /* T9 KBD_BKLIGHT_DOWN */ + 0x98, /* T10 KBD_BKLIGHT_UP */ + 0xA0, /* T11 VOL_MUTE */ + 0xAE, /* T12 VOL_DOWN */ + 0xB0, /* T13 VOL_UP */ + } + } + } + })
Create the documentation for the new introduced property, that describes the function-row keys physical positions. Signed-off-by: Rajat Jain <rajatja@google.com> --- v4: Same as v3 v3: same as v2 v2: Remove the Change-Id from the commit log .../devicetree/bindings/input/atkbd.txt | 34 +++++++++++++++++++ 1 file changed, 34 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/atkbd.txt