| Message ID | 20200426214925.10970-6-guoqing.jiang@cloud.ionos.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Introduce set/clear_fs_page_private to cleanup code | expand |
On 2020/4/27 5:49, Guoqing Jiang wrote: > Since the new pair function is introduced, we can call them to clean the > code in f2fs.h. > > Cc: Jaegeuk Kim <jaegeuk@kernel.org> > Cc: Chao Yu <chao@kernel.org> > Cc: linux-f2fs-devel@lists.sourceforge.net > Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com> Acked-by: Chao Yu <yuchao0@huawei.com> Thanks,
On 4/27/20 4:22 AM, Chao Yu wrote: > On 2020/4/27 5:49, Guoqing Jiang wrote: >> Since the new pair function is introduced, we can call them to clean the >> code in f2fs.h. >> >> Cc: Jaegeuk Kim <jaegeuk@kernel.org> >> Cc: Chao Yu <chao@kernel.org> >> Cc: linux-f2fs-devel@lists.sourceforge.net >> Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com> > Acked-by: Chao Yu <yuchao0@huawei.com> > Thanks for your review. Guoqing
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index ba470d5687fe..70ad8c51e0fc 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -3051,19 +3051,12 @@ static inline void f2fs_set_page_private(struct page *page, if (PagePrivate(page)) return; - get_page(page); - SetPagePrivate(page); - set_page_private(page, data); + set_fs_page_private(page, (void *)data); } static inline void f2fs_clear_page_private(struct page *page) { - if (!PagePrivate(page)) - return; - - set_page_private(page, 0); - ClearPagePrivate(page); - f2fs_put_page(page, 0); + clear_fs_page_private(page); } /*
Since the new pair function is introduced, we can call them to clean the code in f2fs.h. Cc: Jaegeuk Kim <jaegeuk@kernel.org> Cc: Chao Yu <chao@kernel.org> Cc: linux-f2fs-devel@lists.sourceforge.net Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com> --- fs/f2fs/f2fs.h | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-)