| Message ID | 1587976638-29806-1-git-send-email-brent.lu@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | add channel constraint for BDW machine drivers | expand |
On 2020-04-27 10:37, Brent Lu wrote: > The machine driver bdw-rt5650 (for Google buddy) supports 2 or 4-channel > recording while other two drivers support only 2-channel recording. HW > constraints are implemented to reflect the hardware limitation on BDW > platform. > Message body relates to bdw-rt5650 while the series touches every of BDW boards. Apart from review given for each and every patch (although most issues are shared so there is not as much to address) my question is: - are these hw limitations or software (machine board) limitations? Czarek > Brent Lu (3): > ASoC: bdw-rt5677: channel constraint support > ASoC: bdw-rt5650: channel constraint support > ASoC: broadwell: channel constraint support > > sound/soc/intel/boards/bdw-rt5650.c | 34 ++++++++++++++++++++++++++++++++++ > sound/soc/intel/boards/bdw-rt5677.c | 33 +++++++++++++++++++++++++++++++++ > sound/soc/intel/boards/broadwell.c | 33 +++++++++++++++++++++++++++++++++ > 3 files changed, 100 insertions(+) >
On 2020-04-27 13:01, Cezary Rojewski wrote: > On 2020-04-27 10:37, Brent Lu wrote: >> The machine driver bdw-rt5650 (for Google buddy) supports 2 or 4-channel >> recording while other two drivers support only 2-channel recording. HW >> constraints are implemented to reflect the hardware limitation on BDW >> platform. >> > > Message body relates to bdw-rt5650 while the series touches every of BDW > boards. Ignore my first sentence :-) Second still applies though > > Apart from review given for each and every patch (although most issues > are shared so there is not as much to address) my question is: > - are these hw limitations or software (machine board) limitations? > > Czarek > >> Brent Lu (3): >> ASoC: bdw-rt5677: channel constraint support >> ASoC: bdw-rt5650: channel constraint support >> ASoC: broadwell: channel constraint support >> >> sound/soc/intel/boards/bdw-rt5650.c | 34 >> ++++++++++++++++++++++++++++++++++ >> sound/soc/intel/boards/bdw-rt5677.c | 33 >> +++++++++++++++++++++++++++++++++ >> sound/soc/intel/boards/broadwell.c | 33 >> +++++++++++++++++++++++++++++++++ >> 3 files changed, 100 insertions(+) >>
> > > > Apart from review given for each and every patch (although most issues > > are shared so there is not as much to address) my question is: > > - are these hw limitations or software (machine board) limitations? The limitation comes from board. Bdw-rt5677 and Broadwell are using I2S with 2 microphones while Bdw-rt5650 is using PCM TDM with 4 microphones. Our DSP supports stereo playback and 2 or 4-channel capture (haswell/sst-haswell-pcm.c). > > > > Czarek > > > >> Brent Lu (3): > >> ASoC: bdw-rt5677: channel constraint support > >> ASoC: bdw-rt5650: channel constraint support > >> ASoC: broadwell: channel constraint support > >> > >> sound/soc/intel/boards/bdw-rt5650.c | 34 > >> ++++++++++++++++++++++++++++++++++ > >> sound/soc/intel/boards/bdw-rt5677.c | 33 > >> +++++++++++++++++++++++++++++++++ > >> sound/soc/intel/boards/broadwell.c | 33 > >> +++++++++++++++++++++++++++++++++ > >> 3 files changed, 100 insertions(+) > >>