| Message ID | 1588007614-25061-1-git-send-email-brent.lu@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | add channel constraint for BDW machine drivers | expand |
On 4/27/20 12:13 PM, Brent Lu wrote: > The machine driver bdw-rt5650 (for Google buddy) supports 2 or 4-channel > recording while other two drivers support only 2-channel recording. HW > constraints are implemented to reflect the hardware limitation on BDW > platform. > > Changes since v1: > - Change the patch title. > - Remove the DUAL_CHANNEL and QUAD_CHANNEL macros which are too obvious. > - Follow the naming convertion, using 'bdw_rt5650_' and 'bdw_rt5677_' to > name startup functions. > - Refine the comments in startup functions. > - Redesign the bdw_rt5650_fe_startup() function for readability. > - Add an assignment to initialize runtime->hw.channels_max variable. For the series Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > Brent Lu (3): > ASoC: bdw-rt5677: add channel constraint > ASoC: bdw-rt5650: add channel constraint > ASoC: broadwell: add channel constraint > > sound/soc/intel/boards/bdw-rt5650.c | 29 +++++++++++++++++++++++++++++ > sound/soc/intel/boards/bdw-rt5677.c | 26 ++++++++++++++++++++++++++ > sound/soc/intel/boards/broadwell.c | 26 ++++++++++++++++++++++++++ > 3 files changed, 81 insertions(+) >
On 2020-04-27 19:13, Brent Lu wrote: > The machine driver bdw-rt5650 (for Google buddy) supports 2 or 4-channel > recording while other two drivers support only 2-channel recording. HW > constraints are implemented to reflect the hardware limitation on BDW > platform. > > Changes since v1: > - Change the patch title. > - Remove the DUAL_CHANNEL and QUAD_CHANNEL macros which are too obvious. > - Follow the naming convertion, using 'bdw_rt5650_' and 'bdw_rt5677_' to > name startup functions. > - Refine the comments in startup functions. > - Redesign the bdw_rt5650_fe_startup() function for readability. > - Add an assignment to initialize runtime->hw.channels_max variable. > Thank you for addressing all listed issues. I'll recheck hw constraints on my end just to be sure but this series looks good already, so: Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>
On Tue, 28 Apr 2020 01:13:31 +0800, Brent Lu wrote: > The machine driver bdw-rt5650 (for Google buddy) supports 2 or 4-channel > recording while other two drivers support only 2-channel recording. HW > constraints are implemented to reflect the hardware limitation on BDW > platform. > > Changes since v1: > - Change the patch title. > - Remove the DUAL_CHANNEL and QUAD_CHANNEL macros which are too obvious. > - Follow the naming convertion, using 'bdw_rt5650_' and 'bdw_rt5677_' to > name startup functions. > - Refine the comments in startup functions. > - Redesign the bdw_rt5650_fe_startup() function for readability. > - Add an assignment to initialize runtime->hw.channels_max variable. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.8 Thanks! [1/3] ASoC: bdw-rt5677: add channel constraint commit: e241f8e77958de2b7708e72d7159952d2bd1f0fe [2/3] ASoC: bdw-rt5650: add channel constraint commit: 08d6713a4056cab5b29eb135eecb2e97492fc8d8 [3/3] ASoC: broadwell: add channel constraint commit: ad18763f46835b768714ac6de6dcf42384a261ca All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark