[PATCHv2,0/4] arm64: vdso: cleanups

Message

Mark Rutland April 28, 2020, 4:49 p.m. UTC

Hi all,

While attempting to review an arm64 vdso patch, I noticed some of the existing
code was somewhat baroque, making it harder than necessary to understand and
extend. These patches attempt to improve this by making the code more
consistent and avoiding unnecessary duplication.

The series is based on v5.7-rc3 and can be found in my arm64/vdso-cleanup
branch [1].

Since v1 [2]:
* Drop merged patch
* Fix broken AARCH32/AA32 naming in final two patches

I've build-tested each patch in this series with and without CONFIG_COMPAT_VDSO
selected, atop of defconfig, using the GCC 8.1.0 kernel.org cross toolchains
for arm64 and arm.

Thanks,
Mark.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/log/?h=arm64/vdso-cleanup

Mark Rutland (4):
  arm64: vdso: remove aarch32_vdso_pages[]
  arm64: vdso: simplify arch_vdso_type ifdeffery
  arm64: vdso: use consistent 'abi' nomenclature
  arm64: vdso: use consistent 'map' nomenclature

 arch/arm64/kernel/vdso.c | 149 +++++++++++++++++++++--------------------------
 1 file changed, 68 insertions(+), 81 deletions(-)

Comments

Will Deacon April 29, 2020, 10:30 a.m. UTC | #1

On Tue, 28 Apr 2020 17:49:17 +0100, Mark Rutland wrote:
> While attempting to review an arm64 vdso patch, I noticed some of the existing
> code was somewhat baroque, making it harder than necessary to understand and
> extend. These patches attempt to improve this by making the code more
> consistent and avoiding unnecessary duplication.
> 
> The series is based on v5.7-rc3 and can be found in my arm64/vdso-cleanup
> branch [1].
> 
> [...]

Applied to arm64 (for-next/vdso), thanks!

[1/4] arm64: vdso: remove aarch32_vdso_pages[]
      https://git.kernel.org/arm64/c/74fc72e77dc5
[2/4] arm64: vdso: simplify arch_vdso_type ifdeffery
      https://git.kernel.org/arm64/c/3ee16ff3437c
[3/4] arm64: vdso: use consistent 'abi' nomenclature
      https://git.kernel.org/arm64/c/d3418f3839b6
[4/4] arm64: vdso: use consistent 'map' nomenclature
      https://git.kernel.org/arm64/c/1d09094aa620

Cheers,