| Message ID | 1581575451-948-1-git-send-email-yiboz@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Allow qca988x family to support ack rssi of tx data packets. | expand |
Yibo Zhao <yiboz@codeaurora.org> wrote: > Hardwares tested : QCA9887 > Firmwares tested : 10.4-3.9.0.1-00036 > > Signed-off-by: Yibo Zhao <yiboz@codeaurora.org> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. 5637c4ca961b ath10k: allow qca988x family to support ack rssi of tx data packets.
Hello,
> Firmwares tested : 10.4-3.9.0.1-00036
The firmware above is unavailable anywhere.
This patch doesn't seem to work on the latest publicly available
firmware, 10.2.4-1.0-00047.
Best regards,
John
John Deere <24601deerej@gmail.com> writes: > Hello, > >> Firmwares tested : 10.4-3.9.0.1-00036 > > The firmware above is unavailable anywhere. It's here: https://github.com/kvalo/ath10k-firmware/blob/master/QCA9984/hw1.0/3.9.0.1/firmware-5.bin_10.4-3.9.0.1-00036
Hi Kalle, That is for the QCA9884, not the QCA9887 as listed in the hardware tested. On 4/30/20 6:28 PM, Kalle Valo wrote: > John Deere <24601deerej@gmail.com> writes: > >> Hello, >> >>> Firmwares tested : 10.4-3.9.0.1-00036 >> >> The firmware above is unavailable anywhere. > > It's here: > > https://github.com/kvalo/ath10k-firmware/blob/master/QCA9984/hw1.0/3.9.0.1/firmware-5.bin_10.4-3.9.0.1-00036 >
(Fixing top posting and adding Yibo) John Deere <24601deerej@gmail.com> writes: > On 4/30/20 6:28 PM, Kalle Valo wrote: >> John Deere <24601deerej@gmail.com> writes: >> >>> Hello, >>> >>>> Firmwares tested : 10.4-3.9.0.1-00036 >>> >>> The firmware above is unavailable anywhere. >> >> It's here: >> >> https://github.com/kvalo/ath10k-firmware/blob/master/QCA9984/hw1.0/3.9.0.1/firmware-5.bin_10.4-3.9.0.1-00036 > > That is for the QCA9884, not the QCA9887 as listed in the hardware tested. Good point, I missed that. Thanks for pointing it out. So we are talking about this commit: commit 5637c4ca961bc72ae3cce4bd5cbcecb5b8e32a54 Author: Yibo Zhao <yiboz@codeaurora.org> AuthorDate: Wed Mar 11 19:23:29 2020 +0200 Commit: Kalle Valo <kvalo@codeaurora.org> CommitDate: Thu Mar 12 10:20:02 2020 +0200 ath10k: allow qca988x family to support ack rssi of tx data packets. Hardwares tested : QCA9887 Firmwares tested : 10.4-3.9.0.1-00036 Signed-off-by: Yibo Zhao <yiboz@codeaurora.org> Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Yibo, we don't have 10.4 firmware for QCA9887 so the commit log doesn't make sense. How did you test this on QCA9887?
diff --git a/drivers/net/wireless/ath/ath10k/hw.c b/drivers/net/wireless/ath/ath10k/hw.c index 2451e0f..57c58af 100644 --- a/drivers/net/wireless/ath/ath10k/hw.c +++ b/drivers/net/wireless/ath/ath10k/hw.c @@ -1131,6 +1131,7 @@ static int ath10k_get_htt_tx_data_rssi_pad(struct htt_resp *resp) const struct ath10k_hw_ops qca988x_ops = { .set_coverage_class = ath10k_hw_qca988x_set_coverage_class, + .is_rssi_enable = ath10k_htt_tx_rssi_enable, }; static int ath10k_qca99x0_rx_desc_get_l3_pad_bytes(struct htt_rx_desc *rxd)
Hardwares tested : QCA9887 Firmwares tested : 10.4-3.9.0.1-00036 Signed-off-by: Yibo Zhao <yiboz@codeaurora.org> --- drivers/net/wireless/ath/ath10k/hw.c | 1 + 1 file changed, 1 insertion(+)