| Message ID | 1587084091-5941-1-git-send-email-Anson.Huang@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [V3,1/5] dt-bindings: clock: Convert i.MX6Q clock to json-schema | expand |
Hi Anson, thanks for the patches :) one last nitpick. On 20-04-17 08:41, Anson Huang wrote: ... > +examples: > + # Clock Control Module node: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + clks: clock-controller@20c4000 { > + compatible = "fsl,imx6q-ccm"; > + reg = <0x020c4000 0x4000>; > + interrupts = <0 87 IRQ_TYPE_LEVEL_HIGH>, > + <0 88 IRQ_TYPE_LEVEL_HIGH>; The imx6ull and others start using the GIC_SPI define within the example. We should take the chance to uniform that. Apart of this feel free to add my: Reviewed-by: Marco Felsch <m.felsch@pengutronix.de> Regards, Marco > + #clock-cells = <1>; > + };
Hi, Marco > Subject: Re: [PATCH V3 1/5] dt-bindings: clock: Convert i.MX6Q clock to > json-schema > > Hi Anson, > > thanks for the patches :) one last nitpick. > > On 20-04-17 08:41, Anson Huang wrote: > > ... > > > +examples: > > + # Clock Control Module node: > > + - | > > + #include <dt-bindings/interrupt-controller/arm-gic.h> > > + > > + clks: clock-controller@20c4000 { > > + compatible = "fsl,imx6q-ccm"; > > + reg = <0x020c4000 0x4000>; > > + interrupts = <0 87 IRQ_TYPE_LEVEL_HIGH>, > > + <0 88 IRQ_TYPE_LEVEL_HIGH>; > > The imx6ull and others start using the GIC_SPI define within the example. We > should take the chance to uniform that. Apart of this feel free to add my: > > Reviewed-by: Marco Felsch <m.felsch@pengutronix.de> OK, if there is other comments that need to send next version, I will change it. Thanks, Anson
On Fri, Apr 17, 2020 at 08:41:27AM +0800, Anson Huang wrote: > Convert the i.MX6Q clock binding to DT schema format using json-schema. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > Changes since V2: > - Force 'interrupts' minItem/maxItem to 2. Not necessary. maxItems is sufficient. > --- > .../devicetree/bindings/clock/imx6q-clock.txt | 41 ------------- > .../devicetree/bindings/clock/imx6q-clock.yaml | 67 ++++++++++++++++++++++ > 2 files changed, 67 insertions(+), 41 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/clock/imx6q-clock.txt > create mode 100644 Documentation/devicetree/bindings/clock/imx6q-clock.yaml > > diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.txt b/Documentation/devicetree/bindings/clock/imx6q-clock.txt > deleted file mode 100644 > index 13d36d4..0000000 > --- a/Documentation/devicetree/bindings/clock/imx6q-clock.txt > +++ /dev/null > @@ -1,41 +0,0 @@ > -* Clock bindings for Freescale i.MX6 Quad > - > -Required properties: > -- compatible: Should be "fsl,imx6q-ccm" > -- reg: Address and length of the register set > -- interrupts: Should contain CCM interrupt > -- #clock-cells: Should be <1> > - > -Optional properties: > -- fsl,pmic-stby-poweroff: Configure CCM to assert PMIC_STBY_REQ signal > - on power off. > - Use this property if the SoC should be powered off by external power > - management IC (PMIC) triggered via PMIC_STBY_REQ signal. > - Boards that are designed to initiate poweroff on PMIC_ON_REQ signal should > - be using "syscon-poweroff" driver instead. > -- clocks: list of clock specifiers, must contain an entry for each entry > - in clock-names > -- clock-names: valid names are "osc", "ckil", "ckih1", "anaclk1" and "anaclk2" > - > -The clock consumer should specify the desired clock by having the clock > -ID in its "clocks" phandle cell. See include/dt-bindings/clock/imx6qdl-clock.h > -for the full list of i.MX6 Quad and DualLite clock IDs. > - > -Examples: > - > -#include <dt-bindings/clock/imx6qdl-clock.h> > - > -clks: ccm@20c4000 { > - compatible = "fsl,imx6q-ccm"; > - reg = <0x020c4000 0x4000>; > - interrupts = <0 87 0x04 0 88 0x04>; > - #clock-cells = <1>; > -}; > - > -uart1: serial@2020000 { > - compatible = "fsl,imx6q-uart", "fsl,imx21-uart"; > - reg = <0x02020000 0x4000>; > - interrupts = <0 26 0x04>; > - clocks = <&clks IMX6QDL_CLK_UART_IPG>, <&clks IMX6QDL_CLK_UART_SERIAL>; > - clock-names = "ipg", "per"; > -}; > diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml > new file mode 100644 > index 0000000..0daf789 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml > @@ -0,0 +1,67 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/imx6q-clock.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Clock bindings for Freescale i.MX6 Quad > + > +maintainers: > + - Anson Huang <Anson.Huang@nxp.com> > + > +properties: > + compatible: > + const: fsl,imx6q-ccm > + > + reg: > + maxItems: 1 > + > + interrupts: > + minItems: 2 > + maxItems: 2 > + > + '#clock-cells': > + const: 1 > + > + clocks: > + items: > + - description: 24m osc > + - description: 32k osc > + - description: ckih1 clock input > + - description: anaclk1 clock input > + - description: anaclk2 clock input > + > + clock-names: > + items: > + - const: osc > + - const: ckil > + - const: ckih1 > + - const: anaclk1 > + - const: anaclk2 > + > + fsl,pmic-stby-poweroff: > + $ref: /schemas/types.yaml#/definitions/flag > + description: | > + Use this property if the SoC should be powered off by external power > + management IC (PMIC) triggered via PMIC_STBY_REQ signal. > + Boards that are designed to initiate poweroff on PMIC_ON_REQ signal should > + be using "syscon-poweroff" driver instead. > + > +required: > + - compatible > + - reg > + - interrupts > + - '#clock-cells' > + > +examples: > + # Clock Control Module node: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + clks: clock-controller@20c4000 { Drop the label. > + compatible = "fsl,imx6q-ccm"; > + reg = <0x020c4000 0x4000>; > + interrupts = <0 87 IRQ_TYPE_LEVEL_HIGH>, > + <0 88 IRQ_TYPE_LEVEL_HIGH>; > + #clock-cells = <1>; > + }; > -- > 2.7.4 >
On Fri, Apr 17, 2020 at 08:41:27AM +0800, Anson Huang wrote: > Convert the i.MX6Q clock binding to DT schema format using json-schema. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > Changes since V2: > - Force 'interrupts' minItem/maxItem to 2. > --- > .../devicetree/bindings/clock/imx6q-clock.txt | 41 ------------- > .../devicetree/bindings/clock/imx6q-clock.yaml | 67 ++++++++++++++++++++++ > 2 files changed, 67 insertions(+), 41 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/clock/imx6q-clock.txt > create mode 100644 Documentation/devicetree/bindings/clock/imx6q-clock.yaml > diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml > new file mode 100644 > index 0000000..0daf789 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml > @@ -0,0 +1,67 @@ > +# SPDX-License-Identifier: GPL-2.0 If NXP is the only author on these, please dual license: (GPL-2.0-only OR BSD-2-Clause)
diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.txt b/Documentation/devicetree/bindings/clock/imx6q-clock.txt deleted file mode 100644 index 13d36d4..0000000 --- a/Documentation/devicetree/bindings/clock/imx6q-clock.txt +++ /dev/null @@ -1,41 +0,0 @@ -* Clock bindings for Freescale i.MX6 Quad - -Required properties: -- compatible: Should be "fsl,imx6q-ccm" -- reg: Address and length of the register set -- interrupts: Should contain CCM interrupt -- #clock-cells: Should be <1> - -Optional properties: -- fsl,pmic-stby-poweroff: Configure CCM to assert PMIC_STBY_REQ signal - on power off. - Use this property if the SoC should be powered off by external power - management IC (PMIC) triggered via PMIC_STBY_REQ signal. - Boards that are designed to initiate poweroff on PMIC_ON_REQ signal should - be using "syscon-poweroff" driver instead. -- clocks: list of clock specifiers, must contain an entry for each entry - in clock-names -- clock-names: valid names are "osc", "ckil", "ckih1", "anaclk1" and "anaclk2" - -The clock consumer should specify the desired clock by having the clock -ID in its "clocks" phandle cell. See include/dt-bindings/clock/imx6qdl-clock.h -for the full list of i.MX6 Quad and DualLite clock IDs. - -Examples: - -#include <dt-bindings/clock/imx6qdl-clock.h> - -clks: ccm@20c4000 { - compatible = "fsl,imx6q-ccm"; - reg = <0x020c4000 0x4000>; - interrupts = <0 87 0x04 0 88 0x04>; - #clock-cells = <1>; -}; - -uart1: serial@2020000 { - compatible = "fsl,imx6q-uart", "fsl,imx21-uart"; - reg = <0x02020000 0x4000>; - interrupts = <0 26 0x04>; - clocks = <&clks IMX6QDL_CLK_UART_IPG>, <&clks IMX6QDL_CLK_UART_SERIAL>; - clock-names = "ipg", "per"; -}; diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml new file mode 100644 index 0000000..0daf789 --- /dev/null +++ b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml @@ -0,0 +1,67 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/clock/imx6q-clock.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Clock bindings for Freescale i.MX6 Quad + +maintainers: + - Anson Huang <Anson.Huang@nxp.com> + +properties: + compatible: + const: fsl,imx6q-ccm + + reg: + maxItems: 1 + + interrupts: + minItems: 2 + maxItems: 2 + + '#clock-cells': + const: 1 + + clocks: + items: + - description: 24m osc + - description: 32k osc + - description: ckih1 clock input + - description: anaclk1 clock input + - description: anaclk2 clock input + + clock-names: + items: + - const: osc + - const: ckil + - const: ckih1 + - const: anaclk1 + - const: anaclk2 + + fsl,pmic-stby-poweroff: + $ref: /schemas/types.yaml#/definitions/flag + description: | + Use this property if the SoC should be powered off by external power + management IC (PMIC) triggered via PMIC_STBY_REQ signal. + Boards that are designed to initiate poweroff on PMIC_ON_REQ signal should + be using "syscon-poweroff" driver instead. + +required: + - compatible + - reg + - interrupts + - '#clock-cells' + +examples: + # Clock Control Module node: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + + clks: clock-controller@20c4000 { + compatible = "fsl,imx6q-ccm"; + reg = <0x020c4000 0x4000>; + interrupts = <0 87 IRQ_TYPE_LEVEL_HIGH>, + <0 88 IRQ_TYPE_LEVEL_HIGH>; + #clock-cells = <1>; + };
Convert the i.MX6Q clock binding to DT schema format using json-schema. Signed-off-by: Anson Huang <Anson.Huang@nxp.com> --- Changes since V2: - Force 'interrupts' minItem/maxItem to 2. --- .../devicetree/bindings/clock/imx6q-clock.txt | 41 ------------- .../devicetree/bindings/clock/imx6q-clock.yaml | 67 ++++++++++++++++++++++ 2 files changed, 67 insertions(+), 41 deletions(-) delete mode 100644 Documentation/devicetree/bindings/clock/imx6q-clock.txt create mode 100644 Documentation/devicetree/bindings/clock/imx6q-clock.yaml