| Message ID | 20200429155218.7308-1-oneukum@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [PATCHv3] UAS: add quirk for LaCie 2Big Quadra | expand |
On Wed, Apr 29, 2020 at 05:52:18PM +0200, Oliver Neukum wrote: > This device needs US_FL_NO_REPORT_OPCODES to avoid going > through prolonged error handling on enumeration. > > v2: correct sorting order > v3: really correct ordering > > Signed-off-by: Oliver Neukum <oneukum@suse.com> > Reported-by: Julian Groß <julian.g@posteo.de> > --- > drivers/usb/storage/unusual_uas.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h > index cfdec74e0f4a..4f4c134f0ffd 100644 > --- a/drivers/usb/storage/unusual_uas.h > +++ b/drivers/usb/storage/unusual_uas.h > @@ -32,6 +32,14 @@ > * Apricorn USB3 dongle sometimes returns "USBSUSBSUSBS" in response to SCSI > * commands in UAS mode. Observed with the 1.28 firmware; are there others? > */ > + > +/* Reported-by: Julian Groß <julian.g@posteo.de> */ > +UNUSUAL_DEV(0x059f, 0x105f, 0x0000, 0x9999, > + "LaCie", > + "2Big Quadra USB3", > + USB_SC_DEVICE, USB_PR_DEVICE, NULL, > + US_FL_NO_REPORT_OPCODES), > + Dude, you need more sleep. The comment needs to say at the entry for the Apricorn device below: > UNUSUAL_DEV(0x0984, 0x0301, 0x0128, 0x0128, > "Apricorn", > "", Let me fix this up by hand... greg k-h
diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h index cfdec74e0f4a..4f4c134f0ffd 100644 --- a/drivers/usb/storage/unusual_uas.h +++ b/drivers/usb/storage/unusual_uas.h @@ -32,6 +32,14 @@ * Apricorn USB3 dongle sometimes returns "USBSUSBSUSBS" in response to SCSI * commands in UAS mode. Observed with the 1.28 firmware; are there others? */ + +/* Reported-by: Julian Groß <julian.g@posteo.de> */ +UNUSUAL_DEV(0x059f, 0x105f, 0x0000, 0x9999, + "LaCie", + "2Big Quadra USB3", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_NO_REPORT_OPCODES), + UNUSUAL_DEV(0x0984, 0x0301, 0x0128, 0x0128, "Apricorn", "",
This device needs US_FL_NO_REPORT_OPCODES to avoid going through prolonged error handling on enumeration. v2: correct sorting order v3: really correct ordering Signed-off-by: Oliver Neukum <oneukum@suse.com> Reported-by: Julian Groß <julian.g@posteo.de> --- drivers/usb/storage/unusual_uas.h | 8 ++++++++ 1 file changed, 8 insertions(+)