mbox series

[v2,00/10] Cadence GEM Fixes

Message ID 1588601168-27576-1-git-send-email-sai.pavan.boddu@xilinx.com (mailing list archive)
Headers show
Series Cadence GEM Fixes | expand

Message

Sai Pavan Boddu May 4, 2020, 2:05 p.m. UTC
Hi,

Following patch series fixes issues with priority queues,
Adds JUMBO Frame support,
Makes Debug statements compilable &
Fixes related to multicast frames.

Changes for V2:
	Fixed build failure on fedora docker machine
	Fix buggy debug print to use sized integer casting

Sai Pavan Boddu (9):
  net: cadence_gem: Fix debug statements
  net: cadence_gem: Fix the queue address update during wrap around
  net: cadence_gem: Fix irq update w.r.t queue
  net: cadence_gem: Define access permission for interrupt registers
  net: cadence_gem: Set ISR according to queue in use
  net: cadence_gem: Add support for jumbo frames
  net: cadnece_gem: Update irq_read_clear field of designcfg_debug1 reg
  net: cadence_gem: Update the reset value for interrupt mask register
  net: cadence_gem: TX_LAST bit should be set by guest

Tong Ho (1):
  net: cadence_gem: Fix RX address filtering

 hw/net/cadence_gem.c | 167 +++++++++++++++++++++++++++++----------------------
 1 file changed, 94 insertions(+), 73 deletions(-)

Comments

Ramon Fried May 4, 2020, 3:50 p.m. UTC | #1
On Mon, May 4, 2020 at 5:14 PM Sai Pavan Boddu
<sai.pavan.boddu@xilinx.com> wrote:
>
> Hi,
>
> Following patch series fixes issues with priority queues,
> Adds JUMBO Frame support,
> Makes Debug statements compilable &
> Fixes related to multicast frames.
>
> Changes for V2:
>         Fixed build failure on fedora docker machine
>         Fix buggy debug print to use sized integer casting
>
> Sai Pavan Boddu (9):
>   net: cadence_gem: Fix debug statements
>   net: cadence_gem: Fix the queue address update during wrap around
>   net: cadence_gem: Fix irq update w.r.t queue
>   net: cadence_gem: Define access permission for interrupt registers
>   net: cadence_gem: Set ISR according to queue in use
>   net: cadence_gem: Add support for jumbo frames
>   net: cadnece_gem: Update irq_read_clear field of designcfg_debug1 reg
>   net: cadence_gem: Update the reset value for interrupt mask register
>   net: cadence_gem: TX_LAST bit should be set by guest
>
> Tong Ho (1):
>   net: cadence_gem: Fix RX address filtering
>
>  hw/net/cadence_gem.c | 167 +++++++++++++++++++++++++++++----------------------
>  1 file changed, 94 insertions(+), 73 deletions(-)
>
> --
> 2.7.4
>
Hey. did you test these with 64 descriptor addressing ?
I can test it for you if you need.
Thanks,
Ramon.
Sai Pavan Boddu May 4, 2020, 5:15 p.m. UTC | #2
Hi Ramon,

> -----Original Message-----
> From: Ramon Fried <rfried.dev@gmail.com>
> Sent: Monday, May 4, 2020 9:20 PM
> To: Sai Pavan Boddu <saipava@xilinx.com>
> Cc: Edgar E. Iglesias <edgar.iglesias@gmail.com>; Alistair Francis
> <Alistair.Francis@wdc.com>; Peter Maydell <peter.maydell@linaro.org>;
> Jason Wang <jasowang@redhat.com>; Markus Armbruster
> <armbru@redhat.com>; Philippe Mathieu-Daudé <philmd@redhat.com>;
> Tong Ho <tongh@xilinx.com>; open list:Xilinx Zynq <qemu-
> arm@nongnu.org>; QEMU Developers <qemu-devel@nongnu.org>
> Subject: Re: [PATCH v2 00/10] Cadence GEM Fixes
> 
> On Mon, May 4, 2020 at 5:14 PM Sai Pavan Boddu
> <sai.pavan.boddu@xilinx.com> wrote:
> >
> > Hi,
> >
> > Following patch series fixes issues with priority queues, Adds JUMBO
> > Frame support, Makes Debug statements compilable & Fixes related to
> > multicast frames.
> >
> > Changes for V2:
> >         Fixed build failure on fedora docker machine
> >         Fix buggy debug print to use sized integer casting
> >
> > Sai Pavan Boddu (9):
> >   net: cadence_gem: Fix debug statements
> >   net: cadence_gem: Fix the queue address update during wrap around
> >   net: cadence_gem: Fix irq update w.r.t queue
> >   net: cadence_gem: Define access permission for interrupt registers
> >   net: cadence_gem: Set ISR according to queue in use
> >   net: cadence_gem: Add support for jumbo frames
> >   net: cadnece_gem: Update irq_read_clear field of designcfg_debug1 reg
> >   net: cadence_gem: Update the reset value for interrupt mask register
> >   net: cadence_gem: TX_LAST bit should be set by guest
> >
> > Tong Ho (1):
> >   net: cadence_gem: Fix RX address filtering
> >
> >  hw/net/cadence_gem.c | 167
> > +++++++++++++++++++++++++++++----------------------
> >  1 file changed, 94 insertions(+), 73 deletions(-)
> >
> > --
> > 2.7.4
> >
> Hey. did you test these with 64 descriptor addressing ?
[Sai Pavan Boddu] Tested it with a BareMetal application.

> I can test it for you if you need.
[Sai Pavan Boddu] Yes, would be nice, if you can review.

Thanks,
Sai Pavan
> Thanks,
> Ramon.
no-reply@patchew.org May 5, 2020, 8:31 a.m. UTC | #3
Patchew URL: https://patchew.org/QEMU/1588601168-27576-1-git-send-email-sai.pavan.boddu@xilinx.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 1588601168-27576-1-git-send-email-sai.pavan.boddu@xilinx.com
Subject: [PATCH v2 00/10] Cadence GEM Fixes
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
fatal: unable to write new index file
Traceback (most recent call last):
  File "patchew-tester/src/patchew-cli", line 521, in test_one
    git_clone_repo(clone, r["repo"], r["head"], logf, True)
  File "patchew-tester/src/patchew-cli", line 57, in git_clone_repo
    cwd=clone)
  File "/opt/rh/rh-python36/root/usr/lib64/python3.6/subprocess.py", line 291, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['git', 'checkout', 'refs/tags/patchew/1588601168-27576-1-git-send-email-sai.pavan.boddu@xilinx.com', '-b', 'test']' returned non-zero exit status 128.



The full log is available at
http://patchew.org/logs/1588601168-27576-1-git-send-email-sai.pavan.boddu@xilinx.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com