| Message ID | 20200507150822.114464-4-emil.l.velikov@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: Fareless gem_free_object | expand |
On Thu, May 07, 2020 at 04:07:49PM +0100, Emil Velikov wrote: > From: Emil Velikov <emil.velikov@collabora.com> > > Signed-off-by: Emil Velikov <emil.velikov@collabora.com> > --- > i915 uses the _unlocked version of the grm_gem_object API. Yet makes an > extensive use of the struct_mutex. > > Did not check how exactly it all work though. Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > Documentation/gpu/todo.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > index 658b52f7ffc6..2ce52c5917f8 100644 > --- a/Documentation/gpu/todo.rst > +++ b/Documentation/gpu/todo.rst > @@ -157,8 +157,8 @@ private lock. The tricky part is the BO free functions, since those can't > reliably take that lock any more. Instead state needs to be protected with > suitable subordinate locks or some cleanup work pushed to a worker thread. For > performance-critical drivers it might also be better to go with a more > -fine-grained per-buffer object and per-context lockings scheme. Currently only the > -``msm`` driver still use ``struct_mutex``. > +fine-grained per-buffer object and per-context lockings scheme. Currently only > +the ``msm`` and `i915` drivers use ``struct_mutex``. > > Contact: Daniel Vetter, respective driver maintainers > > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>-----Original Message----- >From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of Emil >Velikov >Sent: Thursday, May 7, 2020 11:08 AM >To: dri-devel@lists.freedesktop.org >Cc: emil.l.velikov@gmail.com >Subject: [PATCH 03/36] drm/todo: mention i915 in the struct_mutex section > >From: Emil Velikov <emil.velikov@collabora.com> > >Signed-off-by: Emil Velikov <emil.velikov@collabora.com> >--- >i915 uses the _unlocked version of the grm_gem_object API. Yet makes an >extensive use of the struct_mutex. s/grm_/drm_/ ? M > >Did not check how exactly it all work though. >--- > Documentation/gpu/todo.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst >index 658b52f7ffc6..2ce52c5917f8 100644 >--- a/Documentation/gpu/todo.rst >+++ b/Documentation/gpu/todo.rst >@@ -157,8 +157,8 @@ private lock. The tricky part is the BO free functions, >since those can't > reliably take that lock any more. Instead state needs to be protected with > suitable subordinate locks or some cleanup work pushed to a worker thread. >For > performance-critical drivers it might also be better to go with a more >-fine-grained per-buffer object and per-context lockings scheme. Currently >only the >-``msm`` driver still use ``struct_mutex``. >+fine-grained per-buffer object and per-context lockings scheme. Currently >only >+the ``msm`` and `i915` drivers use ``struct_mutex``. > > Contact: Daniel Vetter, respective driver maintainers > >-- >2.25.1 > >_______________________________________________ >dri-devel mailing list >dri-devel@lists.freedesktop.org >https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 658b52f7ffc6..2ce52c5917f8 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -157,8 +157,8 @@ private lock. The tricky part is the BO free functions, since those can't reliably take that lock any more. Instead state needs to be protected with suitable subordinate locks or some cleanup work pushed to a worker thread. For performance-critical drivers it might also be better to go with a more -fine-grained per-buffer object and per-context lockings scheme. Currently only the -``msm`` driver still use ``struct_mutex``. +fine-grained per-buffer object and per-context lockings scheme. Currently only +the ``msm`` and `i915` drivers use ``struct_mutex``. Contact: Daniel Vetter, respective driver maintainers