diff mbox series

USB: EHCI: ehci-mv: Fix unused assignment in mv_ehci_probe()

Message ID 20200508114409.12704-1-tangbin@cmss.chinamobile.com (mailing list archive)
State Superseded
Headers show
Series USB: EHCI: ehci-mv: Fix unused assignment in mv_ehci_probe() | expand

Commit Message

Tang Bin May 8, 2020, 11:44 a.m. UTC 
Delete unused initialized value, because 'retval' will be assigined
by the function mv_ehci_enable().

Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
 drivers/usb/host/ehci-mv.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Alan Stern May 8, 2020, 1:49 p.m. UTC | #1 
On Fri, 8 May 2020, Tang Bin wrote:

> Delete unused initialized value, because 'retval' will be assigined
> by the function mv_ehci_enable().

This should also mention the extra blank line that the patch removes.

Alan Stern

> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
>  drivers/usb/host/ehci-mv.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c
> index bd4f6ef53..1c079953e 100644
> --- a/drivers/usb/host/ehci-mv.c
> +++ b/drivers/usb/host/ehci-mv.c
> @@ -108,7 +108,7 @@ static int mv_ehci_probe(struct platform_device *pdev)
>  	struct ehci_hcd *ehci;
>  	struct ehci_hcd_mv *ehci_mv;
>  	struct resource *r;
> -	int retval = -ENODEV;
> +	int retval;
>  	u32 offset;
>  
>  	if (usb_disabled())
> @@ -142,8 +142,6 @@ static int mv_ehci_probe(struct platform_device *pdev)
>  		goto err_put_hcd;
>  	}
>  
> -
> -
>  	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	ehci_mv->base = devm_ioremap_resource(&pdev->dev, r);
>  	if (IS_ERR(ehci_mv->base)) {
>
Tang Bin May 8, 2020, 2:04 p.m. UTC | #2 
On 2020/5/8 21:49, Alan Stern wrote:
> On Fri, 8 May 2020, Tang Bin wrote:
>
>> Delete unused initialized value, because 'retval' will be assigined
>> by the function mv_ehci_enable().
> This should also mention the extra blank line that the patch removes.

Sorry, my mistake, I'll send v2 for you.

Thanks,

Tang Bin

>
diff mbox series

Patch

diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c
index bd4f6ef53..1c079953e 100644
--- a/drivers/usb/host/ehci-mv.c
+++ b/drivers/usb/host/ehci-mv.c
@@ -108,7 +108,7 @@  static int mv_ehci_probe(struct platform_device *pdev)
 	struct ehci_hcd *ehci;
 	struct ehci_hcd_mv *ehci_mv;
 	struct resource *r;
-	int retval = -ENODEV;
+	int retval;
 	u32 offset;
 
 	if (usb_disabled())
@@ -142,8 +142,6 @@  static int mv_ehci_probe(struct platform_device *pdev)
 		goto err_put_hcd;
 	}
 
-
-
 	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	ehci_mv->base = devm_ioremap_resource(&pdev->dev, r);
 	if (IS_ERR(ehci_mv->base)) {