| Message ID | 1588909928-58230-1-git-send-email-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [net-next] ieee802154: 6lowpan: remove unnecessary comparison | expand |
Hello. On 08.05.20 05:52, Yang Yingliang wrote: > The type of dispatch is u8 which is always '<=' 0xff, so the > dispatch <= 0xff is always true, we can remove this comparison. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > net/ieee802154/6lowpan/rx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ieee802154/6lowpan/rx.c b/net/ieee802154/6lowpan/rx.c > index ee17938..b34d050 100644 > --- a/net/ieee802154/6lowpan/rx.c > +++ b/net/ieee802154/6lowpan/rx.c > @@ -240,7 +240,7 @@ static inline bool lowpan_is_reserved(u8 dispatch) > return ((dispatch >= 0x44 && dispatch <= 0x4F) || > (dispatch >= 0x51 && dispatch <= 0x5F) || > (dispatch >= 0xc8 && dispatch <= 0xdf) || > - (dispatch >= 0xe8 && dispatch <= 0xff)); > + dispatch >= 0xe8); > } > > /* lowpan_rx_h_check checks on generic 6LoWPAN requirements > This looks good to me. Thanks for fixing this. Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org> Dave, can you apply this directly to your net tree? I have no other ieee802154 fixes pending to fill a pull request. regards Stefan Schmidt
On Fri, 8 May 2020 17:09:43 +0200 Stefan Schmidt wrote: >On 08.05.20 05:52, Yang Yingliang wrote: > > The type of dispatch is u8 which is always '<=' 0xff, so the > > dispatch <= 0xff is always true, we can remove this comparison. > > > > Reported-by: Hulk Robot <hulkci@huawei.com> > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > > This looks good to me. Thanks for fixing this. > > Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org> > > Dave, can you apply this directly to your net tree? I have no other > ieee802154 fixes pending to fill a pull request. I'm sitting in for Dave today, applied to net-next, thank you!
diff --git a/net/ieee802154/6lowpan/rx.c b/net/ieee802154/6lowpan/rx.c index ee17938..b34d050 100644 --- a/net/ieee802154/6lowpan/rx.c +++ b/net/ieee802154/6lowpan/rx.c @@ -240,7 +240,7 @@ static inline bool lowpan_is_reserved(u8 dispatch) return ((dispatch >= 0x44 && dispatch <= 0x4F) || (dispatch >= 0x51 && dispatch <= 0x5F) || (dispatch >= 0xc8 && dispatch <= 0xdf) || - (dispatch >= 0xe8 && dispatch <= 0xff)); + dispatch >= 0xe8); } /* lowpan_rx_h_check checks on generic 6LoWPAN requirements
The type of dispatch is u8 which is always '<=' 0xff, so the dispatch <= 0xff is always true, we can remove this comparison. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- net/ieee802154/6lowpan/rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)