| Message ID | 20200508104922.72565-3-vaibhav@linux.ibm.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | powerpc/papr_scm: Add support for reporting nvdimm health | expand |
On Fri, May 08, 2020 at 04:19:19PM +0530, Vaibhav Jain wrote: > 'seq_buf' provides a very useful abstraction for writing to a string > buffer without needing to worry about it over-flowing. However even > though the API has been stable for couple of years now its stills not > exported to external modules limiting its usage. > > Hence this patch proposes update to 'seq_buf.c' to mark > seq_buf_printf() which is part of the seq_buf API to be exported to > external GPL modules. This symbol will be used in later parts of this What is "external GPL modules"?
Hi Boris, Borislav Petkov <bp@alien8.de> writes: > On Fri, May 08, 2020 at 04:19:19PM +0530, Vaibhav Jain wrote: >> 'seq_buf' provides a very useful abstraction for writing to a string >> buffer without needing to worry about it over-flowing. However even >> though the API has been stable for couple of years now its stills not >> exported to external modules limiting its usage. >> >> Hence this patch proposes update to 'seq_buf.c' to mark >> seq_buf_printf() which is part of the seq_buf API to be exported to >> external GPL modules. This symbol will be used in later parts of this > > What is "external GPL modules"? I am referring to Kernel Loadable Modules with MODULE_LICENSE("GPL") here. > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette > _______________________________________________ > Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org > To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
Borislav Petkov <bp@alien8.de> writes: > On Fri, May 08, 2020 at 04:19:19PM +0530, Vaibhav Jain wrote: >> 'seq_buf' provides a very useful abstraction for writing to a string >> buffer without needing to worry about it over-flowing. However even >> though the API has been stable for couple of years now its stills not >> exported to external modules limiting its usage. >> >> Hence this patch proposes update to 'seq_buf.c' to mark >> seq_buf_printf() which is part of the seq_buf API to be exported to >> external GPL modules. This symbol will be used in later parts of this > > What is "external GPL modules"? A module that has MODULE_LICENSE("GPL") ? cheers
On Fri, 2020-05-08 at 17:30 +0530, Vaibhav Jain wrote: > Hi Boris, > > Borislav Petkov <bp@alien8.de> writes: > > > On Fri, May 08, 2020 at 04:19:19PM +0530, Vaibhav Jain wrote: > > > 'seq_buf' provides a very useful abstraction for writing to a string > > > buffer without needing to worry about it over-flowing. However even > > > though the API has been stable for couple of years now its stills not > > > exported to external modules limiting its usage. > > > > > > Hence this patch proposes update to 'seq_buf.c' to mark > > > seq_buf_printf() which is part of the seq_buf API to be exported to > > > external GPL modules. This symbol will be used in later parts of this > > > > What is "external GPL modules"? > I am referring to Kernel Loadable Modules with MODULE_LICENSE("GPL") > here. Any reason why these Kernel Loadable Modules with MODULE_LICENSE("GPL") are not in the kernel tree?
On Fri, May 08, 2020 at 05:30:31PM +0530, Vaibhav Jain wrote: > I am referring to Kernel Loadable Modules with MODULE_LICENSE("GPL") > here. And what does "external" refer to? Because if it is out-of-tree, we don't export symbols for out-of-tree modules. Looks like you're exporting it for that papr_scm.c thing, which is fine. But that is not "external". So?
On Fri, 8 May 2020 18:09:35 +0200 Borislav Petkov <bp@alien8.de> wrote: > On Fri, May 08, 2020 at 05:30:31PM +0530, Vaibhav Jain wrote: > > I am referring to Kernel Loadable Modules with MODULE_LICENSE("GPL") > > here. > > And what does "external" refer to? Because if it is out-of-tree, we > don't export symbols for out-of-tree modules. I've always wondered about this. Why not? -- Steve
Hi Joe, Joe Perches <joe@perches.com> writes: > On Fri, 2020-05-08 at 17:30 +0530, Vaibhav Jain wrote: >> Hi Boris, >> >> Borislav Petkov <bp@alien8.de> writes: >> >> > On Fri, May 08, 2020 at 04:19:19PM +0530, Vaibhav Jain wrote: >> > > 'seq_buf' provides a very useful abstraction for writing to a string >> > > buffer without needing to worry about it over-flowing. However even >> > > though the API has been stable for couple of years now its stills not >> > > exported to external modules limiting its usage. >> > > >> > > Hence this patch proposes update to 'seq_buf.c' to mark >> > > seq_buf_printf() which is part of the seq_buf API to be exported to >> > > external GPL modules. This symbol will be used in later parts of this >> > >> > What is "external GPL modules"? >> I am referring to Kernel Loadable Modules with MODULE_LICENSE("GPL") >> here. > > Any reason why these Kernel Loadable Modules with MODULE_LICENSE("GPL") > are not in the kernel tree? The Kernel GPL module that this patch reffers to is 'papr_scm' which is already in kernel tree at arch/powerpc/platforms/pseries/papr_scm.c . ~ Vaibhav
Hi Boris, Borislav Petkov <bp@alien8.de> writes: > On Fri, May 08, 2020 at 05:30:31PM +0530, Vaibhav Jain wrote: >> I am referring to Kernel Loadable Modules with MODULE_LICENSE("GPL") >> here. > > And what does "external" refer to? Because if it is out-of-tree, we > don't export symbols for out-of-tree modules. > > Looks like you're exporting it for that papr_scm.c thing, which is fine. > But that is not "external". > > So? I should have used the term 'non-builtin' or 'kernel loadable' modules rather than external modules in this patch description. Apologies for the confusion it caused. ~ Vaibhav > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette > _______________________________________________ > Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org > To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
Michael Ellerman <mpe@ellerman.id.au> writes: > Borislav Petkov <bp@alien8.de> writes: >> On Fri, May 08, 2020 at 04:19:19PM +0530, Vaibhav Jain wrote: >>> 'seq_buf' provides a very useful abstraction for writing to a string >>> buffer without needing to worry about it over-flowing. However even >>> though the API has been stable for couple of years now its stills not >>> exported to external modules limiting its usage. >>> >>> Hence this patch proposes update to 'seq_buf.c' to mark >>> seq_buf_printf() which is part of the seq_buf API to be exported to >>> external GPL modules. This symbol will be used in later parts of this >> >> What is "external GPL modules"? > > A module that has MODULE_LICENSE("GPL") ? Yes, by "external GPL modules" I meant Kernel lodable modules with licensed as "GPL" ~ Vaibhav > > cheers
diff --git a/lib/seq_buf.c b/lib/seq_buf.c index 4e865d42ab03..707453f5d58e 100644 --- a/lib/seq_buf.c +++ b/lib/seq_buf.c @@ -91,6 +91,7 @@ int seq_buf_printf(struct seq_buf *s, const char *fmt, ...) return ret; } +EXPORT_SYMBOL_GPL(seq_buf_printf); #ifdef CONFIG_BINARY_PRINTF /**
'seq_buf' provides a very useful abstraction for writing to a string buffer without needing to worry about it over-flowing. However even though the API has been stable for couple of years now its stills not exported to external modules limiting its usage. Hence this patch proposes update to 'seq_buf.c' to mark seq_buf_printf() which is part of the seq_buf API to be exported to external GPL modules. This symbol will be used in later parts of this patchset to simplify content creation for a sysfs attribute. Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Piotr Maziarz <piotrx.maziarz@linux.intel.com> Cc: Cezary Rojewski <cezary.rojewski@intel.com> Cc: Borislav Petkov <bp@alien8.de> Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com> --- Changelog: v6..v7: * New patch in the series --- lib/seq_buf.c | 1 + 1 file changed, 1 insertion(+)