| Message ID | 20200510105807.880-3-Sergey.Semin@baikalelectronics.ru (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v2,1/7] dt-bindings: watchdog: Convert DW WDT binding to DT schema | expand |
Hello! On 10.05.2020 13:58, Serge Semin wrote: > DW Watchdog IP core can be synthesised with asynchronous timer/APB > clocks support (WDT_ASYNC_CLK_MODE_ENABLE == 1). In this case > a separate clock signal is supposed to be used to feed watchdog timer > and APB interface of the device. Lets along with the watchdog timer ^ verb missing? or comma? > reference clock expect to have the optional APB3 bu interface clock > sepcified in a DW WDT dt node. Specified. > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru> > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > Cc: Paul Burton <paulburton@kernel.org> > Cc: Ralf Baechle <ralf@linux-mips.org> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Cc: linux-mips@vger.kernel.org [...] MBR, Sergei
On 11.05.2020 11:25, Sergei Shtylyov wrote: >> DW Watchdog IP core can be synthesised with asynchronous timer/APB >> clocks support (WDT_ASYNC_CLK_MODE_ENABLE == 1). In this case >> a separate clock signal is supposed to be used to feed watchdog timer >> and APB interface of the device. Lets along with the watchdog timer > ^ verb missing? or comma? Oh, and probably "Let's" too. :-) > >> reference clock expect to have the optional APB3 bu interface clock >> sepcified in a DW WDT dt node. > > Specified. > >> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> >> Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru> >> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> >> Cc: Paul Burton <paulburton@kernel.org> >> Cc: Ralf Baechle <ralf@linux-mips.org> >> Cc: Arnd Bergmann <arnd@arndb.de> >> Cc: Philipp Zabel <p.zabel@pengutronix.de> >> Cc: linux-mips@vger.kernel.org > [...] MBR, Sergei
Hello Sergei On Mon, May 11, 2020 at 11:28:00AM +0300, Sergei Shtylyov wrote: > On 11.05.2020 11:25, Sergei Shtylyov wrote: > > > > DW Watchdog IP core can be synthesised with asynchronous timer/APB > > > clocks support (WDT_ASYNC_CLK_MODE_ENABLE == 1). In this case > > > a separate clock signal is supposed to be used to feed watchdog timer > > > and APB interface of the device. Lets along with the watchdog timer > > ^ verb missing? or comma? > > Oh, and probably "Let's" too. :-) > > > > > > reference clock expect to have the optional APB3 bu interface clock > > > sepcified in a DW WDT dt node. > > > > Specified. Thanks for noticing this. I'll just change the sentence to: "Let's update the DW Watchdog DT node schema so it would support the optional APB3 bus clock specified along with the mandatory watchdog timer reference clock." -Sergey > > > > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > > Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru> > > > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > > > Cc: Paul Burton <paulburton@kernel.org> > > > Cc: Ralf Baechle <ralf@linux-mips.org> > > > Cc: Arnd Bergmann <arnd@arndb.de> > > > Cc: Philipp Zabel <p.zabel@pengutronix.de> > > > Cc: linux-mips@vger.kernel.org > > [...] > > MBR, Sergei
On Sun, 10 May 2020 13:58:02 +0300, Serge Semin wrote: > DW Watchdog IP core can be synthesised with asynchronous timer/APB > clocks support (WDT_ASYNC_CLK_MODE_ENABLE == 1). In this case > a separate clock signal is supposed to be used to feed watchdog timer > and APB interface of the device. Lets along with the watchdog timer > reference clock expect to have the optional APB3 bus interface clock > sepcified in a DW WDT dt node. > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru> > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > Cc: Paul Burton <paulburton@kernel.org> > Cc: Ralf Baechle <ralf@linux-mips.org> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Cc: linux-mips@vger.kernel.org > > --- > > Changelog v2: > - It's a new patch unpinned from the previous one. > --- > .../devicetree/bindings/watchdog/snps,dw-wdt.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml index 4f6944756ab4..5bf6dc6377f3 100644 --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml @@ -24,8 +24,16 @@ properties: maxItems: 1 clocks: + minItems: 1 items: - description: Watchdog timer reference clock + - description: APB3 interface clock + + clock-names: + minItems: 1 + items: + - const: tclk + - const: pclk resets: description: Phandle to the DW Watchdog reset lane
DW Watchdog IP core can be synthesised with asynchronous timer/APB clocks support (WDT_ASYNC_CLK_MODE_ENABLE == 1). In this case a separate clock signal is supposed to be used to feed watchdog timer and APB interface of the device. Lets along with the watchdog timer reference clock expect to have the optional APB3 bus interface clock sepcified in a DW WDT dt node. Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Cc: Paul Burton <paulburton@kernel.org> Cc: Ralf Baechle <ralf@linux-mips.org> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Philipp Zabel <p.zabel@pengutronix.de> Cc: linux-mips@vger.kernel.org --- Changelog v2: - It's a new patch unpinned from the previous one. --- .../devicetree/bindings/watchdog/snps,dw-wdt.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)