| Message ID | 20200511110611.3142-4-ricardo.canuelo@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Convert adi,adv7511.txt DT bindings to yaml | expand |
(Adding Michal) On Mon, 2020-05-11 at 13:06 +0200, Ricardo Cañuelo wrote: > Define a 'ports' node for 'adv7511: hdmi-tx@39' to make it compliant with > the adi,adv7511 DT binding. > > This fills the minimum requirements to meet the binding requirements, > remote endpoints are not defined. > > Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com> > --- > arch/arm/boot/dts/zynq-zc702.dts | 10 ++++++++++ > arch/arm/boot/dts/zynq-zc706.dts | 10 ++++++++++ > 2 files changed, 20 insertions(+) > > diff --git a/arch/arm/boot/dts/zynq-zc702.dts b/arch/arm/boot/dts/zynq-zc702.dts > index 27cd6cb52f1b..79fd236edded 100644 > --- a/arch/arm/boot/dts/zynq-zc702.dts > +++ b/arch/arm/boot/dts/zynq-zc702.dts > @@ -135,6 +135,16 @@ > adi,input-clock = "1x"; > adi,input-style = <3>; > adi,input-justification = "right"; > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + }; > + port@1 { > + reg = <1>; > + }; > + }; > }; > }; > > diff --git a/arch/arm/boot/dts/zynq-zc706.dts b/arch/arm/boot/dts/zynq-zc706.dts > index 77943c16d33f..99fa51ba6e93 100644 > --- a/arch/arm/boot/dts/zynq-zc706.dts > +++ b/arch/arm/boot/dts/zynq-zc706.dts > @@ -93,6 +93,16 @@ > adi,input-clock = "1x"; > adi,input-style = <3>; > adi,input-justification = "evenly"; > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + }; > + port@1 { > + reg = <1>; > + }; > + }; > }; > }; > > -- > 2.18.0 > >
On 11. 05. 20 14:24, Ezequiel Garcia wrote: > (Adding Michal) > > On Mon, 2020-05-11 at 13:06 +0200, Ricardo Cañuelo wrote: >> Define a 'ports' node for 'adv7511: hdmi-tx@39' to make it compliant with >> the adi,adv7511 DT binding. >> >> This fills the minimum requirements to meet the binding requirements, >> remote endpoints are not defined. >> >> Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com> >> --- >> arch/arm/boot/dts/zynq-zc702.dts | 10 ++++++++++ >> arch/arm/boot/dts/zynq-zc706.dts | 10 ++++++++++ >> 2 files changed, 20 insertions(+) >> >> diff --git a/arch/arm/boot/dts/zynq-zc702.dts b/arch/arm/boot/dts/zynq-zc702.dts >> index 27cd6cb52f1b..79fd236edded 100644 >> --- a/arch/arm/boot/dts/zynq-zc702.dts >> +++ b/arch/arm/boot/dts/zynq-zc702.dts >> @@ -135,6 +135,16 @@ >> adi,input-clock = "1x"; >> adi,input-style = <3>; >> adi,input-justification = "right"; >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + port@0 { >> + reg = <0>; >> + }; >> + port@1 { >> + reg = <1>; >> + }; >> + }; >> }; >> }; >> >> diff --git a/arch/arm/boot/dts/zynq-zc706.dts b/arch/arm/boot/dts/zynq-zc706.dts >> index 77943c16d33f..99fa51ba6e93 100644 >> --- a/arch/arm/boot/dts/zynq-zc706.dts >> +++ b/arch/arm/boot/dts/zynq-zc706.dts >> @@ -93,6 +93,16 @@ >> adi,input-clock = "1x"; >> adi,input-style = <3>; >> adi,input-justification = "evenly"; >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + port@0 { >> + reg = <0>; >> + }; >> + port@1 { >> + reg = <1>; >> + }; >> + }; >> }; >> }; >> >> -- >> 2.18.0 >> >> > > Just c&p Laurent's reply to Ricardo about it. "Completing the board definition is best I believe. Sometimes the endpoint is related to an add-on board that isn't described as part of the base DTS. The ports are required as they describe hardware interfaces, but having no endpoint in a port shouldn't be a problem, it just means the port is not connected." I am ok with it too that's why Acked-by: Michal Simek <michal.simek@xilinx.com> Thanks, Michalt
Hello, On Mon, May 11, 2020 at 02:52:50PM +0200, Michal Simek wrote: > On 11. 05. 20 14:24, Ezequiel Garcia wrote: > > (Adding Michal) > > > > On Mon, 2020-05-11 at 13:06 +0200, Ricardo Cañuelo wrote: > >> Define a 'ports' node for 'adv7511: hdmi-tx@39' to make it compliant with > >> the adi,adv7511 DT binding. > >> > >> This fills the minimum requirements to meet the binding requirements, > >> remote endpoints are not defined. > >> > >> Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com> > >> --- > >> arch/arm/boot/dts/zynq-zc702.dts | 10 ++++++++++ > >> arch/arm/boot/dts/zynq-zc706.dts | 10 ++++++++++ > >> 2 files changed, 20 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/zynq-zc702.dts b/arch/arm/boot/dts/zynq-zc702.dts > >> index 27cd6cb52f1b..79fd236edded 100644 > >> --- a/arch/arm/boot/dts/zynq-zc702.dts > >> +++ b/arch/arm/boot/dts/zynq-zc702.dts > >> @@ -135,6 +135,16 @@ > >> adi,input-clock = "1x"; > >> adi,input-style = <3>; > >> adi,input-justification = "right"; > >> + ports { > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + port@0 { > >> + reg = <0>; > >> + }; > >> + port@1 { > >> + reg = <1>; > >> + }; > >> + }; > >> }; > >> }; > >> > >> diff --git a/arch/arm/boot/dts/zynq-zc706.dts b/arch/arm/boot/dts/zynq-zc706.dts > >> index 77943c16d33f..99fa51ba6e93 100644 > >> --- a/arch/arm/boot/dts/zynq-zc706.dts > >> +++ b/arch/arm/boot/dts/zynq-zc706.dts > >> @@ -93,6 +93,16 @@ > >> adi,input-clock = "1x"; > >> adi,input-style = <3>; > >> adi,input-justification = "evenly"; > >> + ports { > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + port@0 { > >> + reg = <0>; > >> + }; > >> + port@1 { > >> + reg = <1>; > >> + }; > >> + }; > >> }; > >> }; > >> > > Just c&p Laurent's reply to Ricardo about it. > > "Completing the board definition is best I believe. Sometimes the > endpoint is related to an add-on board that isn't described as part of > the base DTS. The ports are required as they describe hardware > interfaces, but having no endpoint in a port shouldn't be a problem, it > just means the port is not connected." > > I am ok with it too that's why > > Acked-by: Michal Simek <michal.simek@xilinx.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
diff --git a/arch/arm/boot/dts/zynq-zc702.dts b/arch/arm/boot/dts/zynq-zc702.dts index 27cd6cb52f1b..79fd236edded 100644 --- a/arch/arm/boot/dts/zynq-zc702.dts +++ b/arch/arm/boot/dts/zynq-zc702.dts @@ -135,6 +135,16 @@ adi,input-clock = "1x"; adi,input-style = <3>; adi,input-justification = "right"; + ports { + #address-cells = <1>; + #size-cells = <0>; + port@0 { + reg = <0>; + }; + port@1 { + reg = <1>; + }; + }; }; }; diff --git a/arch/arm/boot/dts/zynq-zc706.dts b/arch/arm/boot/dts/zynq-zc706.dts index 77943c16d33f..99fa51ba6e93 100644 --- a/arch/arm/boot/dts/zynq-zc706.dts +++ b/arch/arm/boot/dts/zynq-zc706.dts @@ -93,6 +93,16 @@ adi,input-clock = "1x"; adi,input-style = <3>; adi,input-justification = "evenly"; + ports { + #address-cells = <1>; + #size-cells = <0>; + port@0 { + reg = <0>; + }; + port@1 { + reg = <1>; + }; + }; }; };
Define a 'ports' node for 'adv7511: hdmi-tx@39' to make it compliant with the adi,adv7511 DT binding. This fills the minimum requirements to meet the binding requirements, remote endpoints are not defined. Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com> --- arch/arm/boot/dts/zynq-zc702.dts | 10 ++++++++++ arch/arm/boot/dts/zynq-zc706.dts | 10 ++++++++++ 2 files changed, 20 insertions(+)