mbox series

[0/5] megaraid_sas: driver updates for 07.714.04.00-rc1

Message ID 20200508083838.22778-1-chandrakanth.patil@broadcom.com (mailing list archive)
Headers show
Series megaraid_sas: driver updates for 07.714.04.00-rc1 | expand

Message

Chandrakanth Patil May 8, 2020, 8:38 a.m. UTC
This patchset contains few critical driver fixes.

Chandrakanth Patil (5):
  megaraid_sas: Limit device qd to controller qd when device qd is
    greater than controller qd
  megaraid_sas: Remove IO buffer hole detection logic
  megaraid_sas: Replace undefined MFI_BIG_ENDIAN macro with
    __BIG_ENDIAN_BITFIELD macro
  megaraid_sas: TM command refire leads to controller firmware crash
  megaraid_sas: Update driver version to 07.714.04.00-rc1

 drivers/scsi/megaraid/megaraid_sas.h        |  8 ++--
 drivers/scsi/megaraid/megaraid_sas_base.c   |  5 +--
 drivers/scsi/megaraid/megaraid_sas_fusion.c | 65 +++--------------------------
 drivers/scsi/megaraid/megaraid_sas_fusion.h |  6 +--
 4 files changed, 15 insertions(+), 69 deletions(-)

Comments

Martin K. Petersen May 12, 2020, 3:48 a.m. UTC | #1
Hi Chandrakanth!

> This patchset contains few critical driver fixes.
>
> Chandrakanth Patil (5):
>   megaraid_sas: Limit device qd to controller qd when device qd is
>     greater than controller qd
>   megaraid_sas: Remove IO buffer hole detection logic
>   megaraid_sas: Replace undefined MFI_BIG_ENDIAN macro with
>     __BIG_ENDIAN_BITFIELD macro
>   megaraid_sas: TM command refire leads to controller firmware crash
>   megaraid_sas: Update driver version to 07.714.04.00-rc1

The threading was messed up in this series and both patchwork and b4
failed to grok it as a single patch set. It looks like your mail system
somehow broke it up into multiple submissions, each with their own
threading and cover letter.

Also, several patches had incorrect attribution. If a patch was not
authored by you it needs to have a From: identifying the original author
(Sumit, Kashyap, etc.) as identified in the first Signed-off-by: tag.

I fixed things up and applied to 5.8/scsi-queue. But please look into
what went wrong when mailing this series. While I can edit my way out of
incorrectly threaded submissions, the build robots and code checkers can
get stumped when something is broken up. And therefore there is a chance
that the patches didn't get full build and code analysis coverage.

Thanks!
Chandrakanth Patil May 13, 2020, 9:38 p.m. UTC | #2
Hi Martin,

Sorry for the inconvenience. I will make sure this doesn't happen again.

-Chandrakanth Patil

-----Original Message-----
From: Martin K. Petersen [mailto:martin.petersen@oracle.com]
Sent: Tuesday, May 12, 2020 9:19 AM
To: Chandrakanth Patil <chandrakanth.patil@broadcom.com>
Cc: linux-scsi@vger.kernel.org; kashyap.desai@broadcom.com;
sumit.saxena@broadcom.com; kiran-kumar.kasturi@broadcom.com;
sankar.patra@broadcom.com; sasikumar.pc@broadcom.com;
shivasharan.srikanteshwara@broadcom.com; anand.lodnoor@broadcom.com
Subject: Re: [PATCH 0/5] megaraid_sas: driver updates for 07.714.04.00-rc1


Hi Chandrakanth!

> This patchset contains few critical driver fixes.
>
> Chandrakanth Patil (5):
>   megaraid_sas: Limit device qd to controller qd when device qd is
>     greater than controller qd
>   megaraid_sas: Remove IO buffer hole detection logic
>   megaraid_sas: Replace undefined MFI_BIG_ENDIAN macro with
>     __BIG_ENDIAN_BITFIELD macro
>   megaraid_sas: TM command refire leads to controller firmware crash
>   megaraid_sas: Update driver version to 07.714.04.00-rc1

The threading was messed up in this series and both patchwork and b4
failed to grok it as a single patch set. It looks like your mail system
somehow broke it up into multiple submissions, each with their own
threading and cover letter.

Also, several patches had incorrect attribution. If a patch was not
authored by you it needs to have a From: identifying the original author
(Sumit, Kashyap, etc.) as identified in the first Signed-off-by: tag.

I fixed things up and applied to 5.8/scsi-queue. But please look into what
went wrong when mailing this series. While I can edit my way out of
incorrectly threaded submissions, the build robots and code checkers can
get stumped when something is broken up. And therefore there is a chance
that the patches didn't get full build and code analysis coverage.

Thanks!