| Message ID | 20200512123149.40162-1-bernard@vivo.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v3] memory/samsung: reduce protected code area in IRQ | expand |
On 5/12/20 1:31 PM, Bernard Zhao wrote: > This change will speed-up a bit this IRQ processing and there > is no need to protect return value or printing. > > Signed-off-by: Bernard Zhao <bernard@vivo.com> LGTM Acked-by: Lukasz Luba <lukasz.luba@arm.com> > --- > Changes since v1: > *change release lock before the if statement. > *revert dmc->df->lock mutex lock to protect function > exynos5_dmc_perf_events_check > > Changes since v2: > *Improve subject and commit message > > Link for V1: > *https://lore.kernel.org/patchwork/patch/1238888/ > --- > drivers/memory/samsung/exynos5422-dmc.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c > index 22a43d662833..25196d6268e2 100644 > --- a/drivers/memory/samsung/exynos5422-dmc.c > +++ b/drivers/memory/samsung/exynos5422-dmc.c > @@ -1346,15 +1346,13 @@ static irqreturn_t dmc_irq_thread(int irq, void *priv) > struct exynos5_dmc *dmc = priv; > > mutex_lock(&dmc->df->lock); > - > exynos5_dmc_perf_events_check(dmc); > - > res = update_devfreq(dmc->df); > + mutex_unlock(&dmc->df->lock); > + > if (res) > dev_warn(dmc->dev, "devfreq failed with %d\n", res); > > - mutex_unlock(&dmc->df->lock); > - > return IRQ_HANDLED; > } > >
On Tue, May 12, 2020 at 05:31:49AM -0700, Bernard Zhao wrote: > This change will speed-up a bit this IRQ processing and there > is no need to protect return value or printing. > > Signed-off-by: Bernard Zhao <bernard@vivo.com> > --- > Changes since v1: > *change release lock before the if statement. > *revert dmc->df->lock mutex lock to protect function > exynos5_dmc_perf_events_check > > Changes since v2: > *Improve subject and commit message > > Link for V1: > *https://lore.kernel.org/patchwork/patch/1238888/ > --- > drivers/memory/samsung/exynos5422-dmc.c | 6 ++---- Thanks, applied. Best regards, Krzysztof
diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c index 22a43d662833..25196d6268e2 100644 --- a/drivers/memory/samsung/exynos5422-dmc.c +++ b/drivers/memory/samsung/exynos5422-dmc.c @@ -1346,15 +1346,13 @@ static irqreturn_t dmc_irq_thread(int irq, void *priv) struct exynos5_dmc *dmc = priv; mutex_lock(&dmc->df->lock); - exynos5_dmc_perf_events_check(dmc); - res = update_devfreq(dmc->df); + mutex_unlock(&dmc->df->lock); + if (res) dev_warn(dmc->dev, "devfreq failed with %d\n", res); - mutex_unlock(&dmc->df->lock); - return IRQ_HANDLED; }
This change will speed-up a bit this IRQ processing and there is no need to protect return value or printing. Signed-off-by: Bernard Zhao <bernard@vivo.com> --- Changes since v1: *change release lock before the if statement. *revert dmc->df->lock mutex lock to protect function exynos5_dmc_perf_events_check Changes since v2: *Improve subject and commit message Link for V1: *https://lore.kernel.org/patchwork/patch/1238888/ --- drivers/memory/samsung/exynos5422-dmc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)