| Message ID | 20200512085554.26366-1-johannes.thumshirn@wdc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Introduce Zone Append for writing to zoned block devices | expand |
The whole series looks good to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
I hope we can get this in 5.8 to help with the btrfs in 5.9.
Christoph, > The whole series looks good to me: > > Reviewed-by: Christoph Hellwig <hch@lst.de> > > I hope we can get this in 5.8 to help with the btrfs in 5.9. Yep, I think this looks good. I suspect this series going to clash with my sd revalidate surgery. I may have to stick that in a postmerge branch based on Jens' tree.
On Tue, May 12, 2020 at 09:01:18AM -0700, Martin K. Petersen wrote: > I suspect this series going to clash with my sd revalidate surgery. I > may have to stick that in a postmerge branch based on Jens' tree. Where is that series? I don't remember any changes in that area. > > -- > Martin K. Petersen Oracle Linux Engineering ---end quoted text---
Christoph,
> Where is that series? I don't remember any changes in that area.
Haven't posted it yet. Still working on a few patches that address
validating reported values for devices that change parameters in flight.
The first part of the series is here:
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/linux.git/log/?h=5.8/sd-revalidate
On 12/05/2020 18:15, Martin K. Petersen wrote: > > Christoph, > >> Where is that series? I don't remember any changes in that area. > > Haven't posted it yet. Still working on a few patches that address > validating reported values for devices that change parameters in flight. > > The first part of the series is here: > > https://git.kernel.org/pub/scm/linux/kernel/git/mkp/linux.git/log/?h=5.8/sd-revalidate > Just did a quick skim in the gitweb and I can't see anything that will clash. So I think we're good.
Johannes, > Just did a quick skim in the gitweb and I can't see anything that will > clash. So I think we're good. The most intrusive pieces are impending. But no worries! Staging the merge is my problem. Your series is good to go as far as I'm concerned.
On 5/12/20 2:55 AM, Johannes Thumshirn wrote: > The upcoming NVMe ZNS Specification will define a new type of write > command for zoned block devices, zone append. > > When when writing to a zoned block device using zone append, the start > sector of the write is pointing at the start LBA of the zone to write to. > Upon completion the block device will respond with the position the data > has been placed in the zone. This from a high level perspective can be > seen like a file system's block allocator, where the user writes to a > file and the file-system takes care of the data placement on the device. > > In order to fully exploit the new zone append command in file-systems and > other interfaces above the block layer, we choose to emulate zone append > in SCSI and null_blk. This way we can have a single write path for both > file-systems and other interfaces above the block-layer, like io_uring on > zoned block devices, without having to care too much about the underlying > characteristics of the device itself. > > The emulation works by providing a cache of each zone's write pointer, so > zone append issued to the disk can be translated to a write with a > starting LBA of the write pointer. This LBA is used as input zone number > for the write pointer lookup in the zone write pointer offset cache and > the cached offset is then added to the LBA to get the actual position to > write the data. In SCSI we then turn the REQ_OP_ZONE_APPEND request into a > WRITE(16) command. Upon successful completion of the WRITE(16), the cache > will be updated to the new write pointer location and the written sector > will be noted in the request. On error the cache entry will be marked as > invalid and on the next write an update of the write pointer will be > scheduled, before issuing the actual write. > > In order to reduce memory consumption, the only cached item is the offset > of the write pointer from the start of the zone, everything else can be > calculated. On an example drive with 52156 zones, the additional memory > consumption of the cache is thus 52156 * 4 = 208624 Bytes or 51 4k Byte > pages. The performance impact is neglectable for a spinning drive. > > For null_blk the emulation is way simpler, as null_blk's zoned block > device emulation support already caches the write pointer position, so we > only need to report the position back to the upper layers. Additional > caching is not needed here. > > Furthermore we have converted zonefs to run use ZONE_APPEND for synchronous > direct I/Os. Asynchronous I/O still uses the normal path via iomap. > > Performance testing with zonefs sync writes on a 14 TB SMR drive and nullblk > shows good results. On the SMR drive we're not regressing (the performance > improvement is within noise), on nullblk we could drastically improve specific > workloads: > > * nullblk: > > Single Thread Multiple Zones > kIOPS MiB/s MB/s % delta > mq-deadline REQ_OP_WRITE 10.1 631 662 > mq-deadline REQ_OP_ZONE_APPEND 13.2 828 868 +31.12 > none REQ_OP_ZONE_APPEND 15.6 978 1026 +54.98 > > > Multiple Threads Multiple Zones > kIOPS MiB/s MB/s % delta > mq-deadline REQ_OP_WRITE 10.2 640 671 > mq-deadline REQ_OP_ZONE_APPEND 10.4 650 681 +1.49 > none REQ_OP_ZONE_APPEND 16.9 1058 1109 +65.28 > > * 14 TB SMR drive > > Single Thread Multiple Zones > IOPS MiB/s MB/s % delta > mq-deadline REQ_OP_WRITE 797 49.9 52.3 > mq-deadline REQ_OP_ZONE_APPEND 806 50.4 52.9 +1.15 > > Multiple Threads Multiple Zones > kIOPS MiB/s MB/s % delta > mq-deadline REQ_OP_WRITE 745 46.6 48.9 > mq-deadline REQ_OP_ZONE_APPEND 768 48 50.3 +2.86 > > The %-delta is against the baseline of REQ_OP_WRITE using mq-deadline as I/O > scheduler. > > The series is based on Jens' for-5.8/block branch with HEAD: > ae979182ebb3 ("bdi: fix up for "remove the name field in struct backing_dev_info"") Applied for 5.8, thanks.
The upcoming NVMe ZNS Specification will define a new type of write command for zoned block devices, zone append. When when writing to a zoned block device using zone append, the start sector of the write is pointing at the start LBA of the zone to write to. Upon completion the block device will respond with the position the data has been placed in the zone. This from a high level perspective can be seen like a file system's block allocator, where the user writes to a file and the file-system takes care of the data placement on the device. In order to fully exploit the new zone append command in file-systems and other interfaces above the block layer, we choose to emulate zone append in SCSI and null_blk. This way we can have a single write path for both file-systems and other interfaces above the block-layer, like io_uring on zoned block devices, without having to care too much about the underlying characteristics of the device itself. The emulation works by providing a cache of each zone's write pointer, so zone append issued to the disk can be translated to a write with a starting LBA of the write pointer. This LBA is used as input zone number for the write pointer lookup in the zone write pointer offset cache and the cached offset is then added to the LBA to get the actual position to write the data. In SCSI we then turn the REQ_OP_ZONE_APPEND request into a WRITE(16) command. Upon successful completion of the WRITE(16), the cache will be updated to the new write pointer location and the written sector will be noted in the request. On error the cache entry will be marked as invalid and on the next write an update of the write pointer will be scheduled, before issuing the actual write. In order to reduce memory consumption, the only cached item is the offset of the write pointer from the start of the zone, everything else can be calculated. On an example drive with 52156 zones, the additional memory consumption of the cache is thus 52156 * 4 = 208624 Bytes or 51 4k Byte pages. The performance impact is neglectable for a spinning drive. For null_blk the emulation is way simpler, as null_blk's zoned block device emulation support already caches the write pointer position, so we only need to report the position back to the upper layers. Additional caching is not needed here. Furthermore we have converted zonefs to run use ZONE_APPEND for synchronous direct I/Os. Asynchronous I/O still uses the normal path via iomap. Performance testing with zonefs sync writes on a 14 TB SMR drive and nullblk shows good results. On the SMR drive we're not regressing (the performance improvement is within noise), on nullblk we could drastically improve specific workloads: * nullblk: Single Thread Multiple Zones kIOPS MiB/s MB/s % delta mq-deadline REQ_OP_WRITE 10.1 631 662 mq-deadline REQ_OP_ZONE_APPEND 13.2 828 868 +31.12 none REQ_OP_ZONE_APPEND 15.6 978 1026 +54.98 Multiple Threads Multiple Zones kIOPS MiB/s MB/s % delta mq-deadline REQ_OP_WRITE 10.2 640 671 mq-deadline REQ_OP_ZONE_APPEND 10.4 650 681 +1.49 none REQ_OP_ZONE_APPEND 16.9 1058 1109 +65.28 * 14 TB SMR drive Single Thread Multiple Zones IOPS MiB/s MB/s % delta mq-deadline REQ_OP_WRITE 797 49.9 52.3 mq-deadline REQ_OP_ZONE_APPEND 806 50.4 52.9 +1.15 Multiple Threads Multiple Zones kIOPS MiB/s MB/s % delta mq-deadline REQ_OP_WRITE 745 46.6 48.9 mq-deadline REQ_OP_ZONE_APPEND 768 48 50.3 +2.86 The %-delta is against the baseline of REQ_OP_WRITE using mq-deadline as I/O scheduler. The series is based on Jens' for-5.8/block branch with HEAD: ae979182ebb3 ("bdi: fix up for "remove the name field in struct backing_dev_info"") As Christoph asked for a branch I pushed it to a git repo at: git://git.kernel.org/pub/scm/linux/kernel/git/jth/linux.git zone-append.v11 https://git.kernel.org/pub/scm/linux/kernel/git/jth/linux.git/log/?h=zone-append.v11 Changes to v10: - Added Reviews from Hannes - Added Performance Numbers to cover letter Changes to v9: - Renamed zone_wp_ofst to zone_wp_offset (Hannes/Martin) - Colledted Reviews - Dropped already merged patches Changes to v8: - Added kerneldoc for bio_add_hw_page (Hannes) - Simplified calculation of zone-boundary cross checking (Bart) - Added safety nets for max_appen_sectors setting - Added Reviews from Hannes - Added Damien's Ack on the zonefs change Changes to v7: - Rebased on Jens' for-5.8/block - Fixed up stray whitespace change (Bart) - Added Reviews from Bart and Christoph Changes to v6: - Added Daniel's Reviewed-by's - Addressed Christoph's comment on whitespace changes in 4/11 - Renamed driver_cb in 6/11 - Fixed lines over 80 characters in 8/11 - Damien simplified sd_zbc_revalidate_zones() in 8/11 Changes to v5: - Added patch to fix the memleak on failed scsi command setup - Added prep patch from Christoph for bio_add_hw_page - Added Christoph's suggestions for adding append pages to bios - Fixed compile warning with !CONFIG_BLK_DEV_ZONED - Damien re-worked revalidate zone - Added Christoph's suggestions for rescanning write pointers to update cache Changes to v4: - Added page merging for zone-append bios (Christoph) - Removed different locking schmes for zone management operations (Christoph) - Changed wp_ofst assignment from blk_revalidate_zones (Christoph) - Smaller nitpicks (Christoph) - Documented my changes to Keith's patch so it's clear where I messed up so he doesn't get blamed - Added Damien as a Co-developer to the sd emulation patch as he wrote as much code for it as I did (if not more) Changes since v3: - Remove impact of zone-append from bio_full() and bio_add_page() fast-path (Christoph) - All of the zone write pointer offset caching is handled in SCSI now (Christoph) - Drop null_blk pathces that damien sent separately (Christoph) - Use EXPORT_SYMBOL_GPL for new exports (Christoph) Changes since v2: - Remove iomap implementation and directly issue zone-appends from within zonefs (Christoph) - Drop already merged patch - Rebase onto new for-next branch Changes since v1: - Too much to mention, treat as a completely new series. Christoph Hellwig (1): block: rename __bio_add_pc_page to bio_add_hw_page Damien Le Moal (2): block: Modify revalidate zones null_blk: Support REQ_OP_ZONE_APPEND Johannes Thumshirn (6): block: provide fallbacks for blk_queue_zone_is_seq and blk_queue_zone_no block: introduce blk_req_zone_write_trylock scsi: sd_zbc: factor out sanity checks for zoned commands scsi: sd_zbc: emulate ZONE_APPEND commands block: export bio_release_pages and bio_iov_iter_get_pages zonefs: use REQ_OP_ZONE_APPEND for sync DIO Keith Busch (1): block: Introduce REQ_OP_ZONE_APPEND block/bio.c | 129 ++++++++--- block/blk-core.c | 52 +++++ block/blk-map.c | 5 +- block/blk-mq.c | 27 +++ block/blk-settings.c | 31 +++ block/blk-sysfs.c | 13 ++ block/blk-zoned.c | 23 +- block/blk.h | 4 +- drivers/block/null_blk_zoned.c | 37 ++- drivers/scsi/scsi_lib.c | 1 + drivers/scsi/sd.c | 16 +- drivers/scsi/sd.h | 43 +++- drivers/scsi/sd_zbc.c | 399 ++++++++++++++++++++++++++++++--- fs/zonefs/super.c | 80 ++++++- include/linux/blk_types.h | 14 ++ include/linux/blkdev.h | 25 ++- 16 files changed, 807 insertions(+), 92 deletions(-)