diff mbox series

avinfo: Print more A/V capabilities

Message ID 20200512165112.24006-1-pali@kernel.org (mailing list archive)
State New, archived
Headers show
Series avinfo: Print more A/V capabilities | expand

Commit Message

Pali Rohár May 12, 2020, 4:51 p.m. UTC 
---
 tools/avinfo.c | 27 ++++++++++++++++++++++++---
 1 file changed, 24 insertions(+), 3 deletions(-)

Comments

bluez.test.bot@gmail.com May 12, 2020, 5:37 p.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While we are preparing for reviewing the patches, we found the following
issue/warning.

Test Result:
checkpatch Failed

Outputs:
WARNING:LONG_LINE: line over 80 characters
#49: FILE: tools/avinfo.c:723:
+				printf("\tUnknown category: %d\n", cap->category);

- total: 0 errors, 1 warnings, 43 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.



---
Regards,
Linux Bluetooth
bluez.test.bot@gmail.com May 12, 2020, 5:37 p.m. UTC | #2 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While we are preparing for reviewing the patches, we found the following
issue/warning.

Test Result:
checkgitlint Failed

Outputs:
3: B6 Body message is missing



---
Regards,
Linux Bluetooth
Pali Rohár July 1, 2020, 8:35 a.m. UTC | #3 
Hello! Could you look at following patch?

On Tuesday 12 May 2020 18:51:12 Pali Rohár wrote:
> ---
>  tools/avinfo.c | 27 ++++++++++++++++++++++++---
>  1 file changed, 24 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/avinfo.c b/tools/avinfo.c
> index e45b50918..576981a5e 100644
> --- a/tools/avinfo.c
> +++ b/tools/avinfo.c
> @@ -65,6 +65,7 @@
>  #define AVDTP_HEADER_COMPRESSION	0x05
>  #define AVDTP_MULTIPLEXING		0x06
>  #define AVDTP_MEDIA_CODEC		0x07
> +#define AVDTP_DELAY_REPORTING		0x08
>  
>  /* SEP types definitions */
>  #define AVDTP_SEP_TYPE_SOURCE		0x00
> @@ -696,13 +697,33 @@ static void print_caps(void *data, int size)
>  
>  		switch (cap->category) {
>  		case AVDTP_MEDIA_TRANSPORT:
> +			printf("\tMedia Transport: Supported\n");
> +			break;
>  		case AVDTP_REPORTING:
> +			printf("\tReporting: Supported\n");
> +			break;
> +		case AVDTP_DELAY_REPORTING:
> +			printf("\tDelay Reporting: Supported\n");
> +			break;
>  		case AVDTP_RECOVERY:
> +		case AVDTP_HEADER_COMPRESSION:
>  		case AVDTP_MULTIPLEXING:
> -			/* FIXME: Add proper functions */
> -			break;
>  		default:
> -			printf("\tUnknown category: %d\n", cap->category);
> +			switch (cap->category) {
> +			case AVDTP_RECOVERY:
> +				printf("\tRecovery:\n");
> +				break;
> +			case AVDTP_HEADER_COMPRESSION:
> +				printf("\tHeader compression:\n");
> +				break;
> +			case AVDTP_MULTIPLEXING:
> +				printf("\tMultiplexing:\n");
> +				break;
> +			default:
> +				printf("\tUnknown category: %d\n", cap->category);
> +				break;
> +			}
> +			/* FIXME: Add proper functions */
>  			printf("\t\tData:");
>  			for (i = 0; i < cap->length; ++i)
>  				printf(" 0x%.02x",
> -- 
> 2.20.1
>
Pali Rohár Aug. 8, 2020, 1:23 p.m. UTC | #4 
Hello! I would like to remind also this patch:

On Tuesday 12 May 2020 18:51:12 Pali Rohár wrote:
> ---
>  tools/avinfo.c | 27 ++++++++++++++++++++++++---
>  1 file changed, 24 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/avinfo.c b/tools/avinfo.c
> index e45b50918..576981a5e 100644
> --- a/tools/avinfo.c
> +++ b/tools/avinfo.c
> @@ -65,6 +65,7 @@
>  #define AVDTP_HEADER_COMPRESSION	0x05
>  #define AVDTP_MULTIPLEXING		0x06
>  #define AVDTP_MEDIA_CODEC		0x07
> +#define AVDTP_DELAY_REPORTING		0x08
>  
>  /* SEP types definitions */
>  #define AVDTP_SEP_TYPE_SOURCE		0x00
> @@ -696,13 +697,33 @@ static void print_caps(void *data, int size)
>  
>  		switch (cap->category) {
>  		case AVDTP_MEDIA_TRANSPORT:
> +			printf("\tMedia Transport: Supported\n");
> +			break;
>  		case AVDTP_REPORTING:
> +			printf("\tReporting: Supported\n");
> +			break;
> +		case AVDTP_DELAY_REPORTING:
> +			printf("\tDelay Reporting: Supported\n");
> +			break;
>  		case AVDTP_RECOVERY:
> +		case AVDTP_HEADER_COMPRESSION:
>  		case AVDTP_MULTIPLEXING:
> -			/* FIXME: Add proper functions */
> -			break;
>  		default:
> -			printf("\tUnknown category: %d\n", cap->category);
> +			switch (cap->category) {
> +			case AVDTP_RECOVERY:
> +				printf("\tRecovery:\n");
> +				break;
> +			case AVDTP_HEADER_COMPRESSION:
> +				printf("\tHeader compression:\n");
> +				break;
> +			case AVDTP_MULTIPLEXING:
> +				printf("\tMultiplexing:\n");
> +				break;
> +			default:
> +				printf("\tUnknown category: %d\n", cap->category);
> +				break;
> +			}
> +			/* FIXME: Add proper functions */
>  			printf("\t\tData:");
>  			for (i = 0; i < cap->length; ++i)
>  				printf(" 0x%.02x",
> -- 
> 2.20.1
>
Pali Rohár Sept. 29, 2020, 9:34 p.m. UTC | #5 
On Saturday 08 August 2020 15:23:36 Pali Rohár wrote:
> Hello! I would like to remind also this patch:

PING

> On Tuesday 12 May 2020 18:51:12 Pali Rohár wrote:
> > ---
> >  tools/avinfo.c | 27 ++++++++++++++++++++++++---
> >  1 file changed, 24 insertions(+), 3 deletions(-)
> > 
> > diff --git a/tools/avinfo.c b/tools/avinfo.c
> > index e45b50918..576981a5e 100644
> > --- a/tools/avinfo.c
> > +++ b/tools/avinfo.c
> > @@ -65,6 +65,7 @@
> >  #define AVDTP_HEADER_COMPRESSION	0x05
> >  #define AVDTP_MULTIPLEXING		0x06
> >  #define AVDTP_MEDIA_CODEC		0x07
> > +#define AVDTP_DELAY_REPORTING		0x08
> >  
> >  /* SEP types definitions */
> >  #define AVDTP_SEP_TYPE_SOURCE		0x00
> > @@ -696,13 +697,33 @@ static void print_caps(void *data, int size)
> >  
> >  		switch (cap->category) {
> >  		case AVDTP_MEDIA_TRANSPORT:
> > +			printf("\tMedia Transport: Supported\n");
> > +			break;
> >  		case AVDTP_REPORTING:
> > +			printf("\tReporting: Supported\n");
> > +			break;
> > +		case AVDTP_DELAY_REPORTING:
> > +			printf("\tDelay Reporting: Supported\n");
> > +			break;
> >  		case AVDTP_RECOVERY:
> > +		case AVDTP_HEADER_COMPRESSION:
> >  		case AVDTP_MULTIPLEXING:
> > -			/* FIXME: Add proper functions */
> > -			break;
> >  		default:
> > -			printf("\tUnknown category: %d\n", cap->category);
> > +			switch (cap->category) {
> > +			case AVDTP_RECOVERY:
> > +				printf("\tRecovery:\n");
> > +				break;
> > +			case AVDTP_HEADER_COMPRESSION:
> > +				printf("\tHeader compression:\n");
> > +				break;
> > +			case AVDTP_MULTIPLEXING:
> > +				printf("\tMultiplexing:\n");
> > +				break;
> > +			default:
> > +				printf("\tUnknown category: %d\n", cap->category);
> > +				break;
> > +			}
> > +			/* FIXME: Add proper functions */
> >  			printf("\t\tData:");
> >  			for (i = 0; i < cap->length; ++i)
> >  				printf(" 0x%.02x",
> > -- 
> > 2.20.1
> >
diff mbox series

Patch

diff --git a/tools/avinfo.c b/tools/avinfo.c
index e45b50918..576981a5e 100644
--- a/tools/avinfo.c
+++ b/tools/avinfo.c
@@ -65,6 +65,7 @@ 
 #define AVDTP_HEADER_COMPRESSION	0x05
 #define AVDTP_MULTIPLEXING		0x06
 #define AVDTP_MEDIA_CODEC		0x07
+#define AVDTP_DELAY_REPORTING		0x08
 
 /* SEP types definitions */
 #define AVDTP_SEP_TYPE_SOURCE		0x00
@@ -696,13 +697,33 @@  static void print_caps(void *data, int size)
 
 		switch (cap->category) {
 		case AVDTP_MEDIA_TRANSPORT:
+			printf("\tMedia Transport: Supported\n");
+			break;
 		case AVDTP_REPORTING:
+			printf("\tReporting: Supported\n");
+			break;
+		case AVDTP_DELAY_REPORTING:
+			printf("\tDelay Reporting: Supported\n");
+			break;
 		case AVDTP_RECOVERY:
+		case AVDTP_HEADER_COMPRESSION:
 		case AVDTP_MULTIPLEXING:
-			/* FIXME: Add proper functions */
-			break;
 		default:
-			printf("\tUnknown category: %d\n", cap->category);
+			switch (cap->category) {
+			case AVDTP_RECOVERY:
+				printf("\tRecovery:\n");
+				break;
+			case AVDTP_HEADER_COMPRESSION:
+				printf("\tHeader compression:\n");
+				break;
+			case AVDTP_MULTIPLEXING:
+				printf("\tMultiplexing:\n");
+				break;
+			default:
+				printf("\tUnknown category: %d\n", cap->category);
+				break;
+			}
+			/* FIXME: Add proper functions */
 			printf("\t\tData:");
 			for (i = 0; i < cap->length; ++i)
 				printf(" 0x%.02x",