| Message ID | 20200502114752.1048500-2-martin.blumenstingl@googlemail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | phy: meson8b-usb2: small fixes and improvements | expand |
On Sat, May 2, 2020 at 1:48 PM Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > > Now that we have the DT validation in place, let's convert the device > tree bindings for the Amlogic Meson8, Meson8b, Meson8m2 and GXBB USB2 > PHY over to a YAML schema. > > While here, also add the fallback compatible string > "amlogic,meson-gxbb-usb2-phy" which is already used in > arch/arm/boot/dts/meson{,8,8b}.dtsi. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Tested-by: hexdump <hexdump0815@googlemail.com> > --- > .../phy/amlogic,meson8b-usb2-phy.yaml | 61 +++++++++++++++++++ > .../bindings/phy/meson8b-usb2-phy.txt | 28 --------- > 2 files changed, 61 insertions(+), 28 deletions(-) > create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson8b-usb2-phy.yaml > delete mode 100644 Documentation/devicetree/bindings/phy/meson8b-usb2-phy.txt > > diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson8b-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson8b-usb2-phy.yaml > new file mode 100644 > index 000000000000..c2fe8c08d99e > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/amlogic,meson8b-usb2-phy.yaml > @@ -0,0 +1,61 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/phy/amlogic,meson8b-usb2-phy.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Amlogic Meson8, Meson8b, Meson8m2 and GXBB USB2 PHY > + > +maintainers: > + - Martin Blumenstingl <martin.blumenstingl@googlemail.com> > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - amlogic,meson8-usb2-phy > + - amlogic,meson8b-usb2-phy > + - const: amlogic,meson-mx-usb2-phy > + - const: amlogic,meson-gxbb-usb2-phy > + > + reg: > + maxItems: 1 > + > + clocks: > + minItems: 2 > + > + clock-names: > + items: > + - const: usb_general > + - const: usb > + > + resets: > + minItems: 1 > + > + "#phy-cells": > + const: 0 > + > + phy-supply: > + description: > + Phandle to a regulator that provides power to the PHY. This > + regulator will be managed during the PHY power on/off sequence. > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - "#phy-cells" > + > +examples: > + - | > + usb-phy@c0000000 { > + compatible = "amlogic,meson-gxbb-usb2-phy"; > + reg = <0xc0000000 0x20>; > + resets = <&reset_usb_phy>; > + clocks = <&clk_usb_general>, <&reset_usb>; > + clock-names = "usb_general", "usb"; > + phy-supply = <&usb_vbus>; > + #phy-cells = <0>; > + }; > diff --git a/Documentation/devicetree/bindings/phy/meson8b-usb2-phy.txt b/Documentation/devicetree/bindings/phy/meson8b-usb2-phy.txt > deleted file mode 100644 > index d81d73aea608..000000000000 > --- a/Documentation/devicetree/bindings/phy/meson8b-usb2-phy.txt > +++ /dev/null > @@ -1,28 +0,0 @@ > -* Amlogic Meson8, Meson8b and GXBB USB2 PHY > - > -Required properties: > -- compatible: Depending on the platform this should be one of: > - "amlogic,meson8-usb2-phy" > - "amlogic,meson8b-usb2-phy" > - "amlogic,meson-gxbb-usb2-phy" > -- reg: The base address and length of the registers > -- #phys-cells: should be 0 (see phy-bindings.txt in this directory) > -- clocks: phandle and clock identifier for the phy clocks > -- clock-names: "usb_general" and "usb" > - > -Optional properties: > -- resets: reference to the reset controller > -- phy-supply: see phy-bindings.txt in this directory > - > - > -Example: > - > -usb0_phy: usb-phy@c0000000 { > - compatible = "amlogic,meson-gxbb-usb2-phy"; > - #phy-cells = <0>; > - reg = <0x0 0xc0000000 0x0 0x20>; > - resets = <&reset RESET_USB_OTG>; > - clocks = <&clkc CLKID_USB>, <&clkc CLKID_USB0>; > - clock-names = "usb_general", "usb"; > - phy-supply = <&usb_vbus>; > -}; > -- > 2.26.2 >
On Mon, 2020-05-04 at 12:55 +0200, hex dump wrote: > On Sat, May 2, 2020 at 1:48 PM Martin Blumenstingl > <martin.blumenstingl@googlemail.com> wrote: > > Now that we have the DT validation in place, let's convert the device > > tree bindings for the Amlogic Meson8, Meson8b, Meson8m2 and GXBB USB2 > > PHY over to a YAML schema. > > > > While here, also add the fallback compatible string > > "amlogic,meson-gxbb-usb2-phy" which is already used in > > arch/arm/boot/dts/meson{,8,8b}.dtsi. > > > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > Tested-by: hexdump <hexdump0815@googlemail.com> Is the kernel now accepting "Tested-by" lines from robots? If hexdump0815@googlemail.com is not a robot, can you please use your full legal name instead?
On 04-05-20, 10:31, Joe Perches wrote: > On Mon, 2020-05-04 at 12:55 +0200, hex dump wrote: > > On Sat, May 2, 2020 at 1:48 PM Martin Blumenstingl > > <martin.blumenstingl@googlemail.com> wrote: > > > Now that we have the DT validation in place, let's convert the device > > > tree bindings for the Amlogic Meson8, Meson8b, Meson8m2 and GXBB USB2 > > > PHY over to a YAML schema. > > > > > > While here, also add the fallback compatible string > > > "amlogic,meson-gxbb-usb2-phy" which is already used in > > > arch/arm/boot/dts/meson{,8,8b}.dtsi. > > > > > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > > > Tested-by: hexdump <hexdump0815@googlemail.com> > > Is the kernel now accepting "Tested-by" lines from robots? Should we not? bots have been given Reported-by... > > If hexdump0815@googlemail.com is not a robot, can you please use > your full legal name instead? Looking at emails, this doesnt seem a bot, so I am asking for full legal name for these to be added. Thanks
On Sat, May 02, 2020 at 01:47:47PM +0200, Martin Blumenstingl wrote: > Now that we have the DT validation in place, let's convert the device > tree bindings for the Amlogic Meson8, Meson8b, Meson8m2 and GXBB USB2 > PHY over to a YAML schema. > > While here, also add the fallback compatible string > "amlogic,meson-gxbb-usb2-phy" which is already used in > arch/arm/boot/dts/meson{,8,8b}.dtsi. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > .../phy/amlogic,meson8b-usb2-phy.yaml | 61 +++++++++++++++++++ > .../bindings/phy/meson8b-usb2-phy.txt | 28 --------- > 2 files changed, 61 insertions(+), 28 deletions(-) > create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson8b-usb2-phy.yaml > delete mode 100644 Documentation/devicetree/bindings/phy/meson8b-usb2-phy.txt > > diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson8b-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson8b-usb2-phy.yaml > new file mode 100644 > index 000000000000..c2fe8c08d99e > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/amlogic,meson8b-usb2-phy.yaml > @@ -0,0 +1,61 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/phy/amlogic,meson8b-usb2-phy.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Amlogic Meson8, Meson8b, Meson8m2 and GXBB USB2 PHY > + > +maintainers: > + - Martin Blumenstingl <martin.blumenstingl@googlemail.com> > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - amlogic,meson8-usb2-phy > + - amlogic,meson8b-usb2-phy Needs 2 more spaces indent. > + - const: amlogic,meson-mx-usb2-phy > + - const: amlogic,meson-gxbb-usb2-phy > + > + reg: > + maxItems: 1 > + > + clocks: > + minItems: 2 > + > + clock-names: > + items: > + - const: usb_general > + - const: usb > + > + resets: > + minItems: 1 > + > + "#phy-cells": > + const: 0 > + > + phy-supply: > + description: Wrong indentation. > + Phandle to a regulator that provides power to the PHY. This > + regulator will be managed during the PHY power on/off sequence. > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - "#phy-cells" Add: additionalProperties: false > + > +examples: > + - | > + usb-phy@c0000000 { > + compatible = "amlogic,meson-gxbb-usb2-phy"; > + reg = <0xc0000000 0x20>; > + resets = <&reset_usb_phy>; > + clocks = <&clk_usb_general>, <&reset_usb>; > + clock-names = "usb_general", "usb"; > + phy-supply = <&usb_vbus>; > + #phy-cells = <0>; > + };
diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson8b-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson8b-usb2-phy.yaml new file mode 100644 index 000000000000..c2fe8c08d99e --- /dev/null +++ b/Documentation/devicetree/bindings/phy/amlogic,meson8b-usb2-phy.yaml @@ -0,0 +1,61 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/phy/amlogic,meson8b-usb2-phy.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Amlogic Meson8, Meson8b, Meson8m2 and GXBB USB2 PHY + +maintainers: + - Martin Blumenstingl <martin.blumenstingl@googlemail.com> + +properties: + compatible: + oneOf: + - items: + - enum: + - amlogic,meson8-usb2-phy + - amlogic,meson8b-usb2-phy + - const: amlogic,meson-mx-usb2-phy + - const: amlogic,meson-gxbb-usb2-phy + + reg: + maxItems: 1 + + clocks: + minItems: 2 + + clock-names: + items: + - const: usb_general + - const: usb + + resets: + minItems: 1 + + "#phy-cells": + const: 0 + + phy-supply: + description: + Phandle to a regulator that provides power to the PHY. This + regulator will be managed during the PHY power on/off sequence. + +required: + - compatible + - reg + - clocks + - clock-names + - "#phy-cells" + +examples: + - | + usb-phy@c0000000 { + compatible = "amlogic,meson-gxbb-usb2-phy"; + reg = <0xc0000000 0x20>; + resets = <&reset_usb_phy>; + clocks = <&clk_usb_general>, <&reset_usb>; + clock-names = "usb_general", "usb"; + phy-supply = <&usb_vbus>; + #phy-cells = <0>; + }; diff --git a/Documentation/devicetree/bindings/phy/meson8b-usb2-phy.txt b/Documentation/devicetree/bindings/phy/meson8b-usb2-phy.txt deleted file mode 100644 index d81d73aea608..000000000000 --- a/Documentation/devicetree/bindings/phy/meson8b-usb2-phy.txt +++ /dev/null @@ -1,28 +0,0 @@ -* Amlogic Meson8, Meson8b and GXBB USB2 PHY - -Required properties: -- compatible: Depending on the platform this should be one of: - "amlogic,meson8-usb2-phy" - "amlogic,meson8b-usb2-phy" - "amlogic,meson-gxbb-usb2-phy" -- reg: The base address and length of the registers -- #phys-cells: should be 0 (see phy-bindings.txt in this directory) -- clocks: phandle and clock identifier for the phy clocks -- clock-names: "usb_general" and "usb" - -Optional properties: -- resets: reference to the reset controller -- phy-supply: see phy-bindings.txt in this directory - - -Example: - -usb0_phy: usb-phy@c0000000 { - compatible = "amlogic,meson-gxbb-usb2-phy"; - #phy-cells = <0>; - reg = <0x0 0xc0000000 0x0 0x20>; - resets = <&reset RESET_USB_OTG>; - clocks = <&clkc CLKID_USB>, <&clkc CLKID_USB0>; - clock-names = "usb_general", "usb"; - phy-supply = <&usb_vbus>; -};
Now that we have the DT validation in place, let's convert the device tree bindings for the Amlogic Meson8, Meson8b, Meson8m2 and GXBB USB2 PHY over to a YAML schema. While here, also add the fallback compatible string "amlogic,meson-gxbb-usb2-phy" which is already used in arch/arm/boot/dts/meson{,8,8b}.dtsi. Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- .../phy/amlogic,meson8b-usb2-phy.yaml | 61 +++++++++++++++++++ .../bindings/phy/meson8b-usb2-phy.txt | 28 --------- 2 files changed, 61 insertions(+), 28 deletions(-) create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson8b-usb2-phy.yaml delete mode 100644 Documentation/devicetree/bindings/phy/meson8b-usb2-phy.txt