diff mbox series

[4/4] dt-bindings: soc: qcom: Document MSM8936 SMD RPM compatible

Message ID 20200501223232.275800-5-konradybcio@gmail.com (mailing list archive)
State Superseded, archived
Headers show
Series Add SMD RPM support for MSM8936 | expand

Commit Message

Konrad Dybcio May 1, 2020, 10:32 p.m. UTC 
From: Vincent Knecht <vincent.knecht@mailoo.org>

Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
---
 Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt | 1 +
 1 file changed, 1 insertion(+)

Comments

Rob Herring (Arm) May 12, 2020, 10:45 p.m. UTC | #1 
On Sat,  2 May 2020 00:32:32 +0200, Konrad Dybcio wrote:
> From: Vincent Knecht <vincent.knecht@mailoo.org>
> 
> Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
> ---
>  Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
Stephen Boyd May 27, 2020, 3:03 a.m. UTC | #2 
Quoting Rob Herring (2020-05-12 15:45:22)
> On Sat,  2 May 2020 00:32:32 +0200, Konrad Dybcio wrote:
> > From: Vincent Knecht <vincent.knecht@mailoo.org>
> > 
> > Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
> > ---
> >  Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> 
> Acked-by: Rob Herring <robh@kernel.org>

I picked these ones up actually, not the other ones, but my MUA totally
failed to open anything because the patches weren't sent To: anyone. O
well!
Stephen Boyd May 27, 2020, 3:06 a.m. UTC | #3 
Quoting Stephen Boyd (2020-05-26 20:03:42)
> Quoting Rob Herring (2020-05-12 15:45:22)
> > On Sat,  2 May 2020 00:32:32 +0200, Konrad Dybcio wrote:
> > > From: Vincent Knecht <vincent.knecht@mailoo.org>
> > > 
> > > Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
> > > ---
> > >  Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > 
> > Acked-by: Rob Herring <robh@kernel.org>
> 
> I picked these ones up actually, not the other ones, but my MUA totally
> failed to open anything because the patches weren't sent To: anyone. O
> well!

Oh and now I've dropped them because:

drivers/clk/qcom/clk-smd-rpm.c:478:4: error: ‘RPM_SMD_SYSMMNOC_A_CLK’ undeclared here (not in a function); did you mean ‘RPM_SMD_SNOC_A_CLK’?
  478 |   [RPM_SMD_SYSMMNOC_A_CLK]  = &msm8936_sysmmnoc_a_clk,
      |    ^~~~~~~~~~~~~~~~~~~~~~
      |    RPM_SMD_SNOC_A_CLK

So please fix that and resend with proper To.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt
index 616fddcd09fd8..55f8abd845a7e 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt
@@ -21,6 +21,7 @@  resources.
 	Definition: must be one of:
 		    "qcom,rpm-apq8084"
 		    "qcom,rpm-msm8916"
+		    "qcom,rpm-msm8936"
 		    "qcom,rpm-msm8974"
 		    "qcom,rpm-msm8976"
 		    "qcom,rpm-msm8998"