Message ID | 20200512155105.1068064-2-kieran.bingham+renesas@ideasonboard.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | MAX9286 GMSL Support (+RDACM20) | expand |
On Tue, 12 May 2020 16:51:02 +0100, Kieran Bingham wrote: > From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > The MAX9286 deserializes video data received on up to 4 Gigabit > Multimedia Serial Links (GMSL) and outputs them on a CSI-2 port using up > to 4 data lanes. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > Reviewed-by: Rob Herring <robh@kernel.org> > > --- > > v7: > - Collect Rob's RB tag > - Remove redundant maxItems from remote-endpoints > - Fix SPDX licence tag > > .../bindings/media/i2c/maxim,max9286.yaml | 287 ++++++++++++++++++ > 1 file changed, 287 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml > My bot found errors running 'make dt_binding_check' on your patch: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml: properties: {'enum': ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 'then', 'unevaluatedProperties']} is not allowed for 'additionalProperties' Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/media/i2c/maxim,max9286.example.dts' failed make[1]: *** [Documentation/devicetree/bindings/media/i2c/maxim,max9286.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs.... Makefile:1300: recipe for target 'dt_binding_check' failed make: *** [dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1288573 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.
On Tue, May 12, 2020 at 04:51:02PM +0100, Kieran Bingham wrote: > From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > The MAX9286 deserializes video data received on up to 4 Gigabit > Multimedia Serial Links (GMSL) and outputs them on a CSI-2 port using up > to 4 data lanes. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > Reviewed-by: Rob Herring <robh@kernel.org> > > --- > > v7: > - Collect Rob's RB tag > - Remove redundant maxItems from remote-endpoints > - Fix SPDX licence tag > > .../bindings/media/i2c/maxim,max9286.yaml | 287 ++++++++++++++++++ > 1 file changed, 287 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml > > diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml > new file mode 100644 > index 000000000000..f9d3e5712c59 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml > @@ -0,0 +1,287 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2019 Renesas Electronics Corp. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/maxim,max9286.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Maxim Integrated Quad GMSL Deserializer > + > +maintainers: > + - Jacopo Mondi <jacopo+renesas@jmondi.org> > + - Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > + - Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > + - Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > + > +description: | > + The MAX9286 deserializer receives video data on up to 4 Gigabit Multimedia > + Serial Links (GMSL) and outputs them on a CSI-2 D-PHY port using up to 4 data > + lanes. > + > + In addition to video data, the GMSL links carry a bidirectional control > + channel that encapsulates I2C messages. The MAX9286 forwards all I2C traffic > + not addressed to itself to the other side of the links, where a GMSL > + serializer will output it on a local I2C bus. In the other direction all I2C > + traffic received over GMSL by the MAX9286 is output on the local I2C bus. > + > +properties: > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > + compatible: > + const: maxim,max9286 > + > + reg: > + description: I2C device address > + maxItems: 1 > + > + poc-supply: > + description: Regulator providing Power over Coax to the cameras > + maxItems: 1 > + > + enable-gpios: > + description: GPIO connected to the \#PWDN pin with inverted polarity > + maxItems: 1 > + > + ports: > + type: object > + description: | > + The connections to the MAX9286 GMSL and its endpoint nodes are modelled > + using the OF graph bindings in accordance with the video interface > + bindings defined in > + Documentation/devicetree/bindings/media/video-interfaces.txt. > + > + The following table lists the port number corresponding to each device > + port. > + > + Port Description > + ---------------------------------------- > + Port 0 GMSL Input 0 > + Port 1 GMSL Input 1 > + Port 2 GMSL Input 2 > + Port 3 GMSL Input 3 > + Port 4 CSI-2 Output > + > + properties: > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > + port@[0-3]: > + type: object > + properties: > + reg: > + enum: [ 0, 1, 2, 3 ] > + > + endpoint: > + type: object > + > + properties: > + remote-endpoint: > + description: | > + phandle to the remote GMSL source endpoint subnode in the > + remote node port. > + > + required: > + - remote-endpoint > + > + required: > + - reg > + - endpoint > + > + additionalProperties: false > + > + port@4: > + type: object > + properties: > + reg: > + const: 4 > + > + endpoint: > + type: object > + > + properties: > + remote-endpoint: > + description: phandle to the remote CSI-2 sink endpoint. > + > + data-lanes: > + description: array of physical CSI-2 data lane indexes. > + > + required: > + - remote-endpoint > + - data-lanes > + > + required: > + - reg > + - endpoint > + > + additionalProperties: false > + > + required: > + - port@4 > + > + i2c-mux: > + type: object > + description: | > + Each GMSL link is modelled as a child bus of an i2c bus > + multiplexer/switch, in accordance with bindings described in > + Documentation/devicetree/bindings/i2c/i2c-mux.txt. The serializer > + device on the remote end of the GMSL link shall be modelled as a child > + node of the corresponding I2C bus. > + > + properties: > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > + additionalProperties: false Wrong indentation. Should be 2 more or this is a DT property. > + > +required: > + - compatible > + - reg > + - ports > + - i2c-mux > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + i2c@e66d8000 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + reg = <0 0xe66d8000 0 0x40>; > + > + gmsl-deserializer@2c { > + compatible = "maxim,max9286"; > + reg = <0x2c>; > + poc-supply = <&camera_poc_12v>; > + enable-gpios = <&gpio 13 GPIO_ACTIVE_HIGH>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + max9286_in0: endpoint { > + remote-endpoint = <&rdacm20_out0>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + max9286_in1: endpoint { > + remote-endpoint = <&rdacm20_out1>; > + }; > + }; > + > + port@2 { > + reg = <2>; > + > + max9286_in2: endpoint { > + remote-endpoint = <&rdacm20_out2>; > + }; > + }; > + > + port@3 { > + reg = <3>; > + > + max9286_in3: endpoint { > + remote-endpoint = <&rdacm20_out3>; > + }; > + }; > + > + port@4 { > + reg = <4>; > + > + max9286_out: endpoint { > + data-lanes = <1 2 3 4>; > + remote-endpoint = <&csi40_in>; > + }; > + }; > + }; > + > + i2c-mux { > + #address-cells = <1>; > + #size-cells = <0>; > + > + i2c@0 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + reg = <0>; > + > + camera@51 { > + reg = <0x51>; > + > + port { > + rdacm20_out0: endpoint { > + remote-endpoint = <&max9286_in0>; > + }; > + }; > + > + }; > + }; > + > + i2c@1 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <1>; > + > + camera@52 { > + reg = <0x52>; > + > + port { > + rdacm20_out1: endpoint { > + remote-endpoint = <&max9286_in1>; > + }; > + }; > + }; > + }; > + > + i2c@2 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <2>; > + > + camera@53 { > + reg = <0x53>; > + > + port { > + rdacm20_out2: endpoint { > + remote-endpoint = <&max9286_in2>; > + }; > + }; > + }; > + }; > + > + i2c@3 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <3>; > + > + camera@54 { > + reg = <0x54>; > + > + port { > + rdacm20_out3: endpoint { > + remote-endpoint = <&max9286_in3>; > + }; > + }; > + }; > + }; > + }; > + }; > + }; > -- > 2.25.1 >
Hi Rob, On Tue, May 12, 2020 at 05:36:10PM -0500, Rob Herring wrote: > On Tue, May 12, 2020 at 04:51:02PM +0100, Kieran Bingham wrote: > > From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > > > The MAX9286 deserializes video data received on up to 4 Gigabit > > Multimedia Serial Links (GMSL) and outputs them on a CSI-2 port using up > > to 4 data lanes. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > Reviewed-by: Rob Herring <robh@kernel.org> > > > > --- > > > > v7: > > - Collect Rob's RB tag > > - Remove redundant maxItems from remote-endpoints > > - Fix SPDX licence tag > > > > .../bindings/media/i2c/maxim,max9286.yaml | 287 ++++++++++++++++++ > > 1 file changed, 287 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml > > new file mode 100644 > > index 000000000000..f9d3e5712c59 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml > > @@ -0,0 +1,287 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +# Copyright (C) 2019 Renesas Electronics Corp. > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/media/i2c/maxim,max9286.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Maxim Integrated Quad GMSL Deserializer > > + > > +maintainers: > > + - Jacopo Mondi <jacopo+renesas@jmondi.org> > > + - Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > + - Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > + - Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > + > > +description: | > > + The MAX9286 deserializer receives video data on up to 4 Gigabit Multimedia > > + Serial Links (GMSL) and outputs them on a CSI-2 D-PHY port using up to 4 data > > + lanes. > > + > > + In addition to video data, the GMSL links carry a bidirectional control > > + channel that encapsulates I2C messages. The MAX9286 forwards all I2C traffic > > + not addressed to itself to the other side of the links, where a GMSL > > + serializer will output it on a local I2C bus. In the other direction all I2C > > + traffic received over GMSL by the MAX9286 is output on the local I2C bus. > > + > > +properties: > > + '#address-cells': > > + const: 1 > > + > > + '#size-cells': > > + const: 0 > > + > > + compatible: > > + const: maxim,max9286 > > + > > + reg: > > + description: I2C device address > > + maxItems: 1 > > + > > + poc-supply: > > + description: Regulator providing Power over Coax to the cameras > > + maxItems: 1 > > + > > + enable-gpios: > > + description: GPIO connected to the \#PWDN pin with inverted polarity > > + maxItems: 1 > > + > > + ports: > > + type: object > > + description: | > > + The connections to the MAX9286 GMSL and its endpoint nodes are modelled > > + using the OF graph bindings in accordance with the video interface > > + bindings defined in > > + Documentation/devicetree/bindings/media/video-interfaces.txt. > > + > > + The following table lists the port number corresponding to each device > > + port. > > + > > + Port Description > > + ---------------------------------------- > > + Port 0 GMSL Input 0 > > + Port 1 GMSL Input 1 > > + Port 2 GMSL Input 2 > > + Port 3 GMSL Input 3 > > + Port 4 CSI-2 Output > > + > > + properties: > > + '#address-cells': > > + const: 1 > > + > > + '#size-cells': > > + const: 0 > > + > > + port@[0-3]: > > + type: object > > + properties: > > + reg: > > + enum: [ 0, 1, 2, 3 ] > > + > > + endpoint: > > + type: object > > + > > + properties: > > + remote-endpoint: > > + description: | > > + phandle to the remote GMSL source endpoint subnode in the > > + remote node port. > > + > > + required: > > + - remote-endpoint > > + > > + required: > > + - reg > > + - endpoint > > + > > + additionalProperties: false > > + > > + port@4: > > + type: object > > + properties: > > + reg: > > + const: 4 > > + > > + endpoint: > > + type: object > > + > > + properties: > > + remote-endpoint: > > + description: phandle to the remote CSI-2 sink endpoint. > > + > > + data-lanes: > > + description: array of physical CSI-2 data lane indexes. > > + > > + required: > > + - remote-endpoint > > + - data-lanes > > + > > + required: > > + - reg > > + - endpoint > > + > > + additionalProperties: false > > + > > + required: > > + - port@4 > > + > > + i2c-mux: > > + type: object > > + description: | > > + Each GMSL link is modelled as a child bus of an i2c bus > > + multiplexer/switch, in accordance with bindings described in > > + Documentation/devicetree/bindings/i2c/i2c-mux.txt. The serializer > > + device on the remote end of the GMSL link shall be modelled as a child > > + node of the corresponding I2C bus. > > + > > + properties: > > + '#address-cells': > > + const: 1 > > + > > + '#size-cells': > > + const: 0 > > + > > + additionalProperties: false > > Wrong indentation. Should be 2 more or this is a DT property. > Thanks, updating the dt tools helped spotting the error locally as well. This fixes the error reported in the previous email, now I get a Documentation/devicetree/bindings/media/i2c/maxim,max9286.example.dt.yaml: gmsl-deserializer@2c: i2c-mux: 'i2c@0', 'i2c@1', 'i2c@2', 'i2c@3' do not match any of the regexes: 'pinctrl-[0-9]+' which makes me think the i2c-mux child nodes are under-specified in this bindings. I have expanded them and will reply with a fixup to be applied on top of this patch to ease review and eventually include in v10. Thanks j > > + > > +required: > > + - compatible > > + - reg > > + - ports > > + - i2c-mux > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/gpio/gpio.h> > > + > > + i2c@e66d8000 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + reg = <0 0xe66d8000 0 0x40>; > > + > > + gmsl-deserializer@2c { > > + compatible = "maxim,max9286"; > > + reg = <0x2c>; > > + poc-supply = <&camera_poc_12v>; > > + enable-gpios = <&gpio 13 GPIO_ACTIVE_HIGH>; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + > > + max9286_in0: endpoint { > > + remote-endpoint = <&rdacm20_out0>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <1>; > > + > > + max9286_in1: endpoint { > > + remote-endpoint = <&rdacm20_out1>; > > + }; > > + }; > > + > > + port@2 { > > + reg = <2>; > > + > > + max9286_in2: endpoint { > > + remote-endpoint = <&rdacm20_out2>; > > + }; > > + }; > > + > > + port@3 { > > + reg = <3>; > > + > > + max9286_in3: endpoint { > > + remote-endpoint = <&rdacm20_out3>; > > + }; > > + }; > > + > > + port@4 { > > + reg = <4>; > > + > > + max9286_out: endpoint { > > + data-lanes = <1 2 3 4>; > > + remote-endpoint = <&csi40_in>; > > + }; > > + }; > > + }; > > + > > + i2c-mux { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + i2c@0 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + reg = <0>; > > + > > + camera@51 { > > + reg = <0x51>; > > + > > + port { > > + rdacm20_out0: endpoint { > > + remote-endpoint = <&max9286_in0>; > > + }; > > + }; > > + > > + }; > > + }; > > + > > + i2c@1 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + reg = <1>; > > + > > + camera@52 { > > + reg = <0x52>; > > + > > + port { > > + rdacm20_out1: endpoint { > > + remote-endpoint = <&max9286_in1>; > > + }; > > + }; > > + }; > > + }; > > + > > + i2c@2 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + reg = <2>; > > + > > + camera@53 { > > + reg = <0x53>; > > + > > + port { > > + rdacm20_out2: endpoint { > > + remote-endpoint = <&max9286_in2>; > > + }; > > + }; > > + }; > > + }; > > + > > + i2c@3 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + reg = <3>; > > + > > + camera@54 { > > + reg = <0x54>; > > + > > + port { > > + rdacm20_out3: endpoint { > > + remote-endpoint = <&max9286_in3>; > > + }; > > + }; > > + }; > > + }; > > + }; > > + }; > > + }; > > -- > > 2.25.1 > >
diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml new file mode 100644 index 000000000000..f9d3e5712c59 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml @@ -0,0 +1,287 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (C) 2019 Renesas Electronics Corp. +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/maxim,max9286.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Maxim Integrated Quad GMSL Deserializer + +maintainers: + - Jacopo Mondi <jacopo+renesas@jmondi.org> + - Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> + - Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> + - Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> + +description: | + The MAX9286 deserializer receives video data on up to 4 Gigabit Multimedia + Serial Links (GMSL) and outputs them on a CSI-2 D-PHY port using up to 4 data + lanes. + + In addition to video data, the GMSL links carry a bidirectional control + channel that encapsulates I2C messages. The MAX9286 forwards all I2C traffic + not addressed to itself to the other side of the links, where a GMSL + serializer will output it on a local I2C bus. In the other direction all I2C + traffic received over GMSL by the MAX9286 is output on the local I2C bus. + +properties: + '#address-cells': + const: 1 + + '#size-cells': + const: 0 + + compatible: + const: maxim,max9286 + + reg: + description: I2C device address + maxItems: 1 + + poc-supply: + description: Regulator providing Power over Coax to the cameras + maxItems: 1 + + enable-gpios: + description: GPIO connected to the \#PWDN pin with inverted polarity + maxItems: 1 + + ports: + type: object + description: | + The connections to the MAX9286 GMSL and its endpoint nodes are modelled + using the OF graph bindings in accordance with the video interface + bindings defined in + Documentation/devicetree/bindings/media/video-interfaces.txt. + + The following table lists the port number corresponding to each device + port. + + Port Description + ---------------------------------------- + Port 0 GMSL Input 0 + Port 1 GMSL Input 1 + Port 2 GMSL Input 2 + Port 3 GMSL Input 3 + Port 4 CSI-2 Output + + properties: + '#address-cells': + const: 1 + + '#size-cells': + const: 0 + + port@[0-3]: + type: object + properties: + reg: + enum: [ 0, 1, 2, 3 ] + + endpoint: + type: object + + properties: + remote-endpoint: + description: | + phandle to the remote GMSL source endpoint subnode in the + remote node port. + + required: + - remote-endpoint + + required: + - reg + - endpoint + + additionalProperties: false + + port@4: + type: object + properties: + reg: + const: 4 + + endpoint: + type: object + + properties: + remote-endpoint: + description: phandle to the remote CSI-2 sink endpoint. + + data-lanes: + description: array of physical CSI-2 data lane indexes. + + required: + - remote-endpoint + - data-lanes + + required: + - reg + - endpoint + + additionalProperties: false + + required: + - port@4 + + i2c-mux: + type: object + description: | + Each GMSL link is modelled as a child bus of an i2c bus + multiplexer/switch, in accordance with bindings described in + Documentation/devicetree/bindings/i2c/i2c-mux.txt. The serializer + device on the remote end of the GMSL link shall be modelled as a child + node of the corresponding I2C bus. + + properties: + '#address-cells': + const: 1 + + '#size-cells': + const: 0 + + additionalProperties: false + +required: + - compatible + - reg + - ports + - i2c-mux + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + i2c@e66d8000 { + #address-cells = <1>; + #size-cells = <0>; + + reg = <0 0xe66d8000 0 0x40>; + + gmsl-deserializer@2c { + compatible = "maxim,max9286"; + reg = <0x2c>; + poc-supply = <&camera_poc_12v>; + enable-gpios = <&gpio 13 GPIO_ACTIVE_HIGH>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + max9286_in0: endpoint { + remote-endpoint = <&rdacm20_out0>; + }; + }; + + port@1 { + reg = <1>; + + max9286_in1: endpoint { + remote-endpoint = <&rdacm20_out1>; + }; + }; + + port@2 { + reg = <2>; + + max9286_in2: endpoint { + remote-endpoint = <&rdacm20_out2>; + }; + }; + + port@3 { + reg = <3>; + + max9286_in3: endpoint { + remote-endpoint = <&rdacm20_out3>; + }; + }; + + port@4 { + reg = <4>; + + max9286_out: endpoint { + data-lanes = <1 2 3 4>; + remote-endpoint = <&csi40_in>; + }; + }; + }; + + i2c-mux { + #address-cells = <1>; + #size-cells = <0>; + + i2c@0 { + #address-cells = <1>; + #size-cells = <0>; + + reg = <0>; + + camera@51 { + reg = <0x51>; + + port { + rdacm20_out0: endpoint { + remote-endpoint = <&max9286_in0>; + }; + }; + + }; + }; + + i2c@1 { + #address-cells = <1>; + #size-cells = <0>; + reg = <1>; + + camera@52 { + reg = <0x52>; + + port { + rdacm20_out1: endpoint { + remote-endpoint = <&max9286_in1>; + }; + }; + }; + }; + + i2c@2 { + #address-cells = <1>; + #size-cells = <0>; + reg = <2>; + + camera@53 { + reg = <0x53>; + + port { + rdacm20_out2: endpoint { + remote-endpoint = <&max9286_in2>; + }; + }; + }; + }; + + i2c@3 { + #address-cells = <1>; + #size-cells = <0>; + reg = <3>; + + camera@54 { + reg = <0x54>; + + port { + rdacm20_out3: endpoint { + remote-endpoint = <&max9286_in3>; + }; + }; + }; + }; + }; + }; + };