| Message ID | 20200511120332.26029-1-plautrba@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | run-flake8: Filter out ./.git/ directory | expand |
On Mon, May 11, 2020 at 2:03 PM Petr Lautrbach <plautrba@redhat.com> wrote: > > When a branch has '.py' suffix git creates a file with the same suffix and this > file is found by the `find . -name '*.py'` command. Such files from './git' need > to be filtered out. > > Fixes: > > $ PATH="$VIRTUAL_ENV/bin:$PATH" ./scripts/run-flake8 > Analyzing 189 Python scripts > ./.git/logs/refs/heads/semanage-test.py:1:42: E999 SyntaxError: invalid syntax > ./.git/refs/heads/semanage-test.py:1:4: E999 SyntaxError: invalid syntax > The command "PATH="$VIRTUAL_ENV/bin:$PATH" ./scripts/run-flake8" exited with 1. > > Signed-off-by: Petr Lautrbach <plautrba@redhat.com> Acked-by: Nicolas Iooss <nicolas.iooss@m4x.org> Thanks! Nicolas > --- > scripts/run-flake8 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/run-flake8 b/scripts/run-flake8 > index 24b1202fde99..67cccfe99e5f 100755 > --- a/scripts/run-flake8 > +++ b/scripts/run-flake8 > @@ -7,7 +7,7 @@ if [ $# -eq 0 ] ; then > > # Run on both files ending with .py and Python files without extension > # shellcheck disable=SC2046 > - set -- $( (find . -name '*.py' ; grep --exclude-dir=.git -l -e '^#!\s*/usr/bin/python' -e '^#!/usr/bin/env python' -r .) | sort -u ) > + set -- $( (find . -name '*.py' ; grep -l -e '^#!\s*/usr/bin/python' -e '^#!/usr/bin/env python' -r .) | grep -v '^\./\.git/' | sort -u ) > echo "Analyzing $# Python scripts" > fi > > -- > 2.26.2 >
On Mon, May 11, 2020 at 02:03:32PM +0200, Petr Lautrbach wrote: > When a branch has '.py' suffix git creates a file with the same suffix and this > file is found by the `find . -name '*.py'` command. Such files from './git' need > to be filtered out. > > Fixes: > > $ PATH="$VIRTUAL_ENV/bin:$PATH" ./scripts/run-flake8 > Analyzing 189 Python scripts > ./.git/logs/refs/heads/semanage-test.py:1:42: E999 SyntaxError: invalid syntax > ./.git/refs/heads/semanage-test.py:1:4: E999 SyntaxError: invalid syntax > The command "PATH="$VIRTUAL_ENV/bin:$PATH" ./scripts/run-flake8" exited with 1. > > Signed-off-by: Petr Lautrbach <plautrba@redhat.com> > Acked-by: Nicolas Iooss <nicolas.iooss@m4x.org> Applied. > --- > scripts/run-flake8 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/run-flake8 b/scripts/run-flake8 > index 24b1202fde99..67cccfe99e5f 100755 > --- a/scripts/run-flake8 > +++ b/scripts/run-flake8 > @@ -7,7 +7,7 @@ if [ $# -eq 0 ] ; then > > # Run on both files ending with .py and Python files without extension > # shellcheck disable=SC2046 > - set -- $( (find . -name '*.py' ; grep --exclude-dir=.git -l -e '^#!\s*/usr/bin/python' -e '^#!/usr/bin/env python' -r .) | sort -u ) > + set -- $( (find . -name '*.py' ; grep -l -e '^#!\s*/usr/bin/python' -e '^#!/usr/bin/env python' -r .) | grep -v '^\./\.git/' | sort -u ) > echo "Analyzing $# Python scripts" > fi >
On Wed, May 13, 2020 at 10:11 AM Petr Lautrbach <plautrba@redhat.com> wrote: > > On Mon, May 11, 2020 at 02:03:32PM +0200, Petr Lautrbach wrote: > > When a branch has '.py' suffix git creates a file with the same suffix and this > > file is found by the `find . -name '*.py'` command. Such files from './git' need > > to be filtered out. > > > > Fixes: > > > > $ PATH="$VIRTUAL_ENV/bin:$PATH" ./scripts/run-flake8 > > Analyzing 189 Python scripts > > ./.git/logs/refs/heads/semanage-test.py:1:42: E999 SyntaxError: invalid syntax > > ./.git/refs/heads/semanage-test.py:1:4: E999 SyntaxError: invalid syntax > > The command "PATH="$VIRTUAL_ENV/bin:$PATH" ./scripts/run-flake8" exited with 1. > > > > Signed-off-by: Petr Lautrbach <plautrba@redhat.com> > > Acked-by: Nicolas Iooss <nicolas.iooss@m4x.org> > > Applied. I updated the state to accepted in Patchwork > > > --- > > scripts/run-flake8 | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/scripts/run-flake8 b/scripts/run-flake8 > > index 24b1202fde99..67cccfe99e5f 100755 > > --- a/scripts/run-flake8 > > +++ b/scripts/run-flake8 > > @@ -7,7 +7,7 @@ if [ $# -eq 0 ] ; then > > > > # Run on both files ending with .py and Python files without extension > > # shellcheck disable=SC2046 > > - set -- $( (find . -name '*.py' ; grep --exclude-dir=.git -l -e '^#!\s*/usr/bin/python' -e '^#!/usr/bin/env python' -r .) | sort -u ) > > + set -- $( (find . -name '*.py' ; grep -l -e '^#!\s*/usr/bin/python' -e '^#!/usr/bin/env python' -r .) | grep -v '^\./\.git/' | sort -u ) > > echo "Analyzing $# Python scripts" > > fi > > > > -- > () ascii ribbon campaign - against html e-mail > /\ www.asciiribbon.org - against proprietary attachments
diff --git a/scripts/run-flake8 b/scripts/run-flake8 index 24b1202fde99..67cccfe99e5f 100755 --- a/scripts/run-flake8 +++ b/scripts/run-flake8 @@ -7,7 +7,7 @@ if [ $# -eq 0 ] ; then # Run on both files ending with .py and Python files without extension # shellcheck disable=SC2046 - set -- $( (find . -name '*.py' ; grep --exclude-dir=.git -l -e '^#!\s*/usr/bin/python' -e '^#!/usr/bin/env python' -r .) | sort -u ) + set -- $( (find . -name '*.py' ; grep -l -e '^#!\s*/usr/bin/python' -e '^#!/usr/bin/env python' -r .) | grep -v '^\./\.git/' | sort -u ) echo "Analyzing $# Python scripts" fi
When a branch has '.py' suffix git creates a file with the same suffix and this file is found by the `find . -name '*.py'` command. Such files from './git' need to be filtered out. Fixes: $ PATH="$VIRTUAL_ENV/bin:$PATH" ./scripts/run-flake8 Analyzing 189 Python scripts ./.git/logs/refs/heads/semanage-test.py:1:42: E999 SyntaxError: invalid syntax ./.git/refs/heads/semanage-test.py:1:4: E999 SyntaxError: invalid syntax The command "PATH="$VIRTUAL_ENV/bin:$PATH" ./scripts/run-flake8" exited with 1. Signed-off-by: Petr Lautrbach <plautrba@redhat.com> --- scripts/run-flake8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)