Message ID | 1589346671-15226-4-git-send-email-aneela@codeaurora.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | Add TIOCM Signals support for RPMSG char devices | expand |
Hi Arun, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on linux/master v5.7-rc5 next-20200512] [cannot apply to rpmsg/for-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Arun-Kumar-Neelakantam/Add-TIOCM-Signals-support-for-RPMSG-char-devices/20200513-134544 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 24085f70a6e1b0cb647ec92623284641d8270637 config: alpha-randconfig-r012-20200513 (attached as .config) compiler: alpha-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=alpha If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <lkp@intel.com> All warnings (new ones prefixed by >>): drivers/rpmsg/rpmsg_char.c: In function 'rpmsg_eptdev_ioctl': >> drivers/rpmsg/rpmsg_char.c:322:9: warning: this statement may fall through [-Wimplicit-fallthrough=] 322 | ret = rpmsg_eptdev_destroy(&eptdev->dev, NULL); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/rpmsg/rpmsg_char.c:323:2: note: here 323 | default: | ^~~~~~~ vim +322 drivers/rpmsg/rpmsg_char.c 303 304 static long rpmsg_eptdev_ioctl(struct file *fp, unsigned int cmd, 305 unsigned long arg) 306 { 307 struct rpmsg_eptdev *eptdev = fp->private_data; 308 int ret; 309 310 switch (cmd) { 311 case TIOCMGET: 312 ret = rpmsg_get_signals(eptdev->ept); 313 if (ret >= 0) 314 ret = put_user(ret, (int __user *)arg); 315 break; 316 case TIOCMSET: 317 case TIOCMBIS: 318 case TIOCMBIC: 319 ret = rpmsg_eptdev_tiocmset(fp, cmd, (int __user *)arg); 320 break; 321 case RPMSG_DESTROY_EPT_IOCTL: > 322 ret = rpmsg_eptdev_destroy(&eptdev->dev, NULL); 323 default: 324 ret = -EINVAL; 325 } 326 327 return ret; 328 } 329 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
On Wed, May 13, 2020 at 10:41:10AM +0530, Arun Kumar Neelakantam wrote: > Add TICOMGET and TIOCMSET ioctl support for rpmsg char device nodes s/TICOMGET/TIOCMGET > to get/set the low level transport signals. > > Signed-off-by: Arun Kumar Neelakantam <aneela@codeaurora.org> > --- > drivers/rpmsg/rpmsg_char.c | 53 +++++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 50 insertions(+), 3 deletions(-) > > diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c > index 4bbbacd..e2f92f3 100644 > --- a/drivers/rpmsg/rpmsg_char.c > +++ b/drivers/rpmsg/rpmsg_char.c > @@ -1,5 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > + * Copyright (c) 2018, The Linux Foundation. > * Copyright (c) 2016, Linaro Ltd. > * Copyright (c) 2012, Michal Simek <monstr@monstr.eu> > * Copyright (c) 2012, PetaLogix > @@ -19,6 +20,7 @@ > #include <linux/rpmsg.h> > #include <linux/skbuff.h> > #include <linux/slab.h> > +#include <linux/termios.h> > #include <linux/uaccess.h> > #include <uapi/linux/rpmsg.h> > > @@ -269,15 +271,60 @@ static __poll_t rpmsg_eptdev_poll(struct file *filp, poll_table *wait) > return mask; > } > > +static int rpmsg_eptdev_tiocmset(struct file *fp, unsigned int cmd, > + int __user *arg) > +{ > + struct rpmsg_eptdev *eptdev = fp->private_data; > + u32 set, clear, val; > + int ret; > + > + ret = get_user(val, arg); > + if (ret) > + return ret; > + set = clear = 0; > + switch (cmd) { > + case TIOCMBIS: > + set = val; > + break; > + case TIOCMBIC: > + clear = val; > + break; > + case TIOCMSET: > + set = val; > + clear = ~val; > + break; > + } > + > + set &= TIOCM_DTR | TIOCM_RTS | TIOCM_CD | TIOCM_RI; > + clear &= TIOCM_DTR | TIOCM_RTS | TIOCM_CD | TIOCM_RI; > + > + return rpmsg_set_signals(eptdev->ept, set, clear); > +} > + > static long rpmsg_eptdev_ioctl(struct file *fp, unsigned int cmd, > unsigned long arg) > { > struct rpmsg_eptdev *eptdev = fp->private_data; > + int ret; > > - if (cmd != RPMSG_DESTROY_EPT_IOCTL) > - return -EINVAL; > + switch (cmd) { > + case TIOCMGET: > + ret = rpmsg_get_signals(eptdev->ept); > + if (ret >= 0) > + ret = put_user(ret, (int __user *)arg); > + break; > + case TIOCMSET: > + case TIOCMBIS: > + case TIOCMBIC: > + ret = rpmsg_eptdev_tiocmset(fp, cmd, (int __user *)arg); > + break; > + case RPMSG_DESTROY_EPT_IOCTL: > + ret = rpmsg_eptdev_destroy(&eptdev->dev, NULL); > + default: > + ret = -EINVAL; > + } > > - return rpmsg_eptdev_destroy(&eptdev->dev, NULL); > + return ret; > } > > static const struct file_operations rpmsg_eptdev_fops = { > -- > 2.7.4
diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c index 4bbbacd..e2f92f3 100644 --- a/drivers/rpmsg/rpmsg_char.c +++ b/drivers/rpmsg/rpmsg_char.c @@ -1,5 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 /* + * Copyright (c) 2018, The Linux Foundation. * Copyright (c) 2016, Linaro Ltd. * Copyright (c) 2012, Michal Simek <monstr@monstr.eu> * Copyright (c) 2012, PetaLogix @@ -19,6 +20,7 @@ #include <linux/rpmsg.h> #include <linux/skbuff.h> #include <linux/slab.h> +#include <linux/termios.h> #include <linux/uaccess.h> #include <uapi/linux/rpmsg.h> @@ -269,15 +271,60 @@ static __poll_t rpmsg_eptdev_poll(struct file *filp, poll_table *wait) return mask; } +static int rpmsg_eptdev_tiocmset(struct file *fp, unsigned int cmd, + int __user *arg) +{ + struct rpmsg_eptdev *eptdev = fp->private_data; + u32 set, clear, val; + int ret; + + ret = get_user(val, arg); + if (ret) + return ret; + set = clear = 0; + switch (cmd) { + case TIOCMBIS: + set = val; + break; + case TIOCMBIC: + clear = val; + break; + case TIOCMSET: + set = val; + clear = ~val; + break; + } + + set &= TIOCM_DTR | TIOCM_RTS | TIOCM_CD | TIOCM_RI; + clear &= TIOCM_DTR | TIOCM_RTS | TIOCM_CD | TIOCM_RI; + + return rpmsg_set_signals(eptdev->ept, set, clear); +} + static long rpmsg_eptdev_ioctl(struct file *fp, unsigned int cmd, unsigned long arg) { struct rpmsg_eptdev *eptdev = fp->private_data; + int ret; - if (cmd != RPMSG_DESTROY_EPT_IOCTL) - return -EINVAL; + switch (cmd) { + case TIOCMGET: + ret = rpmsg_get_signals(eptdev->ept); + if (ret >= 0) + ret = put_user(ret, (int __user *)arg); + break; + case TIOCMSET: + case TIOCMBIS: + case TIOCMBIC: + ret = rpmsg_eptdev_tiocmset(fp, cmd, (int __user *)arg); + break; + case RPMSG_DESTROY_EPT_IOCTL: + ret = rpmsg_eptdev_destroy(&eptdev->dev, NULL); + default: + ret = -EINVAL; + } - return rpmsg_eptdev_destroy(&eptdev->dev, NULL); + return ret; } static const struct file_operations rpmsg_eptdev_fops = {
Add TICOMGET and TIOCMSET ioctl support for rpmsg char device nodes to get/set the low level transport signals. Signed-off-by: Arun Kumar Neelakantam <aneela@codeaurora.org> --- drivers/rpmsg/rpmsg_char.c | 53 +++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 50 insertions(+), 3 deletions(-)