[0/5] Remove/convert more kmem_* wrappers

Message

Carlos Maiolino Nov. 20, 2019, 10:44 a.m. UTC

Hi,

in this new series, we remove most of the remaining kmem_* wrappers.

All of the wrappers being removed in this series can be directly replaced by
generic kernel kmalloc()/kzalloc() interface.

Only interface kept is kmem_alloc() but has been converted into a local helper.

This series should be applied on top of my previous series aiming to clean up
our memory allocation interface.


Darrick, I believe this is slightly different from what you suggested
previously, about converting kmem_* interfaces to use GFP flags directly. At
least I read that as keeping current kmem_* interface, and getting rid of KM_*
flags now.

But, I believe these patches does not change any allocation logic, and after the
series we are left with fewer users of KM_* flags users to get rid of, which
IMHO will be easier. And also I already had the patches mostly done :)

Let me know if this is ok for you.


Carlos Maiolino (5):
  xfs: remove kmem_zone_zalloc()
  xfs: Remove kmem_zone_alloc() wrapper
  xfs: remove kmem_zalloc() wrapper
  xfs: Remove kmem_realloc
  xfs: Convert kmem_alloc() users

 fs/xfs/kmem.c                      | 51 +++---------------------------
 fs/xfs/kmem.h                      | 16 ----------
 fs/xfs/libxfs/xfs_alloc.c          |  3 +-
 fs/xfs/libxfs/xfs_alloc_btree.c    |  2 +-
 fs/xfs/libxfs/xfs_attr_leaf.c      |  9 +++---
 fs/xfs/libxfs/xfs_bmap.c           |  8 +++--
 fs/xfs/libxfs/xfs_bmap_btree.c     |  2 +-
 fs/xfs/libxfs/xfs_da_btree.c       | 16 +++++-----
 fs/xfs/libxfs/xfs_defer.c          |  4 +--
 fs/xfs/libxfs/xfs_dir2.c           | 29 ++++++++---------
 fs/xfs/libxfs/xfs_dir2_block.c     |  2 +-
 fs/xfs/libxfs/xfs_dir2_sf.c        |  8 ++---
 fs/xfs/libxfs/xfs_ialloc_btree.c   |  2 +-
 fs/xfs/libxfs/xfs_iext_tree.c      | 14 +++++---
 fs/xfs/libxfs/xfs_inode_fork.c     | 26 ++++++++-------
 fs/xfs/libxfs/xfs_refcount.c       |  9 +++---
 fs/xfs/libxfs/xfs_refcount_btree.c |  2 +-
 fs/xfs/libxfs/xfs_rmap.c           |  2 +-
 fs/xfs/libxfs/xfs_rmap_btree.c     |  2 +-
 fs/xfs/scrub/agheader.c            |  4 +--
 fs/xfs/scrub/bitmap.c              |  7 ++--
 fs/xfs/scrub/btree.c               |  4 +--
 fs/xfs/scrub/fscounters.c          |  3 +-
 fs/xfs/scrub/refcount.c            |  4 +--
 fs/xfs/xfs_attr_inactive.c         |  2 +-
 fs/xfs/xfs_attr_list.c             |  2 +-
 fs/xfs/xfs_bmap_item.c             |  4 +--
 fs/xfs/xfs_buf.c                   | 13 ++++----
 fs/xfs/xfs_buf_item.c              |  6 ++--
 fs/xfs/xfs_dquot.c                 |  2 +-
 fs/xfs/xfs_dquot_item.c            |  3 +-
 fs/xfs/xfs_error.c                 |  4 +--
 fs/xfs/xfs_extent_busy.c           |  3 +-
 fs/xfs/xfs_extfree_item.c          | 12 ++++---
 fs/xfs/xfs_filestream.c            |  2 +-
 fs/xfs/xfs_icache.c                |  2 +-
 fs/xfs/xfs_icreate_item.c          |  2 +-
 fs/xfs/xfs_inode.c                 |  4 +--
 fs/xfs/xfs_inode_item.c            |  3 +-
 fs/xfs/xfs_itable.c                |  8 ++---
 fs/xfs/xfs_iwalk.c                 |  5 +--
 fs/xfs/xfs_log.c                   | 12 ++++---
 fs/xfs/xfs_log_cil.c               |  8 ++---
 fs/xfs/xfs_log_priv.h              |  2 +-
 fs/xfs/xfs_log_recover.c           | 21 ++++++------
 fs/xfs/xfs_mount.c                 |  7 ++--
 fs/xfs/xfs_mru_cache.c             |  5 +--
 fs/xfs/xfs_qm.c                    |  6 ++--
 fs/xfs/xfs_refcount_item.c         |  9 +++---
 fs/xfs/xfs_rmap_item.c             |  8 +++--
 fs/xfs/xfs_rtalloc.c               |  2 +-
 fs/xfs/xfs_super.c                 |  2 +-
 fs/xfs/xfs_trace.h                 |  1 -
 fs/xfs/xfs_trans.c                 |  4 +--
 fs/xfs/xfs_trans_ail.c             |  3 +-
 fs/xfs/xfs_trans_dquot.c           |  3 +-
 56 files changed, 185 insertions(+), 214 deletions(-)

Comments

Dave Chinner May 14, 2020, 9:26 a.m. UTC | #1

On Wed, Nov 20, 2019 at 11:44:20AM +0100, Carlos Maiolino wrote:
> Hi,
> 
> in this new series, we remove most of the remaining kmem_* wrappers.
> 
> All of the wrappers being removed in this series can be directly replaced by
> generic kernel kmalloc()/kzalloc() interface.
> 
> Only interface kept is kmem_alloc() but has been converted into a local helper.
> 
> This series should be applied on top of my previous series aiming to clean up
> our memory allocation interface.
> 
> 
> Darrick, I believe this is slightly different from what you suggested
> previously, about converting kmem_* interfaces to use GFP flags directly. At
> least I read that as keeping current kmem_* interface, and getting rid of KM_*
> flags now.
> 
> But, I believe these patches does not change any allocation logic, and after the
> series we are left with fewer users of KM_* flags users to get rid of, which
> IMHO will be easier. And also I already had the patches mostly done :)
> 
> Let me know if this is ok for you.
> 
> 
> Carlos Maiolino (5):
>   xfs: remove kmem_zone_zalloc()
>   xfs: Remove kmem_zone_alloc() wrapper
>   xfs: remove kmem_zalloc() wrapper
>   xfs: Remove kmem_realloc
>   xfs: Convert kmem_alloc() users

Hmmm, just noticed that this never got merged. Whatever happened to
this patchset?

Cheers,

Dave.