| Message ID | 20200507233846.11548-3-Sergey.Semin@baikalelectronics.ru (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | syscon: Alter syscon and reboot drivers | expand |
On Fri, 8 May 2020 02:38:45 +0300, Serge Semin wrote: > Since normally syscon-reboot block is supposed to be a part of a system > controller, lets mark the regmap property as deprecated and recommend the > syscon-reboot node to be a sub-node of SYSCON. > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru> > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > Cc: Paul Burton <paulburton@kernel.org> > Cc: Ralf Baechle <ralf@linux-mips.org> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Allison Randal <allison@lohutok.net> > Cc: Richard Fontana <rfontana@redhat.com> > Cc: Kate Stewart <kstewart@linuxfoundation.org> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: linux-mips@vger.kernel.org > > --- > > Changelog v2: > - This is a new patch created as a result of the discussion: > https://lore.kernel.org/linux-pm/20200306130402.1F4F0803079F@mail.baikalelectronics.ru/ > --- > .../bindings/power/reset/syscon-reboot.yaml | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On Thu, May 14, 2020 at 10:14:49PM -0500, Rob Herring wrote: > On Fri, 8 May 2020 02:38:45 +0300, Serge Semin wrote: > > Since normally syscon-reboot block is supposed to be a part of a system > > controller, lets mark the regmap property as deprecated and recommend the > > syscon-reboot node to be a sub-node of SYSCON. > > > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru> > > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > > Cc: Paul Burton <paulburton@kernel.org> > > Cc: Ralf Baechle <ralf@linux-mips.org> > > Cc: Arnd Bergmann <arnd@arndb.de> > > Cc: Allison Randal <allison@lohutok.net> > > Cc: Richard Fontana <rfontana@redhat.com> > > Cc: Kate Stewart <kstewart@linuxfoundation.org> > > Cc: Thomas Gleixner <tglx@linutronix.de> > > Cc: linux-mips@vger.kernel.org > > > > --- > > > > Changelog v2: > > - This is a new patch created as a result of the discussion: > > https://lore.kernel.org/linux-pm/20200306130402.1F4F0803079F@mail.baikalelectronics.ru/ > > --- > > .../bindings/power/reset/syscon-reboot.yaml | 15 ++++++++++----- > > 1 file changed, 10 insertions(+), 5 deletions(-) > > > > Reviewed-by: Rob Herring <robh@kernel.org> Great. Thanks! Sebastian, Rob is ok with the change. Could you take a look at the next patch? -Sergey
diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml index b80772cb9f06..da2509724812 100644 --- a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml +++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml @@ -12,9 +12,12 @@ maintainers: description: |+ This is a generic reset driver using syscon to map the reset register. The reset is generally performed with a write to the reset register - defined by the register map pointed by syscon reference plus the offset - with the value and mask defined in the reboot node. - Default will be little endian mode, 32 bit access only. + defined by the SYSCON register map base plus the offset with the value and + mask defined in the reboot node. Default will be little endian mode, 32 bit + access only. The SYSCON registers map is normally retrieved from the + parental dt-node. So the SYSCON reboot node should be represented as a + sub-node of a "syscon", "simple-mfd" node. Though the regmap property + pointing to the system controller node is also supported. properties: compatible: @@ -30,7 +33,10 @@ properties: regmap: $ref: /schemas/types.yaml#/definitions/phandle - description: Phandle to the register map node. + deprecated: true + description: | + Phandle to the register map node. This property is deprecated in favor of + the syscon-reboot node been a child of a system controller node. value: $ref: /schemas/types.yaml#/definitions/uint32 @@ -38,7 +44,6 @@ properties: required: - compatible - - regmap - offset additionalProperties: false
Since normally syscon-reboot block is supposed to be a part of a system controller, lets mark the regmap property as deprecated and recommend the syscon-reboot node to be a sub-node of SYSCON. Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Cc: Paul Burton <paulburton@kernel.org> Cc: Ralf Baechle <ralf@linux-mips.org> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Allison Randal <allison@lohutok.net> Cc: Richard Fontana <rfontana@redhat.com> Cc: Kate Stewart <kstewart@linuxfoundation.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: linux-mips@vger.kernel.org --- Changelog v2: - This is a new patch created as a result of the discussion: https://lore.kernel.org/linux-pm/20200306130402.1F4F0803079F@mail.baikalelectronics.ru/ --- .../bindings/power/reset/syscon-reboot.yaml | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)