| Message ID | 20200506094948.76388-7-david@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | virtio-mem: Paravirtualized memory hot(un)plug | expand |
* David Hildenbrand (david@redhat.com) wrote: > AMD SEV will pin all guest memory, mark discarding of RAM broken. At the > time this is called, we cannot have anyone active that relies on discards > to work properly. Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > > Cc: "Michael S. Tsirkin" <mst@redhat.com> > Cc: Paolo Bonzini <pbonzini@redhat.com> > Cc: Richard Henderson <rth@twiddle.net> > Cc: Eduardo Habkost <ehabkost@redhat.com> > Signed-off-by: David Hildenbrand <david@redhat.com> > --- > target/i386/sev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/i386/sev.c b/target/i386/sev.c > index 846018a12d..608225f9ba 100644 > --- a/target/i386/sev.c > +++ b/target/i386/sev.c > @@ -722,6 +722,7 @@ sev_guest_init(const char *id) > ram_block_notifier_add(&sev_ram_notifier); > qemu_add_machine_init_done_notifier(&sev_machine_done_notify); > qemu_add_vm_change_state_handler(sev_vm_state_change, s); > + g_assert(!ram_block_discard_set_broken(true)); > > return s; > err: > -- > 2.25.3 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
diff --git a/target/i386/sev.c b/target/i386/sev.c index 846018a12d..608225f9ba 100644 --- a/target/i386/sev.c +++ b/target/i386/sev.c @@ -722,6 +722,7 @@ sev_guest_init(const char *id) ram_block_notifier_add(&sev_ram_notifier); qemu_add_machine_init_done_notifier(&sev_machine_done_notify); qemu_add_vm_change_state_handler(sev_vm_state_change, s); + g_assert(!ram_block_discard_set_broken(true)); return s; err:
AMD SEV will pin all guest memory, mark discarding of RAM broken. At the time this is called, we cannot have anyone active that relies on discards to work properly. Cc: "Michael S. Tsirkin" <mst@redhat.com> Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Richard Henderson <rth@twiddle.net> Cc: Eduardo Habkost <ehabkost@redhat.com> Signed-off-by: David Hildenbrand <david@redhat.com> --- target/i386/sev.c | 1 + 1 file changed, 1 insertion(+)