| Message ID | 20200506192916.29853-1-marek.behun@nic.cz (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | c2671acbbbd822ef077cc168991e0a7dbe2172c9 |
| Headers | show |
| Series | [mvebu-dt64] arm64: dts: armada-3720-turris-mox: fix SFP binding | expand |
Marek Behún <marek.behun@nic.cz> writes: > The sfp compatible should be 'sff,sfp', not 'sff,sfp+'. We used patched > kernel where the latter was working. > > Fixes: 7109d817db2e ("arm64: dts: marvell: add DTS for Turris Mox") > Signed-off-by: Marek Behún <marek.behun@nic.cz> > Cc: Gregory CLEMENT <gregory.clement@bootlin.com> Applied on mvebu/dt64 Thanks, Gregory > --- > arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > index bb42d1e6a4e9..6a2ec6625880 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > +++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > @@ -95,7 +95,7 @@ sdhci1_pwrseq: sdhci1-pwrseq { > }; > > sfp: sfp { > - compatible = "sff,sfp+"; > + compatible = "sff,sfp"; > i2c-bus = <&i2c0>; > los-gpio = <&moxtet_sfp 0 GPIO_ACTIVE_HIGH>; > tx-fault-gpio = <&moxtet_sfp 1 GPIO_ACTIVE_HIGH>; > -- > 2.24.1 >
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts index bb42d1e6a4e9..6a2ec6625880 100644 --- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts +++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts @@ -95,7 +95,7 @@ sdhci1_pwrseq: sdhci1-pwrseq { }; sfp: sfp { - compatible = "sff,sfp+"; + compatible = "sff,sfp"; i2c-bus = <&i2c0>; los-gpio = <&moxtet_sfp 0 GPIO_ACTIVE_HIGH>; tx-fault-gpio = <&moxtet_sfp 1 GPIO_ACTIVE_HIGH>;
The sfp compatible should be 'sff,sfp', not 'sff,sfp+'. We used patched kernel where the latter was working. Fixes: 7109d817db2e ("arm64: dts: marvell: add DTS for Turris Mox") Signed-off-by: Marek Behún <marek.behun@nic.cz> Cc: Gregory CLEMENT <gregory.clement@bootlin.com> --- arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)