mbox series

[v4,00/19] target/mips: FPU and other cleanups and improvements

Message ID 20200517092357.1469-1-aleksandar.qemu.devel@gmail.com (mailing list archive)
Headers show
Series target/mips: FPU and other cleanups and improvements | expand

Message

Aleksandar Markovic May 17, 2020, 9:23 a.m. UTC
This series contains mostly cosmetic FPU cleanups aimed to make
source code recognition easier for tools like gdb, gcov, calgrind,
and others.

There is also a patch that refactors conversion from ieee to mips
fp exception flags. This refactoring will improve the performance
of almost all fp-related mips instructions, albait very modestly
(less that one percent).

There is a patch that introduces some logging in mips_malta.c.

There is a patch on change of Aleksandar Rikalo's email.

Finally, there is a patch on renaming some files in hw/mips folder.

v3->v4:

  - corrected some spelling and style mistakes in commit messages
  - added a patch on renaming some files in hw/mips

v2->v3:

  - changed Malta patch to perform logging
  - added change of Aleksandar Rikalo's email

v1->v2:

  - added more demacroing

Aleksandar Markovic (19):
  target/mips: fpu: Demacro ADD.<D|S|PS>
  target/mips: fpu: Demacro SUB.<D|S|PS>
  target/mips: fpu: Demacro MUL.<D|S|PS>
  target/mips: fpu: Demacro DIV.<D|S|PS>
  target/mips: fpu: Remove now unused macro FLOAT_BINOP
  target/mips: fpu: Demacro MADD.<D|S|PS>
  target/mips: fpu: Demacro MSUB.<D|S|PS>
  target/mips: fpu: Demacro NMADD.<D|S|PS>
  target/mips: fpu: Demacro NMSUB.<D|S|PS>
  target/mips: fpu: Remove now unused UNFUSED_FMA and FLOAT_FMA macros
  target/mips: fpu: Demacro CLASS.<D|S>
  target/mips: fpu: Remove now unused FLOAT_CLASS macro
  target/mips: fpu: Demacro RINT.<D|S>
  target/mips: fpu: Remove now unused FLOAT_RINT macro
  target/mips: fpu: Name better paired-single variables
  target/mips: fpu: Refactor conversion from ieee to mips exception
    flags
  hw/mips: Add some logging for bad register offset cases
  MAINTAINERS: Change Aleksandar Rikalo's email address
  hw/mips: Rename malta/mipssim/r4k/jazz files in hw/mips

 .mailmap                              |   3 +-
 MAINTAINERS                           |  12 +-
 hw/mips/Makefile.objs                 |   8 +-
 hw/mips/{mips_jazz.c => jazz.c}       |   0
 hw/mips/{mips_malta.c => malta.c}     |  14 +-
 hw/mips/{mips_mipssim.c => mipssim.c} |   0
 hw/mips/{mips_r4k.c => r4k.c}         |   0
 target/mips/fpu_helper.c              | 658 ++++++++++++++++++--------
 target/mips/internal.h                |   1 -
 target/mips/msa_helper.c              |  77 ++-
 10 files changed, 523 insertions(+), 250 deletions(-)
 rename hw/mips/{mips_jazz.c => jazz.c} (100%)
 rename hw/mips/{mips_malta.c => malta.c} (99%)
 rename hw/mips/{mips_mipssim.c => mipssim.c} (100%)
 rename hw/mips/{mips_r4k.c => r4k.c} (100%)

Comments

Aleksandar Rikalo May 18, 2020, 11:01 a.m. UTC | #1
> This series contains mostly cosmetic FPU cleanups aimed to make
 > source code recognition easier for tools like gdb, gcov, calgrind,
 > and others.
 >
 > There is also a patch that refactors conversion from ieee to mips
 > fp exception flags. This refactoring will improve the performance
 > of almost all fp-related mips instructions, albait very modestly
 > (less that one percent).
 >
 > There is a patch that introduces some logging in mips_malta.c.
 >
 > There is a patch on change of Aleksandar Rikalo's email.
 >
 > Finally, there is a patch on renaming some files in hw/mips folder.
 >
 > v3->v4:
 >
 >   - corrected some spelling and style mistakes in commit messages
 >   - added a patch on renaming some files in hw/mips
 >
 > v2->v3:
 >
 >   - changed Malta patch to perform logging
 >   - added change of Aleksandar Rikalo's email
 >
 > v1->v2:
 >
 >   - added more demacroing
 >
 > Aleksandar Markovic (19):
 >   target/mips: fpu: Demacro ADD.<D|S|PS>
 >   target/mips: fpu: Demacro SUB.<D|S|PS>
 >   target/mips: fpu: Demacro MUL.<D|S|PS>
 >   target/mips: fpu: Demacro DIV.<D|S|PS>
 >   target/mips: fpu: Remove now unused macro FLOAT_BINOP
 >   target/mips: fpu: Demacro MADD.<D|S|PS>
 >   target/mips: fpu: Demacro MSUB.<D|S|PS>
 >   target/mips: fpu: Demacro NMADD.<D|S|PS>
 >   target/mips: fpu: Demacro NMSUB.<D|S|PS>
 >   target/mips: fpu: Remove now unused UNFUSED_FMA and FLOAT_FMA macros
 >   target/mips: fpu: Demacro CLASS.<D|S>
 >   target/mips: fpu: Remove now unused FLOAT_CLASS macro
 >   target/mips: fpu: Demacro RINT.<D|S>
 >   target/mips: fpu: Remove now unused FLOAT_RINT macro
 >   target/mips: fpu: Name better paired-single variables
 >   target/mips: fpu: Refactor conversion from ieee to mips exception
 >     flags
 >   hw/mips: Add some logging for bad register offset cases
 >   MAINTAINERS: Change Aleksandar Rikalo's email address
 >   hw/mips: Rename malta/mipssim/r4k/jazz files in hw/mips
 >
 >  .mailmap                              |   3 +-
 >  MAINTAINERS                           |  12 +-
 >  hw/mips/Makefile.objs                 |   8 +-
 >  hw/mips/{mips_jazz.c => jazz.c}       |   0
 >  hw/mips/{mips_malta.c => malta.c}     |  14 +-
 >  hw/mips/{mips_mipssim.c => mipssim.c} |   0
 >  hw/mips/{mips_r4k.c => r4k.c}         |   0
 >  target/mips/fpu_helper.c              | 658 ++++++++++++++++++--------
 >  target/mips/internal.h                |   1 -
 >  target/mips/msa_helper.c              |  77 ++-
 >  10 files changed, 523 insertions(+), 250 deletions(-)
 >  rename hw/mips/{mips_jazz.c => jazz.c} (100%)
 >  rename hw/mips/{mips_malta.c => malta.c} (99%)
 >  rename hw/mips/{mips_mipssim.c => mipssim.c} (100%)
 >  rename hw/mips/{mips_r4k.c => r4k.c} (100%)
 >
 > --
 > 2.20.1
 >

For patches 1-16 and 18:

Reviewed-by: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>

Please make sure you rerun our MIPS FPU regression tests after the 
series is applied.

Thanks,
Aleksandar Rikalo
Aleksandar Markovic June 4, 2020, 1:11 p.m. UTC | #2
пон, 18. мај 2020. у 13:01 Aleksandar Rikalo
<aleksandar.rikalo@syrmia.com> је написао/ла:
>
>  > This series contains mostly cosmetic FPU cleanups aimed to make
>  > source code recognition easier for tools like gdb, gcov, calgrind,
>  > and others.
>  >
>  > There is also a patch that refactors conversion from ieee to mips
>  > fp exception flags. This refactoring will improve the performance
>  > of almost all fp-related mips instructions, albait very modestly
>  > (less that one percent).
>  >
>  > There is a patch that introduces some logging in mips_malta.c.
>  >
>  > There is a patch on change of Aleksandar Rikalo's email.
>  >
>  > Finally, there is a patch on renaming some files in hw/mips folder.
>  >
>  > v3->v4:
>  >
>  >   - corrected some spelling and style mistakes in commit messages
>  >   - added a patch on renaming some files in hw/mips
>  >
>  > v2->v3:
>  >
>  >   - changed Malta patch to perform logging
>  >   - added change of Aleksandar Rikalo's email
>  >
>  > v1->v2:
>  >
>  >   - added more demacroing
>  >
>  > Aleksandar Markovic (19):
>  >   target/mips: fpu: Demacro ADD.<D|S|PS>
>  >   target/mips: fpu: Demacro SUB.<D|S|PS>
>  >   target/mips: fpu: Demacro MUL.<D|S|PS>
>  >   target/mips: fpu: Demacro DIV.<D|S|PS>
>  >   target/mips: fpu: Remove now unused macro FLOAT_BINOP
>  >   target/mips: fpu: Demacro MADD.<D|S|PS>
>  >   target/mips: fpu: Demacro MSUB.<D|S|PS>
>  >   target/mips: fpu: Demacro NMADD.<D|S|PS>
>  >   target/mips: fpu: Demacro NMSUB.<D|S|PS>
>  >   target/mips: fpu: Remove now unused UNFUSED_FMA and FLOAT_FMA macros
>  >   target/mips: fpu: Demacro CLASS.<D|S>
>  >   target/mips: fpu: Remove now unused FLOAT_CLASS macro
>  >   target/mips: fpu: Demacro RINT.<D|S>
>  >   target/mips: fpu: Remove now unused FLOAT_RINT macro
>  >   target/mips: fpu: Name better paired-single variables
>  >   target/mips: fpu: Refactor conversion from ieee to mips exception
>  >     flags
>  >   hw/mips: Add some logging for bad register offset cases
>  >   MAINTAINERS: Change Aleksandar Rikalo's email address
>  >   hw/mips: Rename malta/mipssim/r4k/jazz files in hw/mips
>  >
>  >  .mailmap                              |   3 +-
>  >  MAINTAINERS                           |  12 +-
>  >  hw/mips/Makefile.objs                 |   8 +-
>  >  hw/mips/{mips_jazz.c => jazz.c}       |   0
>  >  hw/mips/{mips_malta.c => malta.c}     |  14 +-
>  >  hw/mips/{mips_mipssim.c => mipssim.c} |   0
>  >  hw/mips/{mips_r4k.c => r4k.c}         |   0
>  >  target/mips/fpu_helper.c              | 658 ++++++++++++++++++--------
>  >  target/mips/internal.h                |   1 -
>  >  target/mips/msa_helper.c              |  77 ++-
>  >  10 files changed, 523 insertions(+), 250 deletions(-)
>  >  rename hw/mips/{mips_jazz.c => jazz.c} (100%)
>  >  rename hw/mips/{mips_malta.c => malta.c} (99%)
>  >  rename hw/mips/{mips_mipssim.c => mipssim.c} (100%)
>  >  rename hw/mips/{mips_r4k.c => r4k.c} (100%)
>  >
>  > --
>  > 2.20.1
>  >
>
> For patches 1-16 and 18:
>
> Reviewed-by: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>
>


Patches 1-16 applied to MIPS queue.

Patch 18 is already upstream.
Tthanks,
Aleksandar M.
> Please make sure you rerun our MIPS FPU regression tests after the
> series is applied.
>
> Thanks,
> Aleksandar Rikalo
>