| Message ID | 20200516212330.13633-1-chris@chris-wilson.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/4] drm: Include internal header for managed function declarations | expand |
On Sat, May 16, 2020 at 10:23:27PM +0100, Chris Wilson wrote: > drivers/gpu/drm/drm_managed.c:61:6: warning: symbol 'drm_managed_release' was not declared. Should it be static? > CC drivers/gpu/drm/drm_managed.o > drivers/gpu/drm/drm_managed.c:61:6: warning: no previous prototype for ‘drm_managed_release’ [-Wmissing-prototypes] > void drm_managed_release(struct drm_device *dev) Drat! Thanks for fixing. Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > > Fixes: c6603c740e0e ("drm: add managed resources tied to drm_device") > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Daniel Vetter <daniel@ffwll.ch> > --- > drivers/gpu/drm/drm_managed.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/drm_managed.c b/drivers/gpu/drm/drm_managed.c > index 9cebfe370a65..1e1356560c2e 100644 > --- a/drivers/gpu/drm/drm_managed.c > +++ b/drivers/gpu/drm/drm_managed.c > @@ -14,6 +14,8 @@ > #include <drm/drm_device.h> > #include <drm/drm_print.h> > > +#include "drm_internal.h" > + > /** > * DOC: managed resources > * > -- > 2.20.1 >
diff --git a/drivers/gpu/drm/drm_managed.c b/drivers/gpu/drm/drm_managed.c index 9cebfe370a65..1e1356560c2e 100644 --- a/drivers/gpu/drm/drm_managed.c +++ b/drivers/gpu/drm/drm_managed.c @@ -14,6 +14,8 @@ #include <drm/drm_device.h> #include <drm/drm_print.h> +#include "drm_internal.h" + /** * DOC: managed resources *
drivers/gpu/drm/drm_managed.c:61:6: warning: symbol 'drm_managed_release' was not declared. Should it be static? CC drivers/gpu/drm/drm_managed.o drivers/gpu/drm/drm_managed.c:61:6: warning: no previous prototype for ‘drm_managed_release’ [-Wmissing-prototypes] void drm_managed_release(struct drm_device *dev) Fixes: c6603c740e0e ("drm: add managed resources tied to drm_device") Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Daniel Vetter <daniel@ffwll.ch> --- drivers/gpu/drm/drm_managed.c | 2 ++ 1 file changed, 2 insertions(+)