| Message ID | 9b13bb2e1f52f1792cd81850ee95bf3781bb5363.1589759816.git.lance.digby@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5482d56bfedf1a2ce6450076e844676e20ab4e0a |
| Headers | show |
| Series | [v1,target] target: Add initiatorname to NON_EXISTENT_LUN error | expand |
On 5/17/20 8:02 PM, Lance Digby wrote: > The NON_EXISTENT_LUN error can be written without an error condition > on the initiator responsible. Adding the initiatorname to this message > will reduce the effort required to fix this when many initiators are > supported by a target. > > This version ensures the initiator name is also printed on the same > message in transport_lookup_tmr_lun for consistency. > Reviewed-by: Mike Christie <mchristi@redhat.com>
On Mon, 18 May 2020 11:02:16 +1000, Lance Digby wrote: > The NON_EXISTENT_LUN error can be written without an error condition > on the initiator responsible. Adding the initiatorname to this message > will reduce the effort required to fix this when many initiators are > supported by a target. > > This version ensures the initiator name is also printed on the same > message in transport_lookup_tmr_lun for consistency. Applied to 5.8/scsi-queue, thanks! [1/1] scsi: target: core: Add initiatorname to NON_EXISTENT_LUN error https://git.kernel.org/mkp/scsi/c/5482d56bfedf
diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c index 4cee113..15064a5 100644 --- a/drivers/target/target_core_device.c +++ b/drivers/target/target_core_device.c @@ -100,9 +100,10 @@ */ if (unpacked_lun != 0) { pr_err("TARGET_CORE[%s]: Detected NON_EXISTENT_LUN" - " Access for 0x%08llx\n", + " Access for 0x%08llx from %s\n", se_cmd->se_tfo->fabric_name, - unpacked_lun); + unpacked_lun, + nacl->initiatorname); return TCM_NON_EXISTENT_LUN; } @@ -174,9 +175,10 @@ int transport_lookup_tmr_lun(struct se_cmd *se_cmd, u64 unpacked_lun) if (!se_lun) { pr_debug("TARGET_CORE[%s]: Detected NON_EXISTENT_LUN" - " Access for 0x%08llx\n", + " Access for 0x%08llx for %s\n", se_cmd->se_tfo->fabric_name, - unpacked_lun); + unpacked_lun, + nacl->initiatorname); return -ENODEV; } se_cmd->se_dev = rcu_dereference_raw(se_lun->lun_se_dev);
The NON_EXISTENT_LUN error can be written without an error condition on the initiator responsible. Adding the initiatorname to this message will reduce the effort required to fix this when many initiators are supported by a target. This version ensures the initiator name is also printed on the same message in transport_lookup_tmr_lun for consistency. Signed-off-by: Lance Digby <lance.digby@gmail.com> --- drivers/target/target_core_device.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)