| Message ID | 20200518171704.24999-1-Vijendar.Mukunda@amd.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add Renoir ACP driver | expand |
On 5/18/20 12:16 PM, Vijendar Mukunda wrote: > This adds an ASoC driver for the ACP (Audio CoProcessor) > block on AMD Renoir APUs. All my feedback was taken into account and I didn't see any new issues so: Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> I wouldn't hurt to have additional reviewers though. > V3: > - Changed PCI driver PM runtime sequence > - Removed redundant code in Renoir machine driver > > V2: > - Removed empty declaration of dai_ops > - Removed SNDRV_PCM_INFO_BATCH flag > - Defined Macros for delay and counter and corrected dma stop sequence. > - Changed PCI driver pm runtime sequence > - Removed redundant code > > > Vijendar Mukunda (14): > ASoC: amd: add Renoir ACP3x IP register header > ASoC: amd: add Renoir ACP PCI driver > ASoC: amd: add acp init/de-init functions > ASoC: amd: create acp3x pdm platform device > ASoC: amd: add ACP3x PDM platform driver > ASoC: amd: irq handler changes for ACP3x PDM dma driver > ASoC: amd: add acp3x pdm driver dma ops > ASoC: amd: add ACP PDM DMA driver dai ops > ASoC: amd: add Renoir ACP PCI driver PM ops > ASoC: amd: add ACP PDM DMA driver pm ops > ASoC: amd: enable Renoir acp3x drivers build > ASoC: amd: create platform devices for Renoir > ASoC: amd: RN machine driver using dmic > ASoC: amd: enable build for RN machine driver > > sound/soc/amd/Kconfig | 13 + > sound/soc/amd/Makefile | 1 + > sound/soc/amd/renoir/Makefile | 7 + > sound/soc/amd/renoir/acp3x-pdm-dma.c | 530 +++++++++++++++++++++ > sound/soc/amd/renoir/acp3x-rn.c | 77 +++ > sound/soc/amd/renoir/rn-pci-acp3x.c | 344 +++++++++++++ > sound/soc/amd/renoir/rn_acp3x.h | 88 ++++ > sound/soc/amd/renoir/rn_chip_offset_byte.h | 349 ++++++++++++++ > 8 files changed, 1409 insertions(+) > create mode 100644 sound/soc/amd/renoir/Makefile > create mode 100644 sound/soc/amd/renoir/acp3x-pdm-dma.c > create mode 100644 sound/soc/amd/renoir/acp3x-rn.c > create mode 100644 sound/soc/amd/renoir/rn-pci-acp3x.c > create mode 100644 sound/soc/amd/renoir/rn_acp3x.h > create mode 100644 sound/soc/amd/renoir/rn_chip_offset_byte.h >
On Tue, May 19, 2020 at 01:16:50AM +0800, Vijendar Mukunda wrote: > This adds an ASoC driver for the ACP (Audio CoProcessor) > block on AMD Renoir APUs. The issues I found here were relatively minor so I'll go ahead and apply, overall this looks good - please submit incremental patches for the issues.
[AMD Official Use Only - Internal Distribution Only] > -----Original Message----- > From: Mark Brown <broonie@kernel.org> > Sent: Tuesday, May 19, 2020 5:09 PM > To: Mukunda, Vijendar <Vijendar.Mukunda@amd.com> > Cc: alsa-devel@alsa-project.org; tiwai@suse.de; Deucher, Alexander > <Alexander.Deucher@amd.com> > Subject: Re: [PATCH v3 00/14] Add Renoir ACP driver > > On Tue, May 19, 2020 at 01:16:50AM +0800, Vijendar Mukunda wrote: > > This adds an ASoC driver for the ACP (Audio CoProcessor) > > block on AMD Renoir APUs. > > The issues I found here were relatively minor so I'll go ahead and > apply, overall this looks good - please submit incremental patches for > the issues. I will address your review comments and I will post an incremental patches.
> -----Original Message----- > From: Mukunda, Vijendar > Sent: Tuesday, May 19, 2020 5:13 PM > To: 'Mark Brown' <broonie@kernel.org> > Cc: alsa-devel@alsa-project.org; tiwai@suse.de; Deucher, Alexander > <Alexander.Deucher@amd.com> > Subject: RE: [PATCH v3 00/14] Add Renoir ACP driver > > [AMD Official Use Only - Internal Distribution Only] > > > > > -----Original Message----- > > From: Mark Brown <broonie@kernel.org> > > Sent: Tuesday, May 19, 2020 5:09 PM > > To: Mukunda, Vijendar <Vijendar.Mukunda@amd.com> > > Cc: alsa-devel@alsa-project.org; tiwai@suse.de; Deucher, Alexander > > <Alexander.Deucher@amd.com> > > Subject: Re: [PATCH v3 00/14] Add Renoir ACP driver > > > > On Tue, May 19, 2020 at 01:16:50AM +0800, Vijendar Mukunda wrote: > > > This adds an ASoC driver for the ACP (Audio CoProcessor) > > > block on AMD Renoir APUs. > > > > The issues I found here were relatively minor so I'll go ahead and > > apply, overall this looks good - please submit incremental patches for > > the issues. > > I will address your review comments and I will post an incremental patches. Got one kernel warning reported by Kbuild test report. Will upload a fresh patch set.
On Tue, 19 May 2020 01:16:50 +0800, Vijendar Mukunda wrote: > This adds an ASoC driver for the ACP (Audio CoProcessor) > block on AMD Renoir APUs. > > V3: > - Changed PCI driver PM runtime sequence > - Removed redundant code in Renoir machine driver > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.8 Thanks! [01/14] ASoC: amd: add Renoir ACP3x IP register header commit: 9b5e98e21467cd0a6c689db5ef971d7a61c73929 [02/14] ASoC: amd: add Renoir ACP PCI driver commit: 1eb2852efe05abfa94cd78cc9865389643726ee9 [03/14] ASoC: amd: add acp init/de-init functions commit: 85ded495640e63282aa83583ab64304a9912303d [04/14] ASoC: amd: create acp3x pdm platform device commit: 66c4f558aa3a1b6f2b90981c364173af2f3d2c33 [05/14] ASoC: amd: add ACP3x PDM platform driver commit: f621a3676d3f52fcb8b7d8db8acbcc28423bcdb7 [06/14] ASoC: amd: irq handler changes for ACP3x PDM dma driver commit: b9901654a90a367a74c34c76e0c8b4156bf539af [07/14] ASoC: amd: add acp3x pdm driver dma ops commit: 4a767b1d039a855c491c4853013804323c06f728 [08/14] ASoC: amd: add ACP PDM DMA driver dai ops commit: 370e7dde5b3d71820e142b566683306940daeffe [09/14] ASoC: amd: add Renoir ACP PCI driver PM ops commit: c346e768f92cd6dbed474adf2f5eb3c9763a8bfa [10/14] ASoC: amd: add ACP PDM DMA driver pm ops commit: 35e4be1136e69710ffe559d173c9d66ff7d32730 [11/14] ASoC: amd: enable Renoir acp3x drivers build commit: c15f258e6791e62c57d340c961de89261e48dc0a [12/14] ASoC: amd: create platform devices for Renoir commit: b208c3bc33542ab5a689f9b7a5f6ffc1a3da2944 [13/14] ASoC: amd: RN machine driver using dmic commit: 7ca448a518cf40e161051f0fb69f550a1a636324 [14/14] ASoC: amd: enable build for RN machine driver commit: 1d3776669323e71b00c99a178317fc46edbd09bb All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark