[0/4] brcmfmac: SoftAP creation and dcmd buffer size changes

Message

Chi-Hsien Lin May 19, 2020, 11:09 a.m. UTC

Allow SoftAP creation via ioctl from test tool; also update dcmd buffer size
settings for new firmware. Also fix a sparse check error.

Chi-Hsien Lin (1):
  brcmfmac: fix a sparse incorrect type error in p2p.c

Double Lo (2):
  brcmfmac: support virtual interface creation from firmware
  brcmfmac: increase dcmd maximum buffer size

Kurt Lee (1):
  brcmfmac: set net carrier on via test tool for AP mode

 .../broadcom/brcm80211/brcmfmac/bcdc.c        |  4 +-
 .../broadcom/brcm80211/brcmfmac/cfg80211.c    | 46 +++++++++++++++++--
 .../broadcom/brcm80211/brcmfmac/p2p.c         |  3 +-
 .../broadcom/brcm80211/brcmfmac/vendor.c      |  9 ++++
 4 files changed, 56 insertions(+), 6 deletions(-)

--
2.25.0


This message and any attachments may contain confidential information from Cypress or its subsidiaries. If it has been received in error, please advise the sender and immediately delete this message.

Comments

Kalle Valo May 19, 2020, 1:54 p.m. UTC | #1

Chi-Hsien Lin <[e-mail]> writes:

> Allow SoftAP creation via ioctl from test tool; also update dcmd buffer size
> settings for new firmware. Also fix a sparse check error.

What ioctl is this exactly? Wireless drivers should be using nl80211,
not any ioctl interface.

Arend van Spriel May 19, 2020, 5 p.m. UTC | #2

On 5/19/2020 3:54 PM, Kalle Valo wrote:
> Chi-Hsien Lin <[e-mail]> writes:
> 
>> Allow SoftAP creation via ioctl from test tool; also update dcmd buffer size
>> settings for new firmware. Also fix a sparse check error.
> 
> What ioctl is this exactly? Wireless drivers should be using nl80211,
> not any ioctl interface.

Hi Kalle,

The terminology is a bit off. This is vendor specific command 
interfacing directly with firmware and the content is opaque from driver 
perspective. However, a number of these commands have their nl80211 
equivalent. Especially regarding creation of AP interface I would simply 
go with creation through nl80211.

Regards,
Arend

Kalle Valo May 22, 2020, 10:22 a.m. UTC | #3

Arend Van Spriel <[e-mail]> writes:

> On 5/19/2020 3:54 PM, Kalle Valo wrote:
>> Chi-Hsien Lin <[e-mail]> writes:
>>
>>> Allow SoftAP creation via ioctl from test tool; also update dcmd buffer size
>>> settings for new firmware. Also fix a sparse check error.
>>
>> What ioctl is this exactly? Wireless drivers should be using nl80211,
>> not any ioctl interface.
>
> Hi Kalle,
>
> The terminology is a bit off. This is vendor specific command
> interfacing directly with firmware and the content is opaque from
> driver perspective.

Ah, you mean nl80211 vendor command. That has nothing to do with ioctl :)

> However, a number of these commands have their nl80211 equivalent.
> Especially regarding creation of AP interface I would simply go with
> creation through nl80211.

And do note that we have new rules for nl80211 vendor commands:

https://wireless.wiki.kernel.org/en/developers/documentation/nl80211#vendor-specific_api