| Message ID | 20200513160402.8050-1-jack@suse.cz (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | blkparse: Print PID information for TN_MESSAGE events | expand |
On 5/13/20 10:04 AM, Jan Kara wrote: > The kernel now provides PID information for TN_MESSAGE events. Print it. > Old kernels fill 0 there so the behavior is unaffected for them. Doesn't apply to the current repo, can you resend?
On Tue 19-05-20 09:53:23, Jens Axboe wrote: > On 5/13/20 10:04 AM, Jan Kara wrote: > > The kernel now provides PID information for TN_MESSAGE events. Print it. > > Old kernels fill 0 there so the behavior is unaffected for them. > > Doesn't apply to the current repo, can you resend? Likely because it is based on top of my blkparse fixes to deal with cgroup information in blktrace events. Did you pick up those? Rebasing this on-liner is simple enough but I'm just wondering... Honza
On 5/20/20 7:20 AM, Jan Kara wrote: > On Tue 19-05-20 09:53:23, Jens Axboe wrote: >> On 5/13/20 10:04 AM, Jan Kara wrote: >>> The kernel now provides PID information for TN_MESSAGE events. Print it. >>> Old kernels fill 0 there so the behavior is unaffected for them. >> >> Doesn't apply to the current repo, can you resend? > > Likely because it is based on top of my blkparse fixes to deal with cgroup > information in blktrace events. Did you pick up those? Rebasing this > on-liner is simple enough but I'm just wondering... Indeed, applied this one too. Thanks!
diff --git a/blkparse.c b/blkparse.c index ae4cb4433944..911309e26a15 100644 --- a/blkparse.c +++ b/blkparse.c @@ -643,7 +643,7 @@ static void handle_notify(struct blk_io_trace *bit) MAJOR(bit->device), MINOR(bit->device), bit->cpu, "0", (int)SECONDS(bit->time), (unsigned long)NANO_SECONDS(bit->time), - 0, cgidstr, "m", "N", msg); + bit->pid, cgidstr, "m", "N", msg); } break;
The kernel now provides PID information for TN_MESSAGE events. Print it. Old kernels fill 0 there so the behavior is unaffected for them. Signed-off-by: Jan Kara <jack@suse.cz> --- blkparse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)