| Message ID | 20200520152538.23184-1-william.c.roberts@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Ondrej Mosnáček |
| Headers | show |
| Series | README: Add kernel-modules for SCTP | expand |
On Wed, May 20, 2020 at 5:26 PM <william.c.roberts@intel.com> wrote: > From: William Roberts <william.c.roberts@intel.com> > > Some Fedora images, notably the Fedora 32 cloud image, do not have the > kernel modules package installed by default. Thus SCTP isn't available. > Add the proper kernel-modules package for the running kernel. Hm, I thought it wasn't possible to remove the kernel-modules package for the running kernel, but it really is... > > Note: This applies to selinux-testsuite. > > Signed-off-by: William Roberts <william.c.roberts@intel.com> > --- > README.md | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/README.md b/README.md > index 1bec9fe85c91..1a4c70c40d56 100644 > --- a/README.md > +++ b/README.md > @@ -77,7 +77,8 @@ following command: > kernel-devel-$(uname -r) \ > quota \ > xfsprogs-devel \ > - libuuid-devel > + libuuid-devel \ > + kernel-modules-$(uname -r) Can you please put both the kernel-* packages together? I think it would be best to always have both at the end so that anyone who uses locally built kernels can easily copy the command without the two. Or I can just amend your patch when applying if you're OK with that. > > #### Debian > > -- > 2.17.1 >
On Tue, May 26, 2020 at 8:17 AM Ondrej Mosnacek <omosnace@redhat.com> wrote: > > On Wed, May 20, 2020 at 5:26 PM <william.c.roberts@intel.com> wrote: > > From: William Roberts <william.c.roberts@intel.com> > > > > Some Fedora images, notably the Fedora 32 cloud image, do not have the > > kernel modules package installed by default. Thus SCTP isn't available. > > Add the proper kernel-modules package for the running kernel. > > Hm, I thought it wasn't possible to remove the kernel-modules package > for the running kernel, but it really is... > > > > > Note: This applies to selinux-testsuite. > > > > Signed-off-by: William Roberts <william.c.roberts@intel.com> > > --- > > README.md | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/README.md b/README.md > > index 1bec9fe85c91..1a4c70c40d56 100644 > > --- a/README.md > > +++ b/README.md > > @@ -77,7 +77,8 @@ following command: > > kernel-devel-$(uname -r) \ > > quota \ > > xfsprogs-devel \ > > - libuuid-devel > > + libuuid-devel \ > > + kernel-modules-$(uname -r) > > Can you please put both the kernel-* packages together? I think it > would be best to always have both at the end so that anyone who uses > locally built kernels can easily copy the command without the two. Or > I can just amend your patch when applying if you're OK with that. Thats fine by me, thanks. > > > > > #### Debian > > > > -- > > 2.17.1 > > > > -- > Ondrej Mosnacek > Software Engineer, Platform Security - SELinux kernel, > Red Hat, Inc. >
On Tue, May 26, 2020 at 7:15 PM William Roberts <bill.c.roberts@gmail.com> wrote: > > On Tue, May 26, 2020 at 8:17 AM Ondrej Mosnacek <omosnace@redhat.com> wrote: > > > > On Wed, May 20, 2020 at 5:26 PM <william.c.roberts@intel.com> wrote: > > > From: William Roberts <william.c.roberts@intel.com> > > > > > > Some Fedora images, notably the Fedora 32 cloud image, do not have the > > > kernel modules package installed by default. Thus SCTP isn't available. > > > Add the proper kernel-modules package for the running kernel. > > > > Hm, I thought it wasn't possible to remove the kernel-modules package > > for the running kernel, but it really is... > > > > > > > > Note: This applies to selinux-testsuite. > > > > > > Signed-off-by: William Roberts <william.c.roberts@intel.com> > > > --- > > > README.md | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/README.md b/README.md > > > index 1bec9fe85c91..1a4c70c40d56 100644 > > > --- a/README.md > > > +++ b/README.md > > > @@ -77,7 +77,8 @@ following command: > > > kernel-devel-$(uname -r) \ > > > quota \ > > > xfsprogs-devel \ > > > - libuuid-devel > > > + libuuid-devel \ > > > + kernel-modules-$(uname -r) > > > > Can you please put both the kernel-* packages together? I think it > > would be best to always have both at the end so that anyone who uses > > locally built kernels can easily copy the command without the two. Or > > I can just amend your patch when applying if you're OK with that. > > Thats fine by me, thanks. OK, the patch is now applied.
diff --git a/README.md b/README.md index 1bec9fe85c91..1a4c70c40d56 100644 --- a/README.md +++ b/README.md @@ -77,7 +77,8 @@ following command: kernel-devel-$(uname -r) \ quota \ xfsprogs-devel \ - libuuid-devel + libuuid-devel \ + kernel-modules-$(uname -r) #### Debian