[RESEND,v3,0/2] syscon: Alter syscon and reboot drivers

Message

Serge Semin May 26, 2020, 1:50 p.m. UTC

This is a small patchset about tuning the syscon infrastructure a bit.
As it's going to be general in the framework of the Baikal-T1 SoC support
integration into the kernel, we suggest to replace the legacy text-based
syscon-reboot-mode dts-bindings file with yaml-based one. Then seeing a
syscon reboot block is normally expected to be a part of a system
controller and based on the discussion
https://lore.kernel.org/linux-pm/[e-mail]/
we decided to alter the syscon reboot driver so one would also try to fetch
the syscon registers map from a parental DT node. regmap property is left
supported although it's marked as deprecated from now.

This patchset is rebased and tested on the mainline Linux kernel 5.7-rc4:
0e698dfa2822 ("Linux 5.7-rc4")
tag: v5.7-rc4

Changelog v2:
- Add Sebastian' Acked-by tag to patch 1.
- Use a shorter summary describing the bindings modification patches.
- Our corporate email server doesn't change Message-Id anymore, so the patchset
  is resubmitted being in the cover-letter-threaded format.
- Discard patch with syscon "-endian" property support. As Rob said It shall be
  in the common dt-schema.
- Replace patches of adding a regmap property support to the syscon-reboot-mode
  with patches making syscon-reboot a sub-node of a system controller node.
- Mark regmap property as deprecated from now.

Link: https://lore.kernel.org/linux-pm/[e-mail]/
Changelog v3:
- Discard the commit 6acd3ecd88ff ("dt-bindings: power: reset: Convert
  syscon-reboot-mode to DT schema") since it has been merged in by Sebatian.
- Add Rob's Reviewed-by tag to the patch "dt-bindings: power: reset: Unrequire
  regmap property in syscon-reboot node"

Signed-off-by: Serge Semin <[e-mail]>
Cc: Alexey Malahov <[e-mail]>
Cc: Maxim Kaurkin <[e-mail]>
Cc: Pavel Parkhomenko <[e-mail]>
Cc: Ramil Zaripov <[e-mail]>
Cc: Ekaterina Skachko <[e-mail]>
Cc: Vadim Vlasov <[e-mail]>
Cc: Alexey Kolotnikov <[e-mail]>
Cc: Thomas Bogendoerfer <[e-mail]>
Cc: Arnd Bergmann <[e-mail]>
Cc: Rob Herring <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]

Serge Semin (2):
  dt-bindings: power: reset: Unrequire regmap property in syscon-reboot
    node
  power: reset: syscon-reboot: Add parental syscon support

 .../bindings/power/reset/syscon-reboot.yaml       | 15 ++++++++++-----
 drivers/power/reset/syscon-reboot.c               |  7 +++++--
 2 files changed, 15 insertions(+), 7 deletions(-)

Comments

Sebastian Reichel May 28, 2020, 7:03 a.m. UTC | #1

Hi,

On Tue, May 26, 2020 at 04:50:59PM +0300, Serge Semin wrote:
> This is a small patchset about tuning the syscon infrastructure a bit.
> As it's going to be general in the framework of the Baikal-T1 SoC support
> integration into the kernel, we suggest to replace the legacy text-based
> syscon-reboot-mode dts-bindings file with yaml-based one. Then seeing a
> syscon reboot block is normally expected to be a part of a system
> controller and based on the discussion
> https://lore.kernel.org/linux-pm/[e-mail]/
> we decided to alter the syscon reboot driver so one would also try to fetch
> the syscon registers map from a parental DT node. regmap property is left
> supported although it's marked as deprecated from now.
> 
> This patchset is rebased and tested on the mainline Linux kernel 5.7-rc4:
> 0e698dfa2822 ("Linux 5.7-rc4")
> tag: v5.7-rc4
> 
> Changelog v2:
> - Add Sebastian' Acked-by tag to patch 1.
> - Use a shorter summary describing the bindings modification patches.
> - Our corporate email server doesn't change Message-Id anymore, so the patchset
>   is resubmitted being in the cover-letter-threaded format.
> - Discard patch with syscon "-endian" property support. As Rob said It shall be
>   in the common dt-schema.
> - Replace patches of adding a regmap property support to the syscon-reboot-mode
>   with patches making syscon-reboot a sub-node of a system controller node.
> - Mark regmap property as deprecated from now.
> 
> Link: https://lore.kernel.org/linux-pm/[e-mail]/
> Changelog v3:
> - Discard the commit 6acd3ecd88ff ("dt-bindings: power: reset: Convert
>   syscon-reboot-mode to DT schema") since it has been merged in by Sebatian.
> - Add Rob's Reviewed-by tag to the patch "dt-bindings: power: reset: Unrequire
>   regmap property in syscon-reboot node"
> 
> Signed-off-by: Serge Semin <[e-mail]>
> Cc: Alexey Malahov <[e-mail]>
> Cc: Maxim Kaurkin <[e-mail]>
> Cc: Pavel Parkhomenko <[e-mail]>
> Cc: Ramil Zaripov <[e-mail]>
> Cc: Ekaterina Skachko <[e-mail]>
> Cc: Vadim Vlasov <[e-mail]>
> Cc: Alexey Kolotnikov <[e-mail]>
> Cc: Thomas Bogendoerfer <[e-mail]>
> Cc: Arnd Bergmann <[e-mail]>
> Cc: Rob Herring <[e-mail]>
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> 
> Serge Semin (2):
>   dt-bindings: power: reset: Unrequire regmap property in syscon-reboot
>     node
>   power: reset: syscon-reboot: Add parental syscon support
> 
>  .../bindings/power/reset/syscon-reboot.yaml       | 15 ++++++++++-----
>  drivers/power/reset/syscon-reboot.c               |  7 +++++--
>  2 files changed, 15 insertions(+), 7 deletions(-)

Thanks, I queued both patches to power-supply's for-next branch.

-- Sebastian

Serge Semin May 28, 2020, 8:31 a.m. UTC | #2

On Thu, May 28, 2020 at 09:03:11AM +0200, Sebastian Reichel wrote:
> Hi,
> 
> On Tue, May 26, 2020 at 04:50:59PM +0300, Serge Semin wrote:
> > This is a small patchset about tuning the syscon infrastructure a bit.
> > As it's going to be general in the framework of the Baikal-T1 SoC support
> > integration into the kernel, we suggest to replace the legacy text-based
> > syscon-reboot-mode dts-bindings file with yaml-based one. Then seeing a
> > syscon reboot block is normally expected to be a part of a system
> > controller and based on the discussion
> > https://lore.kernel.org/linux-pm/[e-mail]/
> > we decided to alter the syscon reboot driver so one would also try to fetch
> > the syscon registers map from a parental DT node. regmap property is left
> > supported although it's marked as deprecated from now.
> > 
> > This patchset is rebased and tested on the mainline Linux kernel 5.7-rc4:
> > 0e698dfa2822 ("Linux 5.7-rc4")
> > tag: v5.7-rc4
> > 
> > Changelog v2:
> > - Add Sebastian' Acked-by tag to patch 1.
> > - Use a shorter summary describing the bindings modification patches.
> > - Our corporate email server doesn't change Message-Id anymore, so the patchset
> >   is resubmitted being in the cover-letter-threaded format.
> > - Discard patch with syscon "-endian" property support. As Rob said It shall be
> >   in the common dt-schema.
> > - Replace patches of adding a regmap property support to the syscon-reboot-mode
> >   with patches making syscon-reboot a sub-node of a system controller node.
> > - Mark regmap property as deprecated from now.
> > 
> > Link: https://lore.kernel.org/linux-pm/[e-mail]/
> > Changelog v3:
> > - Discard the commit 6acd3ecd88ff ("dt-bindings: power: reset: Convert
> >   syscon-reboot-mode to DT schema") since it has been merged in by Sebatian.
> > - Add Rob's Reviewed-by tag to the patch "dt-bindings: power: reset: Unrequire
> >   regmap property in syscon-reboot node"
> > 
> > Signed-off-by: Serge Semin <[e-mail]>
> > Cc: Alexey Malahov <[e-mail]>
> > Cc: Maxim Kaurkin <[e-mail]>
> > Cc: Pavel Parkhomenko <[e-mail]>
> > Cc: Ramil Zaripov <[e-mail]>
> > Cc: Ekaterina Skachko <[e-mail]>
> > Cc: Vadim Vlasov <[e-mail]>
> > Cc: Alexey Kolotnikov <[e-mail]>
> > Cc: Thomas Bogendoerfer <[e-mail]>
> > Cc: Arnd Bergmann <[e-mail]>
> > Cc: Rob Herring <[e-mail]>
> > Cc: [e-mail]
> > Cc: [e-mail]
> > Cc: [e-mail]
> > Cc: [e-mail]
> > 
> > Serge Semin (2):
> >   dt-bindings: power: reset: Unrequire regmap property in syscon-reboot
> >     node
> >   power: reset: syscon-reboot: Add parental syscon support
> > 
> >  .../bindings/power/reset/syscon-reboot.yaml       | 15 ++++++++++-----
> >  drivers/power/reset/syscon-reboot.c               |  7 +++++--
> >  2 files changed, 15 insertions(+), 7 deletions(-)
> 
> Thanks, I queued both patches to power-supply's for-next branch.
> 
> -- Sebastian

Great! Thanks.

-Sergey