| Message ID | 1590548229-17812-1-git-send-email-zijuhu@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] Bluetooth: hci_qca: Improve controller ID info log level | expand |
On Wed, May 27, 2020 at 10:57:09AM +0800, Zijun Hu wrote: > Controller ID info got by VSC EDL_PATCH_GETVER is very > important, so improve its log level from DEBUG to INFO. > > Signed-off-by: Zijun Hu <zijuhu@codeaurora.org> > --- > drivers/bluetooth/btqca.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c > index 3ea866d..94d8e15 100644 > --- a/drivers/bluetooth/btqca.c > +++ b/drivers/bluetooth/btqca.c > @@ -74,10 +74,14 @@ int qca_read_soc_version(struct hci_dev *hdev, u32 *soc_version, > > ver = (struct qca_btsoc_version *)(edl->data); > > - BT_DBG("%s: Product:0x%08x", hdev->name, le32_to_cpu(ver->product_id)); > - BT_DBG("%s: Patch :0x%08x", hdev->name, le16_to_cpu(ver->patch_ver)); > - BT_DBG("%s: ROM :0x%08x", hdev->name, le16_to_cpu(ver->rom_ver)); > - BT_DBG("%s: SOC :0x%08x", hdev->name, le32_to_cpu(ver->soc_id)); > + bt_dev_info(hdev, "QCA Product ID :0x%08x", > + le32_to_cpu(ver->product_id)); > + bt_dev_info(hdev, "QCA SOC Version :0x%08x", > + le32_to_cpu(ver->soc_id)); > + bt_dev_info(hdev, "QCA ROM Version :0x%08x", > + le16_to_cpu(ver->rom_ver)); > + bt_dev_info(hdev, "QCA Patch Version:0x%08x", > + le16_to_cpu(ver->patch_ver)); > > /* QCA chipset version can be decided by patch and SoC > * version, combination with upper 2 bytes from SoC Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Hi Zijun, > Controller ID info got by VSC EDL_PATCH_GETVER is very > important, so improve its log level from DEBUG to INFO. > > Signed-off-by: Zijun Hu <zijuhu@codeaurora.org> > --- > drivers/bluetooth/btqca.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c > index 3ea866d..94d8e15 100644 > --- a/drivers/bluetooth/btqca.c > +++ b/drivers/bluetooth/btqca.c > @@ -74,10 +74,14 @@ int qca_read_soc_version(struct hci_dev *hdev, u32 *soc_version, > > ver = (struct qca_btsoc_version *)(edl->data); > > - BT_DBG("%s: Product:0x%08x", hdev->name, le32_to_cpu(ver->product_id)); > - BT_DBG("%s: Patch :0x%08x", hdev->name, le16_to_cpu(ver->patch_ver)); > - BT_DBG("%s: ROM :0x%08x", hdev->name, le16_to_cpu(ver->rom_ver)); > - BT_DBG("%s: SOC :0x%08x", hdev->name, le32_to_cpu(ver->soc_id)); > + bt_dev_info(hdev, "QCA Product ID :0x%08x", > + le32_to_cpu(ver->product_id)); > + bt_dev_info(hdev, "QCA SOC Version :0x%08x", > + le32_to_cpu(ver->soc_id)); > + bt_dev_info(hdev, "QCA ROM Version :0x%08x", > + le16_to_cpu(ver->rom_ver)); > + bt_dev_info(hdev, "QCA Patch Version:0x%08x", > + le16_to_cpu(ver->patch_ver)); please align correctly according to the coding style. Regards Marcel
On 5/28/2020 4:16 PM, Marcel Holtmann wrote: > Hi Zijun, > >> Controller ID info got by VSC EDL_PATCH_GETVER is very >> important, so improve its log level from DEBUG to INFO. >> >> Signed-off-by: Zijun Hu <zijuhu@codeaurora.org> >> --- >> drivers/bluetooth/btqca.c | 12 ++++++++---- >> 1 file changed, 8 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c >> index 3ea866d..94d8e15 100644 >> --- a/drivers/bluetooth/btqca.c >> +++ b/drivers/bluetooth/btqca.c >> @@ -74,10 +74,14 @@ int qca_read_soc_version(struct hci_dev *hdev, u32 *soc_version, >> >> ver = (struct qca_btsoc_version *)(edl->data); >> >> - BT_DBG("%s: Product:0x%08x", hdev->name, le32_to_cpu(ver->product_id)); >> - BT_DBG("%s: Patch :0x%08x", hdev->name, le16_to_cpu(ver->patch_ver)); >> - BT_DBG("%s: ROM :0x%08x", hdev->name, le16_to_cpu(ver->rom_ver)); >> - BT_DBG("%s: SOC :0x%08x", hdev->name, le32_to_cpu(ver->soc_id)); >> + bt_dev_info(hdev, "QCA Product ID :0x%08x", >> + le32_to_cpu(ver->product_id)); >> + bt_dev_info(hdev, "QCA SOC Version :0x%08x", >> + le32_to_cpu(ver->soc_id)); >> + bt_dev_info(hdev, "QCA ROM Version :0x%08x", >> + le16_to_cpu(ver->rom_ver)); >> + bt_dev_info(hdev, "QCA Patch Version:0x%08x", >> + le16_to_cpu(ver->patch_ver)); > > please align correctly according to the coding style. > if bt_dev_info() is wrote at one line, it will exceed 80 characters so i split it at two line and aligned via vim. > Regards > > Marcel >
diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c index 3ea866d..94d8e15 100644 --- a/drivers/bluetooth/btqca.c +++ b/drivers/bluetooth/btqca.c @@ -74,10 +74,14 @@ int qca_read_soc_version(struct hci_dev *hdev, u32 *soc_version, ver = (struct qca_btsoc_version *)(edl->data); - BT_DBG("%s: Product:0x%08x", hdev->name, le32_to_cpu(ver->product_id)); - BT_DBG("%s: Patch :0x%08x", hdev->name, le16_to_cpu(ver->patch_ver)); - BT_DBG("%s: ROM :0x%08x", hdev->name, le16_to_cpu(ver->rom_ver)); - BT_DBG("%s: SOC :0x%08x", hdev->name, le32_to_cpu(ver->soc_id)); + bt_dev_info(hdev, "QCA Product ID :0x%08x", + le32_to_cpu(ver->product_id)); + bt_dev_info(hdev, "QCA SOC Version :0x%08x", + le32_to_cpu(ver->soc_id)); + bt_dev_info(hdev, "QCA ROM Version :0x%08x", + le16_to_cpu(ver->rom_ver)); + bt_dev_info(hdev, "QCA Patch Version:0x%08x", + le16_to_cpu(ver->patch_ver)); /* QCA chipset version can be decided by patch and SoC * version, combination with upper 2 bytes from SoC
Controller ID info got by VSC EDL_PATCH_GETVER is very important, so improve its log level from DEBUG to INFO. Signed-off-by: Zijun Hu <zijuhu@codeaurora.org> --- drivers/bluetooth/btqca.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)