| Message ID | 9884c56219e9bdbeec179c27ea2b734dbb5f1289.1589548223.git.agx@sigxcpu.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge: Add mux input selection bridge | expand |
On Fri, May 15, 2020 at 03:12:12PM +0200, Guido Günther wrote: > No need to encode the SoC specifics in the bridge driver. For the > imx8mq we can use the mux-input-bridge. You can't just change bindings like this. You'd still have to support the "old" way. But IMO, this way is the right way. > > Signed-off-by: Guido Günther <agx@sigxcpu.org> > --- > .../devicetree/bindings/display/bridge/nwl-dsi.yaml | 6 ------ > 1 file changed, 6 deletions(-)
Hi Rob, On Thu, May 28, 2020 at 01:59:14PM -0600, Rob Herring wrote: > On Fri, May 15, 2020 at 03:12:12PM +0200, Guido Günther wrote: > > No need to encode the SoC specifics in the bridge driver. For the > > imx8mq we can use the mux-input-bridge. > > You can't just change bindings like this. You'd still have to support > the "old" way. But IMO, this way is the right way. My understanding is that binding stability only applies to released kernels and this binding never was in released kernel yet. Does it still apply in this case? Cheers, -- Guido > > > > > Signed-off-by: Guido Günther <agx@sigxcpu.org> > > --- > > .../devicetree/bindings/display/bridge/nwl-dsi.yaml | 6 ------ > > 1 file changed, 6 deletions(-) >
diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml index 8aff2d68fc33..d2c2d4e19a25 100644 --- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml +++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml @@ -46,10 +46,6 @@ properties: - const: phy_ref - const: lcdif - mux-controls: - description: - mux controller node to use for operating the input mux - phys: maxItems: 1 description: @@ -151,7 +147,6 @@ required: - clocks - compatible - interrupts - - mux-controls - phy-names - phys - ports @@ -180,7 +175,6 @@ examples: <&clk IMX8MQ_CLK_LCDIF_PIXEL>; clock-names = "core", "rx_esc", "tx_esc", "phy_ref", "lcdif"; interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>; - mux-controls = <&mux 0>; power-domains = <&pgc_mipi>; resets = <&src IMX8MQ_RESET_MIPI_DSI_RESET_BYTE_N>, <&src IMX8MQ_RESET_MIPI_DSI_DPI_RESET_N>,
No need to encode the SoC specifics in the bridge driver. For the imx8mq we can use the mux-input-bridge. Signed-off-by: Guido Günther <agx@sigxcpu.org> --- .../devicetree/bindings/display/bridge/nwl-dsi.yaml | 6 ------ 1 file changed, 6 deletions(-)