| Message ID | 20200528154503.26304-1-brgl@bgdev.pl (mailing list archive) |
|---|---|
| Headers | show |
| Series | regmap: provide simple bitops and use them in a driver | expand |
On Thu, 28 May 2020 17:45:01 +0200, Bartosz Golaszewski wrote: > I noticed that oftentimes I use regmap_update_bits() for simple bit > setting or clearing. In this case the fourth argument is superfluous as > it's always 0 or equal to the mask argument. > > This series proposes to add simple bit operations for setting, clearing > and testing specific bits with regmap. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git for-next Thanks! [1/1] regmap: provide helpers for simple bit operations commit: aa2ff9dbaeddabb5ad166db5f9f1a0580a8bbba8 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
On Fri, May 29, 2020 at 05:52:00PM +0100, Mark Brown wrote: > [1/1] regmap: provide helpers for simple bit operations > commit: aa2ff9dbaeddabb5ad166db5f9f1a0580a8bbba8 Let me know if you need a pull request for this, given the merge window is likely to open over the weekend I figured it's likely too late to apply the second patch before then.
From: Bartosz Golaszewski <brgl@bgdev.pl> Date: Thu, 28 May 2020 17:45:01 +0200 > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > I noticed that oftentimes I use regmap_update_bits() for simple bit > setting or clearing. In this case the fourth argument is superfluous as > it's always 0 or equal to the mask argument. > > This series proposes to add simple bit operations for setting, clearing > and testing specific bits with regmap. > > The second patch uses all three in a driver that got recently picked into > the net-next tree. > > The patches obviously target different trees so - if you're ok with > the change itself - I propose you pick the first one into your regmap > tree for v5.8 and then I'll resend the second patch to add the first > user for these macros for v5.9. > > v1 -> v2: > - convert the new macros to static inline functions > > v2 -> v3: > - drop unneeded ternary operator Series applied to net-next, thank you.
On Mon, Jun 01, 2020 at 11:35:36AM -0700, David Miller wrote: > > v2 -> v3: > > - drop unneeded ternary operator > Series applied to net-next, thank you. I already applied patch 1 and sent a pull request to Linus for it. As I said: | Let me know if you need a pull request for this, given the merge window | is likely to open over the weekend I figured it's likely too late to | apply the second patch before then. Hopefully this merges cleanly... ideally we'd have had that pull request.
From: Bartosz Golaszewski <bgolaszewski@baylibre.com> I noticed that oftentimes I use regmap_update_bits() for simple bit setting or clearing. In this case the fourth argument is superfluous as it's always 0 or equal to the mask argument. This series proposes to add simple bit operations for setting, clearing and testing specific bits with regmap. The second patch uses all three in a driver that got recently picked into the net-next tree. The patches obviously target different trees so - if you're ok with the change itself - I propose you pick the first one into your regmap tree for v5.8 and then I'll resend the second patch to add the first user for these macros for v5.9. v1 -> v2: - convert the new macros to static inline functions v2 -> v3: - drop unneeded ternary operator Bartosz Golaszewski (2): regmap: provide helpers for simple bit operations net: ethernet: mtk-star-emac: use regmap bitops drivers/base/regmap/regmap.c | 22 +++++ drivers/net/ethernet/mediatek/mtk_star_emac.c | 80 ++++++++----------- include/linux/regmap.h | 36 +++++++++ 3 files changed, 93 insertions(+), 45 deletions(-)