| Message ID | 20200522041506.39638-1-jhubbard@nvidia.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | video: fbdev: fix error handling, convert to pin_user_pages*() | expand |
Hi John. On Thu, May 21, 2020 at 09:15:04PM -0700, John Hubbard wrote: > Hi, > > Note that I have only compile-tested this series, although that does > also include cross-compiling for a few other arches. I'm hoping that > this posting will lead to some run-time testing. > > Also: the proposed fix does not have a "Fixes:" tag, nor does it > Cc stable. That's because the issue has been there since the dawn of > git history for the kernel. If it's gone unnoticed this long, then > there is clearly no need for the relatively fast track of putting it > into stable, IMHO. But please correct me if that's wrong. > > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: Gustavo A. R. Silva <gustavo@embeddedor.com> > Cc: Jani Nikula <jani.nikula@intel.com> > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fbdev@vger.kernel.org Thanks, patches are now applied to drm-misc-next. They will hit -next soon, but you will have to wait until next (not the upcoming) merge window before they hit mainline linux. Sam > > John Hubbard (2): > video: fbdev: fix error handling for get_user_pages_fast() > video: fbdev: convert get_user_pages() --> pin_user_pages() > > drivers/video/fbdev/pvr2fb.c | 24 ++++++++++++++++++------ > 1 file changed, 18 insertions(+), 6 deletions(-) > > > base-commit: 051143e1602d90ea71887d92363edd539d411de5 > -- > 2.26.2 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On 2020-05-31 13:58, Sam Ravnborg wrote: ... > Thanks, patches are now applied to drm-misc-next. > They will hit -next soon, but you will have to wait > until next (not the upcoming) merge window before they hit > mainline linux. > > Sam > Great! That will work out just fine. thanks,
On 2020-05-31 14:11, Andy Shevchenko wrote: > ... > JFYI, we have history.git starting from v0.01. > OK, thanks for that note. According to that history.git [1], then: drivers/video/pvr2fb.c had get_user_pages_fast() support added to pvr2fb_write() back in 2004, but only for CONFIG_SH_DMA, as part of commit 434502754f2 ("[PATCH] SH Merge") ...and that commit created the minor bug that patch 0001 here addresses. (+Cc Paul just for the sake of completeness.) [1] git://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git thanks,
On Mon, Jun 1, 2020 at 1:00 AM John Hubbard <jhubbard@nvidia.com> wrote: > On 2020-05-31 14:11, Andy Shevchenko wrote: > > ... > > JFYI, we have history.git starting from v0.01. > > > OK, thanks for that note. According to that history.git [1], > then: drivers/video/pvr2fb.c had get_user_pages_fast() support added to > pvr2fb_write() back in 2004, but only for CONFIG_SH_DMA, as part of > > commit 434502754f2 ("[PATCH] SH Merge") > > ...and that commit created the minor bug that patch 0001 here > addresses. (+Cc Paul just for the sake of completeness.) > > > [1] git://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git I mentioned this one, but I guess content should be the same. https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/
On 2020-06-01 03:35, Andy Shevchenko wrote: > On Mon, Jun 1, 2020 at 1:00 AM John Hubbard <jhubbard@nvidia.com> wrote: >> On 2020-05-31 14:11, Andy Shevchenko wrote: >>> ... >>> JFYI, we have history.git starting from v0.01. >>> >> OK, thanks for that note. According to that history.git [1], >> then: drivers/video/pvr2fb.c had get_user_pages_fast() support added to >> pvr2fb_write() back in 2004, but only for CONFIG_SH_DMA, as part of >> >> commit 434502754f2 ("[PATCH] SH Merge") >> >> ...and that commit created the minor bug that patch 0001 here >> addresses. (+Cc Paul just for the sake of completeness.) >> >> >> [1] git://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git > > I mentioned this one, but I guess content should be the same. > > https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/ > Actually, that history.git *starts* at Linux 2.6.12-rc2, while tglx/history.git *ends* at Linux 2.6.12-rc2 (which is in April, 2005). And the commit I was looking for is in 2004. So that's why I needed a different stretch of history. thanks,
On Mon, Jun 1, 2020 at 8:10 PM John Hubbard <jhubbard@nvidia.com> wrote: > > On 2020-06-01 03:35, Andy Shevchenko wrote: > > On Mon, Jun 1, 2020 at 1:00 AM John Hubbard <jhubbard@nvidia.com> wrote: > >> On 2020-05-31 14:11, Andy Shevchenko wrote: > >>> ... > >>> JFYI, we have history.git starting from v0.01. > >>> > >> OK, thanks for that note. According to that history.git [1], > >> then: drivers/video/pvr2fb.c had get_user_pages_fast() support added to > >> pvr2fb_write() back in 2004, but only for CONFIG_SH_DMA, as part of > >> > >> commit 434502754f2 ("[PATCH] SH Merge") > >> > >> ...and that commit created the minor bug that patch 0001 here > >> addresses. (+Cc Paul just for the sake of completeness.) > >> > >> > >> [1] git://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git > > > > I mentioned this one, but I guess content should be the same. > > > > https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/ > > > > Actually, that history.git *starts* at Linux 2.6.12-rc2, It's not true. > while > tglx/history.git *ends* at Linux 2.6.12-rc2 (which is in April, 2005). > And the commit I was looking for is in 2004. So that's why I needed a > different stretch of history. Actually history/history.git contains all of them starting from v0.01. But it ends, indeed, on 2.6.33.
On 2020-06-01 10:25, Andy Shevchenko wrote: > On Mon, Jun 1, 2020 at 8:10 PM John Hubbard <jhubbard@nvidia.com> wrote: >> >> On 2020-06-01 03:35, Andy Shevchenko wrote: >>> On Mon, Jun 1, 2020 at 1:00 AM John Hubbard <jhubbard@nvidia.com> wrote: >>>> On 2020-05-31 14:11, Andy Shevchenko wrote: >>>>> ... >>>>> JFYI, we have history.git starting from v0.01. >>>>> >>>> OK, thanks for that note. According to that history.git [1], >>>> then: drivers/video/pvr2fb.c had get_user_pages_fast() support added to >>>> pvr2fb_write() back in 2004, but only for CONFIG_SH_DMA, as part of >>>> >>>> commit 434502754f2 ("[PATCH] SH Merge") >>>> >>>> ...and that commit created the minor bug that patch 0001 here >>>> addresses. (+Cc Paul just for the sake of completeness.) >>>> >>>> >>>> [1] git://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git >>> >>> I mentioned this one, but I guess content should be the same. >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/ >>> >> >> Actually, that history.git *starts* at Linux 2.6.12-rc2, > > It's not true. OK I see, neither a straight "git log" nor git branches will suffice, you have to use tags in order to get to the older versions. > >> while >> tglx/history.git *ends* at Linux 2.6.12-rc2 (which is in April, 2005). >> And the commit I was looking for is in 2004. So that's why I needed a >> different stretch of history. > > Actually history/history.git contains all of them starting from v0.01. > But it ends, indeed, on 2.6.33. > thanks,