| Message ID | 20200521034304.340040-2-david@gibson.dropbear.id.au (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RFC,v2,01/18] target/i386: sev: Remove unused QSevGuestInfoClass | expand |
On 5/21/20 5:42 AM, David Gibson wrote: > This structure is nothing but an empty wrapper around the parent class, > which by QOM conventions means we don't need it at all. > > Signed-off-by: David Gibson <david@gibson.dropbear.id.au> > --- > target/i386/sev.c | 1 - > target/i386/sev_i386.h | 5 ----- > 2 files changed, 6 deletions(-) > > diff --git a/target/i386/sev.c b/target/i386/sev.c > index 51cdbe5496..2312510cf2 100644 > --- a/target/i386/sev.c > +++ b/target/i386/sev.c > @@ -287,7 +287,6 @@ static const TypeInfo qsev_guest_info = { > .name = TYPE_QSEV_GUEST_INFO, > .instance_size = sizeof(QSevGuestInfo), > .instance_finalize = qsev_guest_finalize, > - .class_size = sizeof(QSevGuestInfoClass), > .class_init = qsev_guest_class_init, > .instance_init = qsev_guest_init, > .interfaces = (InterfaceInfo[]) { > diff --git a/target/i386/sev_i386.h b/target/i386/sev_i386.h > index 8ada9d385d..4f193642ac 100644 > --- a/target/i386/sev_i386.h > +++ b/target/i386/sev_i386.h > @@ -41,7 +41,6 @@ extern char *sev_get_launch_measurement(void); > extern SevCapability *sev_get_capabilities(void); > > typedef struct QSevGuestInfo QSevGuestInfo; > -typedef struct QSevGuestInfoClass QSevGuestInfoClass; > > /** > * QSevGuestInfo: > @@ -64,10 +63,6 @@ struct QSevGuestInfo { > uint32_t reduced_phys_bits; > }; > > -struct QSevGuestInfoClass { > - ObjectClass parent_class; > -}; > - > struct SEVState { > QSevGuestInfo *sev_info; > uint8_t api_major; > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
On 5/20/20 8:42 PM, David Gibson wrote: > This structure is nothing but an empty wrapper around the parent class, > which by QOM conventions means we don't need it at all. > > Signed-off-by: David Gibson <david@gibson.dropbear.id.au> > --- > target/i386/sev.c | 1 - > target/i386/sev_i386.h | 5 ----- > 2 files changed, 6 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/target/i386/sev.c b/target/i386/sev.c index 51cdbe5496..2312510cf2 100644 --- a/target/i386/sev.c +++ b/target/i386/sev.c @@ -287,7 +287,6 @@ static const TypeInfo qsev_guest_info = { .name = TYPE_QSEV_GUEST_INFO, .instance_size = sizeof(QSevGuestInfo), .instance_finalize = qsev_guest_finalize, - .class_size = sizeof(QSevGuestInfoClass), .class_init = qsev_guest_class_init, .instance_init = qsev_guest_init, .interfaces = (InterfaceInfo[]) { diff --git a/target/i386/sev_i386.h b/target/i386/sev_i386.h index 8ada9d385d..4f193642ac 100644 --- a/target/i386/sev_i386.h +++ b/target/i386/sev_i386.h @@ -41,7 +41,6 @@ extern char *sev_get_launch_measurement(void); extern SevCapability *sev_get_capabilities(void); typedef struct QSevGuestInfo QSevGuestInfo; -typedef struct QSevGuestInfoClass QSevGuestInfoClass; /** * QSevGuestInfo: @@ -64,10 +63,6 @@ struct QSevGuestInfo { uint32_t reduced_phys_bits; }; -struct QSevGuestInfoClass { - ObjectClass parent_class; -}; - struct SEVState { QSevGuestInfo *sev_info; uint8_t api_major;
This structure is nothing but an empty wrapper around the parent class, which by QOM conventions means we don't need it at all. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> --- target/i386/sev.c | 1 - target/i386/sev_i386.h | 5 ----- 2 files changed, 6 deletions(-)