diff mbox series

mm/migrate.c: attach_page_private already does the get_page

Message ID alpine.LSU.2.11.2006021423350.1301@eggly.anvils (mailing list archive)
State New, archived
Headers show
Series mm/migrate.c: attach_page_private already does the get_page | expand

Commit Message

Hugh Dickins June 2, 2020, 9:36 p.m. UTC 
Just finished bisecting mmotm, to find why a test which used to take
four minutes now took more than an hour: the __buffer_migrate_page()
cleanup left behind a get_page() which attach_page_private() now does.

Fixes: cd0f37154443 ("mm/migrate.c: call detach_page_private to cleanup code")
Signed-off-by: Hugh Dickins <hughd@google.com>
---
Fixes the 048/128 of last night's (or today's) incoming from akpm:
sorry I didn't complete the bisection before it went into Linus's tree.

 mm/migrate.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Linus Torvalds June 2, 2020, 10:20 p.m. UTC | #1 
On Tue, Jun 2, 2020 at 2:36 PM Hugh Dickins <hughd@google.com> wrote:
>
> Fixes the 048/128 of last night's (or today's) incoming from akpm:
> sorry I didn't complete the bisection before it went into Linus's tree.

Oh well. I've applied your fix on top of my tree now.

              Linus
diff mbox series

Patch

--- linux.git/mm/migrate.c	2020-06-02 14:04:49.098981268 -0700
+++ linux/mm/migrate.c	2020-06-02 14:07:20.431991495 -0700
@@ -798,7 +798,6 @@  recheck_buffers:
 		goto unlock_buffers;
 
 	attach_page_private(newpage, detach_page_private(page));
-	get_page(newpage);
 
 	bh = head;
 	do {