diff mbox series

[v3,2/3] crypto: CRYPTO_CTR no longer need CRYPTO_SEQIV

Message ID 1587735647-17718-3-git-send-email-clabbe@baylibre.com (mailing list archive)
State Accepted
Delegated to: Herbert Xu
Headers show
Series crypto: fix some DRBG Kconfig deps | expand

Commit Message

Corentin LABBE April 24, 2020, 1:40 p.m. UTC 
As comment of the v2, Herbert said: "The SEQIV select from CTR is historical
and no longer necessary."

So let's get rid of it.

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 crypto/Kconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Eric Biggers June 4, 2020, 4:15 p.m. UTC | #1 
On Fri, Apr 24, 2020 at 01:40:46PM +0000, Corentin Labbe wrote:
> As comment of the v2, Herbert said: "The SEQIV select from CTR is historical
> and no longer necessary."
> 
> So let's get rid of it.
> 
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
>  crypto/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index 6d27fc6a7bf5..a5936e967fe2 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -370,7 +370,6 @@ config CRYPTO_CFB
>  config CRYPTO_CTR
>  	tristate "CTR support"
>  	select CRYPTO_SKCIPHER
> -	select CRYPTO_SEQIV
>  	select CRYPTO_MANAGER
>  	help
>  	  CTR: Counter mode

Shouldn't this patch also have added 'select CRYPTO_SEQIV' to INET_ESP and
INET6_ESP?  Or is the intent to make people explicitly select CRYPTO_SEQIV?

- Eric
diff mbox series

Patch

diff --git a/crypto/Kconfig b/crypto/Kconfig
index 6d27fc6a7bf5..a5936e967fe2 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -370,7 +370,6 @@  config CRYPTO_CFB
 config CRYPTO_CTR
 	tristate "CTR support"
 	select CRYPTO_SKCIPHER
-	select CRYPTO_SEQIV
 	select CRYPTO_MANAGER
 	help
 	  CTR: Counter mode