diff mbox series

sound/pci/hda: add sienna_cichlid audio asic id for sienna_cichlid up

Message ID 20200603013137.1849404-1-alexander.deucher@amd.com (mailing list archive)
State New, archived
Headers show
Series sound/pci/hda: add sienna_cichlid audio asic id for sienna_cichlid up | expand

Commit Message

Alex Deucher June 3, 2020, 1:31 a.m. UTC
From: Hersen Wu <hersenxs.wu@amd.com>

dp/hdmi ati hda is not shown in audio settings

Signed-off-by: Hersen Wu <hersenxs.wu@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
 sound/pci/hda/hda_intel.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Takashi Iwai June 3, 2020, 9:39 a.m. UTC | #1
On Wed, 03 Jun 2020 03:31:37 +0200,
Alex Deucher wrote:
> 
> From: Hersen Wu <hersenxs.wu@amd.com>
> 
> dp/hdmi ati hda is not shown in audio settings
> 
> Signed-off-by: Hersen Wu <hersenxs.wu@amd.com>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

Applied now with a slight rearrangement with the sorted order and Cc
to stable.

But also wondering whether do we have a device with 1002:ab30?
It's missing between this one and the next one.


thanks,

Takashi

> ---
>  sound/pci/hda/hda_intel.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index 92a042e34d3e..4188bc4bd4e2 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -2643,6 +2643,9 @@ static const struct pci_device_id azx_ids[] = {
>  	{ PCI_DEVICE(0x1002, 0xab38),
>  	  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
>  	  AZX_DCAPS_PM_RUNTIME },
> +	{ PCI_DEVICE(0x1002, 0xab28),
> +	  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> +	  AZX_DCAPS_PM_RUNTIME },
>  	/* VIA VT8251/VT8237A */
>  	{ PCI_DEVICE(0x1106, 0x3288), .driver_data = AZX_DRIVER_VIA },
>  	/* VIA GFX VT7122/VX900 */
> -- 
> 2.25.4
>
Alex Deucher June 4, 2020, 4:20 p.m. UTC | #2
On Wed, Jun 3, 2020 at 5:39 AM Takashi Iwai <tiwai@suse.de> wrote:
>
> On Wed, 03 Jun 2020 03:31:37 +0200,
> Alex Deucher wrote:
> >
> > From: Hersen Wu <hersenxs.wu@amd.com>
> >
> > dp/hdmi ati hda is not shown in audio settings
> >
> > Signed-off-by: Hersen Wu <hersenxs.wu@amd.com>
> > Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> > Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>
> Applied now with a slight rearrangement with the sorted order and Cc
> to stable.
>
> But also wondering whether do we have a device with 1002:ab30?
> It's missing between this one and the next one.

Thanks!  I'll check with the audio teams, I'm not sure off hand what
DIDs will be used in upcoming parts.

Alex

>
>
> thanks,
>
> Takashi
>
> > ---
> >  sound/pci/hda/hda_intel.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> > index 92a042e34d3e..4188bc4bd4e2 100644
> > --- a/sound/pci/hda/hda_intel.c
> > +++ b/sound/pci/hda/hda_intel.c
> > @@ -2643,6 +2643,9 @@ static const struct pci_device_id azx_ids[] = {
> >       { PCI_DEVICE(0x1002, 0xab38),
> >         .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> >         AZX_DCAPS_PM_RUNTIME },
> > +     { PCI_DEVICE(0x1002, 0xab28),
> > +       .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> > +       AZX_DCAPS_PM_RUNTIME },
> >       /* VIA VT8251/VT8237A */
> >       { PCI_DEVICE(0x1106, 0x3288), .driver_data = AZX_DRIVER_VIA },
> >       /* VIA GFX VT7122/VX900 */
> > --
> > 2.25.4
> >
diff mbox series

Patch

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 92a042e34d3e..4188bc4bd4e2 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2643,6 +2643,9 @@  static const struct pci_device_id azx_ids[] = {
 	{ PCI_DEVICE(0x1002, 0xab38),
 	  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
 	  AZX_DCAPS_PM_RUNTIME },
+	{ PCI_DEVICE(0x1002, 0xab28),
+	  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
+	  AZX_DCAPS_PM_RUNTIME },
 	/* VIA VT8251/VT8237A */
 	{ PCI_DEVICE(0x1106, 0x3288), .driver_data = AZX_DRIVER_VIA },
 	/* VIA GFX VT7122/VX900 */